scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-10 03:30:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Revert "test(harness): add FABRO_TEST_PROBE_LOG timing probes"

Browse source 
The probe helper served its purpose in narrowing the recent per-test
setup regression to `reap_stale_session_roots`. Remove it now that the
underlying cause (process_running shelling out to `ps`) is fixed and
the reap is amortized to once per process. The plan was to carry it
through verification so Step B could quote reap_nextest numbers, then
drop it — this commit is that drop.

This reverts commit 24e7e5af8.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-04-20 16:36:31 -04:00
parent 2348a1e483
commit 39744068c9
No known key found for this signature in database
1 changed files with 0 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
lib/crates/fabro-test/src/lib.rs
View file

@ -43,28 +43,6 @@ macro_rules! preserve_coverage_env {
}};
}
/// Emit a single timing probe line to `$FABRO_TEST_PROBE_LOG` using an
/// O_APPEND open — POSIX guarantees that a single `write` up to
/// `PIPE_BUF` bytes is atomic, so concurrent test processes writing short
/// lines to the same file do not interleave.
fn probe_emit(test: &str, phase: &str, elapsed: std::time::Duration) {
let Ok(path) = std::env::var("FABRO_TEST_PROBE_LOG") else {
return;
};
use std::io::Write;
// Format the entire line first, then issue exactly one `write` so lines
// from concurrent writers do not interleave (O_APPEND + single syscall
// ≤ PIPE_BUF is atomic per POSIX).
let line = format!("{phase}\t{:.3}\t{test}\n", elapsed.as_secs_f64() * 1000.0);
if let Ok(mut file) = std::fs::OpenOptions::new()
.append(true)
.create(true)
.open(path)
{
let _ = file.write(line.as_bytes());
}
}
/// Walk up from `start` to find the repo-level `test/` fixtures directory.
pub fn find_test_fixtures_dir(start: &Path) -> Option<PathBuf> {
let mut dir = start;
@ -1051,13 +1029,6 @@ impl TestContext {
.next()
.unwrap_or("unknown")
.to_string();
let probe_start = std::time::Instant::now();
let mut last = probe_start;
let mut probe = |phase: &str| {
let now = std::time::Instant::now();
probe_emit(&test_name, phase, now.duration_since(last));
last = now;
};
// Truncate to keep total temp path under Unix socket limit (104 bytes).
// Budget: TMPDIR (~49) + prefix + suffix (~6) + /home/fabro-data/fabro.sock
// (27) < 104
@ -1066,14 +1037,10 @@ impl TestContext {
.prefix(&format!(".ft-{label}-"))
.tempdir()
.expect("failed to create temp dir");
probe("tempdir");
let root_path = context_root.path().to_path_buf();
let (_, test_run_id, session_paths) = session_paths();
probe("session_paths");
NEXTEST_REAPED.get_or_init(|| reap_stale_session_roots(SessionMode::Nextest));
probe("reap_nextest");
PROCESS_REAPED.get_or_init(|| reap_stale_session_roots(SessionMode::Process));
probe("reap_process");
with_session_lock(&session_paths.root, || {
std::fs::create_dir_all(session_clients_dir(&session_paths.root)).unwrap_or_else(
|err| {
@ -1103,7 +1070,6 @@ impl TestContext {
}
write_marker(&session_paths.root);
});
probe("with_session_lock");
let temp_dir = root_path.join("temp");
let home_dir = root_path.join("home");
@ -1118,8 +1084,6 @@ impl TestContext {
&session_paths.server.socket_path,
false,
);
probe("sync_home_settings");
probe_emit(&test_name, "total", probe_start.elapsed());
let temp_dir_str = temp_dir
.to_str()
.expect("temp_dir should be valid UTF-8 for snapshot filtering");