checkpoint

⚒️ Generated with [Fabro](https://fabro.sh)
This commit is contained in:
Fabro 2026-05-22 15:28:23 -04:00
parent 5b54b7c509
commit 3703ff6004
3 changed files with 172 additions and 7 deletions

168
run.json
View file

@ -508,14 +508,106 @@
}
},
"web_url": "http://127.0.0.1:32276/runs/01KS8JHBKEC0JBH6J6MYN37TR5",
"start": null,
"status": {
"kind": "starting"
"start": {
"start_time": "2026-05-22T19:28:19.832468Z",
"run_branch": "fabro/run/01KS8JHBKEC0JBH6J6MYN37TR5",
"base_sha": "203ed5d0290f412088fb02f579922a268e1659a7"
},
"status_updated_at": "2026-05-22T19:28:01.176706Z",
"last_event_at": "2026-05-22T19:28:19.516752Z",
"status": {
"kind": "running"
},
"status_updated_at": "2026-05-22T19:28:19.832547Z",
"last_event_at": "2026-05-22T19:28:21.844455Z",
"pending_control": null,
"checkpoints": [],
"checkpoints": [
{
"seq": 19,
"checkpoint": {
"timestamp": "2026-05-22T19:28:21.844105Z",
"current_node": "start",
"completed_nodes": [
"start"
],
"node_retries": {},
"context_values": {
"internal.node_visit_count": 1,
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
"internal.thread_id": null,
"internal.fidelity": "compact",
"failure_signature": "",
"current_node": "start",
"graph.rankdir": "LR",
"failure_class": "",
"graph.goal": "Implement this inline plan:\n\n# Add `fabro_run_get` for Read-Only Run Inspection\n\n## Summary\nAdd a new MCP/Fabro agent tool, `fabro_run_get`, that is safe to expose in read-only contexts. It will return the current run summary, projection, and pending questions without any mutation capability. Keep `fabro_run_interact` as the operational/human-loop tool, including `get_questions` for agents that are allowed to answer gates, but stop exposing it to Ask Fabro.\n\n## Key Changes\n- Add `fabro_run_get` to `fabro-tool` with input `{ \"run_id\": \"<selector>\" }`.\n- Return a rich read-only payload: resolved `run_id`, run `summary`, run `projection`, and `questions`.\n- Register `fabro_run_get` in the shared Fabro run tool definitions, MCP stdio server, and LLM tool dispatch.\n- Update Ask Fabro to register and allow only `fabro_run_get` plus `fabro_run_events` for run inspection.\n- Keep `fabro_run_interact` backward compatible, including existing `get`, `get_questions`, and mutating actions, but do not expose it in read-only Ask Fabro sessions.\n- Update public MCP docs to list `fabro_run_get` and describe `fabro_run_interact` as control/interaction oriented rather than read-only inspection.\n\n## Implementation Notes\n- Implement the read-only tool in `lib/crates/fabro-tool/src/get.rs`, following the same validation/result style as existing run tools.\n- Wire constants, exports, and tool schema registration through `lib/crates/fabro-tool/src/common.rs` and `lib/crates/fabro-tool/src/lib.rs`.\n- Add MCP and agent dispatch branches in `lib/crates/fabro-mcp-server/src/server.rs` and `lib/crates/fabro-workflow/src/handler/llm/api.rs`.\n- Change `lib/crates/fabro-server/src/server/handler/sessions.rs` so Ask Fabros tool registry and access policy use `FABRO_RUN_GET_TOOL_NAME` instead of `FABRO_RUN_INTERACT_TOOL_NAME`.\n\n## Test Plan\n- Add `fabro_run_get` schema/tool-list coverage in `lib/crates/fabro-cli/tests/it/cmd/mcp.rs`; update expected tool counts.\n- Add an MCP integration test showing `fabro_run_get` resolves a selector and returns summary, projection, and questions.\n- Add Ask Fabro tests showing exposed tool names include `fabro_run_get` and exclude `fabro_run_interact`.\n- Add policy coverage showing Ask Fabro denies `fabro_run_interact`.\n- Run focused tests for `fabro-tool`, MCP CLI tests, and Ask Fabro session tests; then run formatting/clippy if implementation touches Rust style broadly.\n\n## Assumptions\n- `fabro_run_interact.get` stays for compatibility in this change.\n- `get_questions` stays in `fabro_run_interact` because answering gates is still part of operational interaction.\n- Read-only safety is enforced primarily by tool exposure: Ask Fabro should not receive mixed read/write tools.",
"internal.retry_count.start": 0,
"internal.work_dir": "/home/daytona/workspace/fabro",
"outcome": "succeeded",
"internal.run_id": "01KS8JHBKEC0JBH6J6MYN37TR5"
},
"node_outcomes": {
"start": {
"status": "succeeded",
"usage": null
}
},
"next_node_id": "toolchain",
"node_visits": {
"start": 1
}
},
"diff": {}
},
{
"seq": 0,
"checkpoint": {
"timestamp": "2026-05-22T19:28:23.378123Z",
"current_node": "toolchain",
"completed_nodes": [
"start",
"toolchain"
],
"node_retries": {},
"context_values": {
"current_node": "toolchain",
"graph.rankdir": "LR",
"failure_class": "",
"internal.fidelity": "compact",
"internal.retry_count.toolchain": 0,
"internal.retry_count.start": 0,
"internal.work_dir": "/home/daytona/workspace/fabro",
"internal.node_visit_count": 1,
"thread.start.current_node": "toolchain",
"internal.run_id": "01KS8JHBKEC0JBH6J6MYN37TR5",
"failure_signature": "",
"graph.goal": "Implement this inline plan:\n\n# Add `fabro_run_get` for Read-Only Run Inspection\n\n## Summary\nAdd a new MCP/Fabro agent tool, `fabro_run_get`, that is safe to expose in read-only contexts. It will return the current run summary, projection, and pending questions without any mutation capability. Keep `fabro_run_interact` as the operational/human-loop tool, including `get_questions` for agents that are allowed to answer gates, but stop exposing it to Ask Fabro.\n\n## Key Changes\n- Add `fabro_run_get` to `fabro-tool` with input `{ \"run_id\": \"<selector>\" }`.\n- Return a rich read-only payload: resolved `run_id`, run `summary`, run `projection`, and `questions`.\n- Register `fabro_run_get` in the shared Fabro run tool definitions, MCP stdio server, and LLM tool dispatch.\n- Update Ask Fabro to register and allow only `fabro_run_get` plus `fabro_run_events` for run inspection.\n- Keep `fabro_run_interact` backward compatible, including existing `get`, `get_questions`, and mutating actions, but do not expose it in read-only Ask Fabro sessions.\n- Update public MCP docs to list `fabro_run_get` and describe `fabro_run_interact` as control/interaction oriented rather than read-only inspection.\n\n## Implementation Notes\n- Implement the read-only tool in `lib/crates/fabro-tool/src/get.rs`, following the same validation/result style as existing run tools.\n- Wire constants, exports, and tool schema registration through `lib/crates/fabro-tool/src/common.rs` and `lib/crates/fabro-tool/src/lib.rs`.\n- Add MCP and agent dispatch branches in `lib/crates/fabro-mcp-server/src/server.rs` and `lib/crates/fabro-workflow/src/handler/llm/api.rs`.\n- Change `lib/crates/fabro-server/src/server/handler/sessions.rs` so Ask Fabros tool registry and access policy use `FABRO_RUN_GET_TOOL_NAME` instead of `FABRO_RUN_INTERACT_TOOL_NAME`.\n\n## Test Plan\n- Add `fabro_run_get` schema/tool-list coverage in `lib/crates/fabro-cli/tests/it/cmd/mcp.rs`; update expected tool counts.\n- Add an MCP integration test showing `fabro_run_get` resolves a selector and returns summary, projection, and questions.\n- Add Ask Fabro tests showing exposed tool names include `fabro_run_get` and exclude `fabro_run_interact`.\n- Add policy coverage showing Ask Fabro denies `fabro_run_interact`.\n- Run focused tests for `fabro-tool`, MCP CLI tests, and Ask Fabro session tests; then run formatting/clippy if implementation touches Rust style broadly.\n\n## Assumptions\n- `fabro_run_interact.get` stays for compatibility in this change.\n- `get_questions` stays in `fabro_run_interact` because answering gates is still part of operational interaction.\n- Read-only safety is enforced primarily by tool exposure: Ask Fabro should not receive mixed read/write tools.",
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
"internal.thread_id": "start",
"outcome": "succeeded",
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c"
},
"node_outcomes": {
"start": {
"status": "succeeded",
"usage": null
},
"toolchain": {
"status": "succeeded",
"context_updates": {
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c"
},
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
"usage": null
}
},
"next_node_id": "preflight_compile",
"node_visits": {
"start": 1,
"toolchain": 1
}
},
"diff": {}
}
],
"conclusion": null,
"sandbox": {
"provider": "daytona",
@ -536,5 +628,67 @@
"pull_request": null,
"superseded_by": null,
"pending_interviews": {},
"stages": {}
"stages": {
"toolchain@1": {
"first_event_seq": 20,
"prompt": null,
"response": null,
"completion": null,
"provider_used": null,
"diff": null,
"script_invocation": {
"script": "command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
"command": "exec 2>&1\ncommand -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
"language": "shell"
},
"script_timing": null,
"parallel_results": null,
"output": null,
"started_at": "2026-05-22T19:28:21.844371Z",
"handler": "command",
"usage": {
"input_tokens": 0,
"output_tokens": 0,
"total_tokens": 0,
"reasoning_tokens": 0,
"cache_read_tokens": 0,
"cache_write_tokens": 0
},
"state": "running"
},
"start@1": {
"first_event_seq": 16,
"prompt": null,
"response": null,
"completion": {
"outcome": "succeeded",
"notes": null,
"failure_reason": null,
"timestamp": "2026-05-22T19:28:21.843739Z"
},
"provider_used": null,
"diff": null,
"script_invocation": null,
"script_timing": null,
"parallel_results": null,
"output": null,
"started_at": "2026-05-22T19:28:21.843388Z",
"handler": "start",
"timing": {
"wall_time_ms": 0,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"usage": {
"input_tokens": 0,
"output_tokens": 0,
"total_tokens": 0,
"reasoning_tokens": 0,
"cache_read_tokens": 0,
"cache_write_tokens": 0
},
"state": "succeeded"
}
}
}

View file

@ -0,0 +1,6 @@
{
"outcome": "succeeded",
"notes": null,
"failure_reason": null,
"timestamp": "2026-05-22T19:28:21.843739Z"
}

View file

@ -0,0 +1,5 @@
{
"script": "command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
"command": "exec 2>&1\ncommand -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
"language": "shell"
}