scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-11 03:40:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix truncate_goal: handle newlines, reuse for byte-unsafe inline truncation

Browse source 
- Take first line before truncating to prevent multi-line goals from
  breaking table layout
- Move goal field next to other manifest-sourced serialized fields
- Replace byte-slicing truncation in df_from (panics on multibyte chars)
  with the char-safe truncate_goal helper

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-15 16:26:19 -04:00
parent 75da79a860
commit 35d4200417
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/crates/fabro-workflows/src/cli/runs.rs
View file

@ -109,13 +109,13 @@ pub struct RunInfo {
pub total_cost: Option<f64>,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub host_repo_path: Option<String>,
pub goal: String,
#[serde(skip)]
pub start_time_dt: Option<DateTime<Utc>>,
#[serde(skip)]
pub end_time: Option<DateTime<Utc>>,
#[serde(skip)]
pub path: PathBuf,
pub goal: String,
#[serde(skip)]
pub is_orphan: bool,
}
@ -464,9 +464,10 @@ fn short_run_id(id: &str) -> &str {
}
fn truncate_goal(goal: &str, max_len: usize) -> String {
let chars: Vec<char> = goal.chars().collect();
let line = goal.lines().next().unwrap_or("");
let chars: Vec<char> = line.chars().collect();
if chars.len() <= max_len {
return goal.to_string();
return line.to_string();
}
let truncated: String = chars[..max_len - 3].iter().collect();
format!("{truncated}...")
@ -787,11 +788,7 @@ pub fn df_from(args: &DfArgs, data_dir: &Path, runs_base: &Path, logs_base: &Pat
.iter()
.map(|detail| {
let run_id_display = short_run_id(&detail.run_id);
let workflow_display = if detail.workflow_name.len() > 16 {
format!("{}...", &detail.workflow_name[..13])
} else {
detail.workflow_name.clone()
};
let workflow_display = truncate_goal(&detail.workflow_name, 16);
let age = if let Some(dt) = detail.start_time_dt {
let dur = now.signed_duration_since(dt);
if dur.num_days() > 0 {