From 33f4da33c141ac399feee620fae7d484a341fd5b Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Fri, 27 Mar 2026 15:32:06 -0400 Subject: [PATCH] Clean up resolved settings interfaces --- apps/fabro-web/app/routes.ts | 2 +- apps/fabro-web/app/routes/run-graph.tsx | 4 +- apps/fabro-web/app/routes/run-overview.tsx | 4 +- ...run-configuration.tsx => run-settings.tsx} | 20 +- apps/fabro-web/app/routes/run-stages.tsx | 4 +- apps/fabro-web/app/routes/settings.tsx | 10 +- .../app/routes/workflow-definition.tsx | 4 +- apps/fabro-web/app/routes/workflow-detail.tsx | 14 +- docs/api-reference/fabro-api.yaml | 132 ++-- lib/crates/fabro-api/src/demo/mod.rs | 22 +- lib/crates/fabro-api/src/serve.rs | 13 +- lib/crates/fabro-api/src/server.rs | 18 +- .../fabro-api/tests/openapi_conformance.rs | 12 +- lib/crates/fabro-cli/src/cli_config.rs | 2 +- lib/crates/fabro-cli/src/commands/asset/cp.rs | 2 +- .../fabro-cli/src/commands/asset/list.rs | 2 +- lib/crates/fabro-cli/src/commands/doctor.rs | 6 +- lib/crates/fabro-cli/src/commands/exec.rs | 2 +- lib/crates/fabro-cli/src/commands/llm/mod.rs | 2 +- lib/crates/fabro-cli/src/commands/model.rs | 2 +- lib/crates/fabro-cli/src/commands/pr/close.rs | 2 +- .../fabro-cli/src/commands/pr/create.rs | 2 +- lib/crates/fabro-cli/src/commands/pr/list.rs | 2 +- lib/crates/fabro-cli/src/commands/pr/merge.rs | 2 +- lib/crates/fabro-cli/src/commands/pr/mod.rs | 2 +- lib/crates/fabro-cli/src/commands/pr/view.rs | 2 +- .../fabro-cli/src/commands/preflight.rs | 12 +- .../fabro-cli/src/commands/repo/init.rs | 2 +- .../fabro-cli/src/commands/run/attach.rs | 2 +- lib/crates/fabro-cli/src/commands/run/cp.rs | 2 +- .../fabro-cli/src/commands/run/create.rs | 14 +- .../fabro-cli/src/commands/run/detached.rs | 14 +- lib/crates/fabro-cli/src/commands/run/diff.rs | 2 +- .../fabro-cli/src/commands/run/execute.rs | 691 ++++-------------- lib/crates/fabro-cli/src/commands/run/logs.rs | 2 +- lib/crates/fabro-cli/src/commands/run/mod.rs | 10 +- .../fabro-cli/src/commands/run/preview.rs | 2 +- .../fabro-cli/src/commands/run/resume.rs | 2 +- lib/crates/fabro-cli/src/commands/run/ssh.rs | 2 +- .../fabro-cli/src/commands/run/start.rs | 2 +- lib/crates/fabro-cli/src/commands/run/wait.rs | 2 +- .../fabro-cli/src/commands/runs/inspect.rs | 2 +- .../fabro-cli/src/commands/runs/list.rs | 2 +- lib/crates/fabro-cli/src/commands/runs/rm.rs | 2 +- .../fabro-cli/src/commands/system/df.rs | 2 +- .../fabro-cli/src/commands/system/prune.rs | 2 +- lib/crates/fabro-cli/src/main.rs | 20 +- lib/crates/fabro-cli/tests/cli.rs | 10 +- lib/crates/fabro-config/src/server.rs | 4 + lib/crates/fabro-config/src/settings.rs | 36 + .../src/handler/manager_loop.rs | 3 +- .../fabro-workflows/src/lifecycle/git.rs | 2 +- .../fabro-workflows/src/operations/create.rs | 48 +- .../fabro-workflows/src/operations/start.rs | 15 +- .../fabro-workflows/src/pipeline/execute.rs | 2 +- .../src/pipeline/execute/tests.rs | 5 +- .../fabro-workflows/src/pipeline/finalize.rs | 3 +- .../src/pipeline/initialize.rs | 7 +- .../fabro-workflows/src/pipeline/persist.rs | 2 +- .../src/pipeline/pull_request.rs | 2 +- .../fabro-workflows/src/pipeline/retro.rs | 5 +- lib/crates/fabro-workflows/src/records/run.rs | 4 +- lib/crates/fabro-workflows/src/run_options.rs | 13 +- .../fabro-workflows/src/test_support.rs | 2 +- .../tests/daytona_integration.rs | 18 +- .../fabro-workflows/tests/integration.rs | 342 +++------ .../src/api/run-internals-api.ts | 39 +- .../fabro-api-client/src/api/settings-api.ts | 35 +- .../fabro-api-client/src/api/workflows-api.ts | 9 +- .../src/models/api-configuration.ts | 12 +- .../src/models/assets-configuration.ts | 2 +- .../src/models/auth-configuration.ts | 8 +- .../src/models/checkpoint-configuration.ts | 2 +- .../daytona-configuration-network-one-of.ts | 2 +- .../models/daytona-configuration-network.ts | 6 +- .../src/models/daytona-configuration.ts | 10 +- .../models/daytona-snapshot-configuration.ts | 2 +- .../src/models/exe-configuration.ts | 2 +- .../src/models/git-author-configuration.ts | 2 +- .../src/models/git-configuration.ts | 16 +- .../src/models/git-hub-configuration.ts | 2 +- .../src/models/llm-configuration.ts | 2 +- .../src/models/local-sandbox-configuration.ts | 8 +- .../src/models/log-configuration.ts | 2 +- .../src/models/pull-request-configuration.ts | 2 +- .../src/models/run-configuration.ts | 19 +- .../src/models/sandbox-configuration.ts | 18 +- .../src/models/server-configuration.ts | 49 +- .../src/models/setup-configuration.ts | 2 +- .../src/models/ssh-configuration.ts | 2 +- .../src/models/tls-configuration.ts | 2 +- .../src/models/web-configuration.ts | 6 +- .../src/models/webhook-configuration.ts | 8 +- .../src/models/workflow-detail.ts | 7 +- 94 files changed, 691 insertions(+), 1188 deletions(-) rename apps/fabro-web/app/routes/{run-configuration.tsx => run-settings.tsx} (84%) diff --git a/apps/fabro-web/app/routes.ts b/apps/fabro-web/app/routes.ts index 8759b626f..780553f0b 100644 --- a/apps/fabro-web/app/routes.ts +++ b/apps/fabro-web/app/routes.ts @@ -25,7 +25,7 @@ export default [ route("runs/:id", "routes/run-detail.tsx", [ index("routes/run-overview.tsx"), route("stages/:stageId", "routes/run-stages.tsx"), - route("configuration", "routes/run-configuration.tsx"), + route("settings", "routes/run-settings.tsx"), route("graph", "routes/run-graph.tsx"), route("files", "routes/run-files.tsx"), route("verification", "routes/run-verification.tsx"), diff --git a/apps/fabro-web/app/routes/run-graph.tsx b/apps/fabro-web/app/routes/run-graph.tsx index ceab91895..9ad786fc4 100644 --- a/apps/fabro-web/app/routes/run-graph.tsx +++ b/apps/fabro-web/app/routes/run-graph.tsx @@ -305,11 +305,11 @@ export default function RunGraph({ loaderData }: Route.ComponentProps) {