mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-14 23:22:51 +00:00
parent
7b1cdb3619
commit
2774ab574e
5 changed files with 158 additions and 21 deletions
159
run.json
159
run.json
|
|
@ -521,7 +521,7 @@
|
|||
"kind": "running"
|
||||
},
|
||||
"status_updated_at": "2026-05-23T10:02:04.125640Z",
|
||||
"last_event_at": "2026-05-23T10:02:06.019276Z",
|
||||
"last_event_at": "2026-05-23T10:02:14.197339Z",
|
||||
"pending_control": null,
|
||||
"checkpoints": [
|
||||
{
|
||||
|
|
@ -562,9 +562,9 @@
|
|||
"diff": {}
|
||||
},
|
||||
{
|
||||
"seq": 0,
|
||||
"seq": 27,
|
||||
"checkpoint": {
|
||||
"timestamp": "2026-05-23T10:02:08.314230Z",
|
||||
"timestamp": "2026-05-23T10:02:14.192720Z",
|
||||
"current_node": "toolchain",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
|
|
@ -572,22 +572,22 @@
|
|||
],
|
||||
"node_retries": {},
|
||||
"context_values": {
|
||||
"internal.thread_id": "start",
|
||||
"internal.work_dir": "/home/daytona/workspace/fabro",
|
||||
"internal.retry_count.start": 0,
|
||||
"failure_signature": "",
|
||||
"internal.run_id": "01KSA4H7JHBRPXZM3XTJ4SD9QA",
|
||||
"internal.node_visit_count": 1,
|
||||
"graph.goal": "---\ntitle: Add Manual Run Retry\ntype: feat\nstatus: active\ndate: 2026-05-23\n---\n\n# Add Manual Run Retry\n\n## Summary\n\nAdd a **Retry** action for failed Fabro runs that creates and immediately starts a new run from the failed run's captured run definition. The new run is independent runtime state, records `retried_from: <source_run_id>`, and leaves the source run unchanged.\n\nThis is a fresh run, not resume/fork/rewind. It should copy the source run's durable definition and settings, but not checkpoints, stage state, sandbox state, PR links, billing, questions, conclusions, or pending controls.\n\n## Key Changes\n\n- Add `retried_from` as a nullable public field on `Run`.\n - Store it on the new run only.\n - Do not add a reverse `retried_by` field in v1.\n - Preserve backward compatibility with old events by defaulting to `null`.\n\n- Add `POST /api/v1/runs/{id}/retry`.\n - Response: `201` with the newly created/queued `Run`.\n - Eligible source states: `failed` except `reason=cancelled`, and `dead`.\n - Reject active, succeeded, cancelled, archived, and missing runs with existing API error patterns.\n - The new run should use the current authenticated actor as `created_by`.\n - The new run should preserve the source run's current `parent_id`, title, labels, workflow graph/source, resolved settings, git context, manifest/definition blob refs, and `fork_source_ref` if present.\n\n- Implement retry using a workflow operation similar in shape to `fork`, but without replaying checkpoint/runtime events.\n - Create a new run store.\n - Append `run.created` with `retried_from`.\n - Append `run.submitted`.\n - Queue/start it through the same internal start path used by `POST /runs/{id}/start`.\n\n- Update OpenAPI and generated clients.\n - Edit `docs/public/api-reference/fabro-api.yaml`.\n - Regenerate Rust API types through `cargo build -p fabro-api`.\n - Regenerate TypeScript client in `lib/packages/fabro-api-client`.\n\n- Update the web UI.\n - Add `Retry` to the run action menu for eligible failed/dead runs.\n - Disable the action while pending.\n - On success, navigate to the new run page and refresh run/list caches.\n - Add a compact \"Retried from\" link in the run summary panel when `retried_from` is present.\n - Add demo-mode support or hide the action in demo mode so the button never navigates to a missing demo run.\n\n## Test Plan\n\n- Rust workflow/store tests:\n - `run.created` serializes/deserializes `retried_from`.\n - Old `run.created` events project with `retried_from = None`.\n - Retry creates a new run with a different ID, copied durable definition, no runtime state, and `retried_from` set.\n - Retry preserves current `parent_id`, title, labels, git context, settings, and `fork_source_ref`.\n - Retry rejects succeeded, active, cancelled, and archived source runs.\n\n- Rust server/API tests:\n - `POST /runs/{id}/retry` on a failed run returns `201`, a new run ID, `retried_from`, and queued/started lifecycle state.\n - Source run remains unchanged.\n - `404` for unknown run.\n - `409` for non-retryable status.\n - Generated Rust API compiles against the updated OpenAPI contract.\n\n- Web tests:\n - `canRetry` returns true for failed/dead, false for cancelled/succeeded/active/archived.\n - Action menu renders `Retry` only when eligible.\n - Successful retry calls the generated client and navigates to `/runs/:newId`.\n - Retry errors show a useful toast/message.\n - Run summary panel renders the `Retried from` link when present.\n - Typecheck passes with regenerated client types.\n\n## Assumptions\n\n- V1 does not add a CLI `fabro retry` command.\n- V1 does not add automatic retry attempts, retry counts, or idempotency keys.\n- Multiple manual clicks after the first request completes may create multiple retry runs.\n- \"Same settings\" means the source run's captured durable definition/settings, not latest local files from the user's machine.\n- Cancelled runs are excluded because cancellation is user intent, not execution failure.\n",
|
||||
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
|
||||
"graph.rankdir": "LR",
|
||||
"internal.fidelity": "compact",
|
||||
"failure_class": "",
|
||||
"current_node": "toolchain",
|
||||
"thread.start.current_node": "toolchain",
|
||||
"internal.retry_count.toolchain": 0,
|
||||
"outcome": "succeeded"
|
||||
"outcome": "succeeded",
|
||||
"current_node": "toolchain",
|
||||
"failure_signature": "",
|
||||
"internal.retry_count.start": 0,
|
||||
"internal.thread_id": "start",
|
||||
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"graph.goal": "---\ntitle: Add Manual Run Retry\ntype: feat\nstatus: active\ndate: 2026-05-23\n---\n\n# Add Manual Run Retry\n\n## Summary\n\nAdd a **Retry** action for failed Fabro runs that creates and immediately starts a new run from the failed run's captured run definition. The new run is independent runtime state, records `retried_from: <source_run_id>`, and leaves the source run unchanged.\n\nThis is a fresh run, not resume/fork/rewind. It should copy the source run's durable definition and settings, but not checkpoints, stage state, sandbox state, PR links, billing, questions, conclusions, or pending controls.\n\n## Key Changes\n\n- Add `retried_from` as a nullable public field on `Run`.\n - Store it on the new run only.\n - Do not add a reverse `retried_by` field in v1.\n - Preserve backward compatibility with old events by defaulting to `null`.\n\n- Add `POST /api/v1/runs/{id}/retry`.\n - Response: `201` with the newly created/queued `Run`.\n - Eligible source states: `failed` except `reason=cancelled`, and `dead`.\n - Reject active, succeeded, cancelled, archived, and missing runs with existing API error patterns.\n - The new run should use the current authenticated actor as `created_by`.\n - The new run should preserve the source run's current `parent_id`, title, labels, workflow graph/source, resolved settings, git context, manifest/definition blob refs, and `fork_source_ref` if present.\n\n- Implement retry using a workflow operation similar in shape to `fork`, but without replaying checkpoint/runtime events.\n - Create a new run store.\n - Append `run.created` with `retried_from`.\n - Append `run.submitted`.\n - Queue/start it through the same internal start path used by `POST /runs/{id}/start`.\n\n- Update OpenAPI and generated clients.\n - Edit `docs/public/api-reference/fabro-api.yaml`.\n - Regenerate Rust API types through `cargo build -p fabro-api`.\n - Regenerate TypeScript client in `lib/packages/fabro-api-client`.\n\n- Update the web UI.\n - Add `Retry` to the run action menu for eligible failed/dead runs.\n - Disable the action while pending.\n - On success, navigate to the new run page and refresh run/list caches.\n - Add a compact \"Retried from\" link in the run summary panel when `retried_from` is present.\n - Add demo-mode support or hide the action in demo mode so the button never navigates to a missing demo run.\n\n## Test Plan\n\n- Rust workflow/store tests:\n - `run.created` serializes/deserializes `retried_from`.\n - Old `run.created` events project with `retried_from = None`.\n - Retry creates a new run with a different ID, copied durable definition, no runtime state, and `retried_from` set.\n - Retry preserves current `parent_id`, title, labels, git context, settings, and `fork_source_ref`.\n - Retry rejects succeeded, active, cancelled, and archived source runs.\n\n- Rust server/API tests:\n - `POST /runs/{id}/retry` on a failed run returns `201`, a new run ID, `retried_from`, and queued/started lifecycle state.\n - Source run remains unchanged.\n - `404` for unknown run.\n - `409` for non-retryable status.\n - Generated Rust API compiles against the updated OpenAPI contract.\n\n- Web tests:\n - `canRetry` returns true for failed/dead, false for cancelled/succeeded/active/archived.\n - Action menu renders `Retry` only when eligible.\n - Successful retry calls the generated client and navigates to `/runs/:newId`.\n - Retry errors show a useful toast/message.\n - Run summary panel renders the `Retried from` link when present.\n - Typecheck passes with regenerated client types.\n\n## Assumptions\n\n- V1 does not add a CLI `fabro retry` command.\n- V1 does not add automatic retry attempts, retry counts, or idempotency keys.\n- Multiple manual clicks after the first request completes may create multiple retry runs.\n- \"Same settings\" means the source run's captured durable definition/settings, not latest local files from the user's machine.\n- Cancelled runs are excluded because cancellation is user intent, not execution failure.\n",
|
||||
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
|
||||
"thread.start.current_node": "toolchain",
|
||||
"failure_class": "",
|
||||
"internal.fidelity": "compact",
|
||||
"internal.run_id": "01KSA4H7JHBRPXZM3XTJ4SD9QA",
|
||||
"graph.rankdir": "LR",
|
||||
"internal.node_visit_count": 1,
|
||||
"internal.work_dir": "/home/daytona/workspace/fabro"
|
||||
},
|
||||
"node_outcomes": {
|
||||
"start": {
|
||||
|
|
@ -604,11 +604,80 @@
|
|||
}
|
||||
},
|
||||
"next_node_id": "preflight_compile",
|
||||
"git_commit_sha": "487fc5d6b6314a13598104b60df8c1e802430145",
|
||||
"node_visits": {
|
||||
"start": 1,
|
||||
"toolchain": 1
|
||||
}
|
||||
},
|
||||
"diff": {
|
||||
"summary": {
|
||||
"files_changed": 0,
|
||||
"additions": 0,
|
||||
"deletions": 0
|
||||
}
|
||||
}
|
||||
},
|
||||
{
|
||||
"seq": 0,
|
||||
"checkpoint": {
|
||||
"timestamp": "2026-05-23T10:04:07.424293Z",
|
||||
"current_node": "preflight_compile",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
"toolchain",
|
||||
"preflight_compile"
|
||||
],
|
||||
"node_retries": {},
|
||||
"context_values": {
|
||||
"internal.thread_id": "toolchain",
|
||||
"internal.work_dir": "/home/daytona/workspace/fabro",
|
||||
"internal.retry_count.start": 0,
|
||||
"failure_signature": "",
|
||||
"internal.run_id": "01KSA4H7JHBRPXZM3XTJ4SD9QA",
|
||||
"internal.node_visit_count": 1,
|
||||
"graph.goal": "---\ntitle: Add Manual Run Retry\ntype: feat\nstatus: active\ndate: 2026-05-23\n---\n\n# Add Manual Run Retry\n\n## Summary\n\nAdd a **Retry** action for failed Fabro runs that creates and immediately starts a new run from the failed run's captured run definition. The new run is independent runtime state, records `retried_from: <source_run_id>`, and leaves the source run unchanged.\n\nThis is a fresh run, not resume/fork/rewind. It should copy the source run's durable definition and settings, but not checkpoints, stage state, sandbox state, PR links, billing, questions, conclusions, or pending controls.\n\n## Key Changes\n\n- Add `retried_from` as a nullable public field on `Run`.\n - Store it on the new run only.\n - Do not add a reverse `retried_by` field in v1.\n - Preserve backward compatibility with old events by defaulting to `null`.\n\n- Add `POST /api/v1/runs/{id}/retry`.\n - Response: `201` with the newly created/queued `Run`.\n - Eligible source states: `failed` except `reason=cancelled`, and `dead`.\n - Reject active, succeeded, cancelled, archived, and missing runs with existing API error patterns.\n - The new run should use the current authenticated actor as `created_by`.\n - The new run should preserve the source run's current `parent_id`, title, labels, workflow graph/source, resolved settings, git context, manifest/definition blob refs, and `fork_source_ref` if present.\n\n- Implement retry using a workflow operation similar in shape to `fork`, but without replaying checkpoint/runtime events.\n - Create a new run store.\n - Append `run.created` with `retried_from`.\n - Append `run.submitted`.\n - Queue/start it through the same internal start path used by `POST /runs/{id}/start`.\n\n- Update OpenAPI and generated clients.\n - Edit `docs/public/api-reference/fabro-api.yaml`.\n - Regenerate Rust API types through `cargo build -p fabro-api`.\n - Regenerate TypeScript client in `lib/packages/fabro-api-client`.\n\n- Update the web UI.\n - Add `Retry` to the run action menu for eligible failed/dead runs.\n - Disable the action while pending.\n - On success, navigate to the new run page and refresh run/list caches.\n - Add a compact \"Retried from\" link in the run summary panel when `retried_from` is present.\n - Add demo-mode support or hide the action in demo mode so the button never navigates to a missing demo run.\n\n## Test Plan\n\n- Rust workflow/store tests:\n - `run.created` serializes/deserializes `retried_from`.\n - Old `run.created` events project with `retried_from = None`.\n - Retry creates a new run with a different ID, copied durable definition, no runtime state, and `retried_from` set.\n - Retry preserves current `parent_id`, title, labels, git context, settings, and `fork_source_ref`.\n - Retry rejects succeeded, active, cancelled, and archived source runs.\n\n- Rust server/API tests:\n - `POST /runs/{id}/retry` on a failed run returns `201`, a new run ID, `retried_from`, and queued/started lifecycle state.\n - Source run remains unchanged.\n - `404` for unknown run.\n - `409` for non-retryable status.\n - Generated Rust API compiles against the updated OpenAPI contract.\n\n- Web tests:\n - `canRetry` returns true for failed/dead, false for cancelled/succeeded/active/archived.\n - Action menu renders `Retry` only when eligible.\n - Successful retry calls the generated client and navigates to `/runs/:newId`.\n - Retry errors show a useful toast/message.\n - Run summary panel renders the `Retried from` link when present.\n - Typecheck passes with regenerated client types.\n\n## Assumptions\n\n- V1 does not add a CLI `fabro retry` command.\n- V1 does not add automatic retry attempts, retry counts, or idempotency keys.\n- Multiple manual clicks after the first request completes may create multiple retry runs.\n- \"Same settings\" means the source run's captured durable definition/settings, not latest local files from the user's machine.\n- Cancelled runs are excluded because cancellation is user intent, not execution failure.\n",
|
||||
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126",
|
||||
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
|
||||
"graph.rankdir": "LR",
|
||||
"internal.retry_count.preflight_compile": 0,
|
||||
"internal.fidelity": "compact",
|
||||
"failure_class": "",
|
||||
"current_node": "preflight_compile",
|
||||
"thread.start.current_node": "toolchain",
|
||||
"internal.retry_count.toolchain": 0,
|
||||
"outcome": "succeeded",
|
||||
"thread.toolchain.current_node": "preflight_compile"
|
||||
},
|
||||
"node_outcomes": {
|
||||
"start": {
|
||||
"status": "succeeded",
|
||||
"usage": null
|
||||
},
|
||||
"preflight_compile": {
|
||||
"status": "succeeded",
|
||||
"context_updates": {
|
||||
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126"
|
||||
},
|
||||
"notes": "Script completed: cargo check -q --workspace 2>&1",
|
||||
"usage": null
|
||||
},
|
||||
"toolchain": {
|
||||
"status": "succeeded",
|
||||
"context_updates": {
|
||||
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c"
|
||||
},
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"usage": null
|
||||
}
|
||||
},
|
||||
"next_node_id": "preflight_lint",
|
||||
"node_visits": {
|
||||
"start": 1,
|
||||
"toolchain": 1,
|
||||
"preflight_compile": 1
|
||||
}
|
||||
},
|
||||
"diff": {}
|
||||
}
|
||||
],
|
||||
|
|
@ -637,7 +706,12 @@
|
|||
"first_event_seq": 20,
|
||||
"prompt": null,
|
||||
"response": null,
|
||||
"completion": null,
|
||||
"completion": {
|
||||
"outcome": "succeeded",
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-05-23T10:02:08.313422Z"
|
||||
},
|
||||
"provider_used": null,
|
||||
"diff": null,
|
||||
"script_invocation": {
|
||||
|
|
@ -645,11 +719,27 @@
|
|||
"command": "exec 2>&1\ncommand -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"language": "shell"
|
||||
},
|
||||
"script_timing": null,
|
||||
"script_timing": {
|
||||
"output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"exit_code": 0,
|
||||
"duration_ms": 2284,
|
||||
"termination": "exited",
|
||||
"output_bytes": 36,
|
||||
"live_streaming": true
|
||||
},
|
||||
"parallel_results": null,
|
||||
"output": null,
|
||||
"output_bytes": 36,
|
||||
"live_streaming": true,
|
||||
"termination": "exited",
|
||||
"started_at": "2026-05-23T10:02:06.019245Z",
|
||||
"handler": "command",
|
||||
"timing": {
|
||||
"wall_time_ms": 2293,
|
||||
"inference_time_ms": 0,
|
||||
"tool_time_ms": 0,
|
||||
"active_time_ms": 0
|
||||
},
|
||||
"usage": {
|
||||
"input_tokens": 0,
|
||||
"output_tokens": 0,
|
||||
|
|
@ -658,7 +748,7 @@
|
|||
"cache_read_tokens": 0,
|
||||
"cache_write_tokens": 0
|
||||
},
|
||||
"state": "running"
|
||||
"state": "succeeded"
|
||||
},
|
||||
"start@1": {
|
||||
"first_event_seq": 16,
|
||||
|
|
@ -693,6 +783,33 @@
|
|||
"cache_write_tokens": 0
|
||||
},
|
||||
"state": "succeeded"
|
||||
},
|
||||
"preflight_compile@1": {
|
||||
"first_event_seq": 30,
|
||||
"prompt": null,
|
||||
"response": null,
|
||||
"completion": null,
|
||||
"provider_used": null,
|
||||
"diff": null,
|
||||
"script_invocation": {
|
||||
"script": "cargo check -q --workspace 2>&1",
|
||||
"command": "exec 2>&1\ncargo check -q --workspace 2>&1",
|
||||
"language": "shell"
|
||||
},
|
||||
"script_timing": null,
|
||||
"parallel_results": null,
|
||||
"output": null,
|
||||
"started_at": "2026-05-23T10:02:14.197058Z",
|
||||
"handler": "command",
|
||||
"usage": {
|
||||
"input_tokens": 0,
|
||||
"output_tokens": 0,
|
||||
"total_tokens": 0,
|
||||
"reasoning_tokens": 0,
|
||||
"cache_read_tokens": 0,
|
||||
"cache_write_tokens": 0
|
||||
},
|
||||
"state": "running"
|
||||
}
|
||||
}
|
||||
}
|
||||
1
stages/002-toolchain@1/output.log
Normal file
1
stages/002-toolchain@1/output.log
Normal file
|
|
@ -0,0 +1 @@
|
|||
blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c
|
||||
8
stages/002-toolchain@1/script_timing.json
Normal file
8
stages/002-toolchain@1/script_timing.json
Normal file
|
|
@ -0,0 +1,8 @@
|
|||
{
|
||||
"output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"exit_code": 0,
|
||||
"duration_ms": 2284,
|
||||
"termination": "exited",
|
||||
"output_bytes": 36,
|
||||
"live_streaming": true
|
||||
}
|
||||
6
stages/002-toolchain@1/status.json
Normal file
6
stages/002-toolchain@1/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"outcome": "succeeded",
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-05-23T10:02:08.313422Z"
|
||||
}
|
||||
5
stages/003-preflight_compile@1/script_invocation.json
Normal file
5
stages/003-preflight_compile@1/script_invocation.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"script": "cargo check -q --workspace 2>&1",
|
||||
"command": "exec 2>&1\ncargo check -q --workspace 2>&1",
|
||||
"language": "shell"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue