From 19f7479490532848ba5125454104b2fdde06d508 Mon Sep 17 00:00:00 2001
From: Bryan Helmkamp <bryan@brynary.com>
Date: Mon, 11 May 2026 12:09:48 -0400
Subject: [PATCH] refactor(mcp): reuse manifest args emptiness check

---
 lib/crates/fabro-mcp-server/src/run_tools.rs | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/lib/crates/fabro-mcp-server/src/run_tools.rs b/lib/crates/fabro-mcp-server/src/run_tools.rs
index 1b8a91e61..163da1ff5 100644
--- a/lib/crates/fabro-mcp-server/src/run_tools.rs
+++ b/lib/crates/fabro-mcp-server/src/run_tools.rs
@@ -918,7 +918,7 @@ fn mcp_manifest_args(spec: &CreateRunSpec) -> Option<types::ManifestArgs> {
         sandbox: spec.sandbox.clone(),
         verbose: None,
     };
-    (!mcp_manifest_args_is_empty(&payload)).then_some(payload)
+    (!fabro_manifest::manifest_args_is_empty(&payload)).then_some(payload)
 }
 
 fn mcp_run_overrides(spec: &CreateRunSpec) -> Option<RunLayer> {
@@ -934,19 +934,6 @@ fn mcp_run_overrides(spec: &CreateRunSpec) -> Option<RunLayer> {
     })
 }
 
-fn mcp_manifest_args_is_empty(args: &types::ManifestArgs) -> bool {
-    args.auto_approve.is_none()
-        && args.docker_image.is_none()
-        && args.dry_run.is_none()
-        && args.input.is_empty()
-        && args.label.is_empty()
-        && args.model.is_none()
-        && args.preserve_sandbox.is_none()
-        && args.provider.is_none()
-        && args.sandbox.is_none()
-        && args.verbose.is_none()
-}
-
 fn json_to_toml_value(key: &str, value: &Value) -> ToolResult<toml::Value> {
     match value {
         Value::Null => Err(ToolError::message(format!(