From 1806aa86d646db11a9c65abd80e83af27889bbca Mon Sep 17 00:00:00 2001
From: Bryan Helmkamp <bryan@brynary.com>
Date: Sat, 14 Mar 2026 16:43:23 -0400
Subject: [PATCH] Add `inherit = false` to all trycmd test envs to prevent CI
 flakiness

The doctor dry-run test was failing in CI because it inherited the host
environment. With no LLM API keys set, the doctor reported errors and
exited non-zero. Adding `inherit = false` to all 18 .toml test files
ensures deterministic behavior regardless of the host environment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 lib/crates/fabro-cli/tests/cmd/doctor/dry-run-flag.toml       | 1 +
 lib/crates/fabro-cli/tests/cmd/llm/prompt-bad-option.toml     | 3 +++
 lib/crates/fabro-cli/tests/cmd/llm/prompt-no-text.toml        | 3 +++
 lib/crates/fabro-cli/tests/cmd/llm/prompt-schema-invalid.toml | 3 +++
 lib/crates/fabro-cli/tests/cmd/run/dry-run-branching.toml     | 3 +++
 lib/crates/fabro-cli/tests/cmd/run/dry-run-conditions.toml    | 3 +++
 lib/crates/fabro-cli/tests/cmd/run/dry-run-legacy-tool.toml   | 3 +++
 lib/crates/fabro-cli/tests/cmd/run/dry-run-parallel.toml      | 3 +++
 lib/crates/fabro-cli/tests/cmd/run/dry-run-simple.toml        | 3 +++
 lib/crates/fabro-cli/tests/cmd/run/dry-run-styled.toml        | 3 +++
 lib/crates/fabro-cli/tests/cmd/top-level/no-dotenv-flag.toml  | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/branching.toml        | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/conditions.toml       | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/invalid.toml          | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/legacy-tool.toml      | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/parallel.toml         | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/simple.toml           | 3 +++
 lib/crates/fabro-cli/tests/cmd/validate/styled.toml           | 3 +++
 18 files changed, 52 insertions(+)

diff --git a/lib/crates/fabro-cli/tests/cmd/doctor/dry-run-flag.toml b/lib/crates/fabro-cli/tests/cmd/doctor/dry-run-flag.toml
index 9d644266a..1738837d1 100644
--- a/lib/crates/fabro-cli/tests/cmd/doctor/dry-run-flag.toml
+++ b/lib/crates/fabro-cli/tests/cmd/doctor/dry-run-flag.toml
@@ -3,3 +3,4 @@ args = ["doctor", "--dry-run"]
 
 [env]
 inherit = false
+ANTHROPIC_API_KEY = "sk-test-dummy"
diff --git a/lib/crates/fabro-cli/tests/cmd/llm/prompt-bad-option.toml b/lib/crates/fabro-cli/tests/cmd/llm/prompt-bad-option.toml
index b1130b083..a2b0468bc 100644
--- a/lib/crates/fabro-cli/tests/cmd/llm/prompt-bad-option.toml
+++ b/lib/crates/fabro-cli/tests/cmd/llm/prompt-bad-option.toml
@@ -2,3 +2,6 @@ bin.name = "fabro"
 args = ["llm", "prompt", "-o", "bad_option", "hello"]
 status = "failed"
 stderr-to-stdout = true
+
+[env]
+inherit = false
diff --git a/lib/crates/fabro-cli/tests/cmd/llm/prompt-no-text.toml b/lib/crates/fabro-cli/tests/cmd/llm/prompt-no-text.toml
index 02d77ff81..615ad67fc 100644
--- a/lib/crates/fabro-cli/tests/cmd/llm/prompt-no-text.toml
+++ b/lib/crates/fabro-cli/tests/cmd/llm/prompt-no-text.toml
@@ -2,3 +2,6 @@ bin.name = "fabro"
 args = ["llm", "prompt"]
 status = "failed"
 stderr-to-stdout = true
+
+[env]
+inherit = false
diff --git a/lib/crates/fabro-cli/tests/cmd/llm/prompt-schema-invalid.toml b/lib/crates/fabro-cli/tests/cmd/llm/prompt-schema-invalid.toml
index a6e95258b..5c3807e20 100644
--- a/lib/crates/fabro-cli/tests/cmd/llm/prompt-schema-invalid.toml
+++ b/lib/crates/fabro-cli/tests/cmd/llm/prompt-schema-invalid.toml
@@ -2,3 +2,6 @@ bin.name = "fabro"
 args = ["llm", "prompt", "--no-stream", "-m", "test-model", "--schema", "not json", "hello"]
 status = "failed"
 stderr-to-stdout = true
+
+[env]
+inherit = false
diff --git a/lib/crates/fabro-cli/tests/cmd/run/dry-run-branching.toml b/lib/crates/fabro-cli/tests/cmd/run/dry-run-branching.toml
index d251a1daa..dc18a4f72 100644
--- a/lib/crates/fabro-cli/tests/cmd/run/dry-run-branching.toml
+++ b/lib/crates/fabro-cli/tests/cmd/run/dry-run-branching.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["run", "--dry-run", "--auto-approve", "../../../test/branching.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/run/dry-run-conditions.toml b/lib/crates/fabro-cli/tests/cmd/run/dry-run-conditions.toml
index 2a7994e25..be6796457 100644
--- a/lib/crates/fabro-cli/tests/cmd/run/dry-run-conditions.toml
+++ b/lib/crates/fabro-cli/tests/cmd/run/dry-run-conditions.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["run", "--dry-run", "--auto-approve", "../../../test/conditions.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/run/dry-run-legacy-tool.toml b/lib/crates/fabro-cli/tests/cmd/run/dry-run-legacy-tool.toml
index 9712fe83d..d8f0822ec 100644
--- a/lib/crates/fabro-cli/tests/cmd/run/dry-run-legacy-tool.toml
+++ b/lib/crates/fabro-cli/tests/cmd/run/dry-run-legacy-tool.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["run", "--dry-run", "--auto-approve", "../../../test/legacy_tool.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/run/dry-run-parallel.toml b/lib/crates/fabro-cli/tests/cmd/run/dry-run-parallel.toml
index a2a78502a..bb98ed609 100644
--- a/lib/crates/fabro-cli/tests/cmd/run/dry-run-parallel.toml
+++ b/lib/crates/fabro-cli/tests/cmd/run/dry-run-parallel.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["run", "--dry-run", "--auto-approve", "../../../test/parallel.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/run/dry-run-simple.toml b/lib/crates/fabro-cli/tests/cmd/run/dry-run-simple.toml
index 25601de4c..d304c33da 100644
--- a/lib/crates/fabro-cli/tests/cmd/run/dry-run-simple.toml
+++ b/lib/crates/fabro-cli/tests/cmd/run/dry-run-simple.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["run", "--dry-run", "--auto-approve", "../../../test/simple.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/run/dry-run-styled.toml b/lib/crates/fabro-cli/tests/cmd/run/dry-run-styled.toml
index 0e2e9c37f..c40ec2860 100644
--- a/lib/crates/fabro-cli/tests/cmd/run/dry-run-styled.toml
+++ b/lib/crates/fabro-cli/tests/cmd/run/dry-run-styled.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["run", "--dry-run", "--auto-approve", "../../../test/styled.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/top-level/no-dotenv-flag.toml b/lib/crates/fabro-cli/tests/cmd/top-level/no-dotenv-flag.toml
index ebc0fbbe5..b852d9b3f 100644
--- a/lib/crates/fabro-cli/tests/cmd/top-level/no-dotenv-flag.toml
+++ b/lib/crates/fabro-cli/tests/cmd/top-level/no-dotenv-flag.toml
@@ -2,3 +2,6 @@ bin.name = "fabro"
 args = ["--no-dotenv", "doctor"]
 status = "failed"
 stderr-to-stdout = true
+
+[env]
+inherit = false
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/branching.toml b/lib/crates/fabro-cli/tests/cmd/validate/branching.toml
index 4595e9da3..90ed3679c 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/branching.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/branching.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["validate", "../../../test/branching.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/conditions.toml b/lib/crates/fabro-cli/tests/cmd/validate/conditions.toml
index 61a1a7305..ca87ea280 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/conditions.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/conditions.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["validate", "../../../test/conditions.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/invalid.toml b/lib/crates/fabro-cli/tests/cmd/validate/invalid.toml
index 5d7789906..f2f9bce1f 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/invalid.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/invalid.toml
@@ -2,6 +2,9 @@ bin.name = "fabro"
 args = ["validate", "../../../test/invalid.fabro"]
 status = "failed"
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/legacy-tool.toml b/lib/crates/fabro-cli/tests/cmd/validate/legacy-tool.toml
index 2b3373f09..9b63836f2 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/legacy-tool.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/legacy-tool.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["validate", "../../../test/legacy_tool.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/parallel.toml b/lib/crates/fabro-cli/tests/cmd/validate/parallel.toml
index 371ce7f86..e27985d3e 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/parallel.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/parallel.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["validate", "../../../test/parallel.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/simple.toml b/lib/crates/fabro-cli/tests/cmd/validate/simple.toml
index 310fe6d0a..de446a3b7 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/simple.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/simple.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["validate", "../../../test/simple.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."
diff --git a/lib/crates/fabro-cli/tests/cmd/validate/styled.toml b/lib/crates/fabro-cli/tests/cmd/validate/styled.toml
index 36ef4f1f9..745bf7d6f 100644
--- a/lib/crates/fabro-cli/tests/cmd/validate/styled.toml
+++ b/lib/crates/fabro-cli/tests/cmd/validate/styled.toml
@@ -1,6 +1,9 @@
 bin.name = "fabro"
 args = ["validate", "../../../test/styled.fabro"]
 
+[env]
+inherit = false
+
 [fs]
 sandbox = false
 cwd = "../../.."