scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-05 08:10:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Consolidate duplicate test backends in prompt handler tests

Browse source 
Hoist OneShotCapturingBackend to module scope and remove two identical
CapturingBackend definitions that duplicated its functionality.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-07 23:01:15 -05:00
parent eb2ff9dd5c
commit 13ee1735c0
1 changed files with 42 additions and 118 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

160
crates/arc-workflows/src/handler/prompt.rs
View file

@ -251,50 +251,48 @@ mod tests {
assert_eq!(response_content, "one-shot response");
}
struct OneShotCapturingBackend {
captured_prompt: Arc<std::sync::Mutex<Option<String>>>,
captured_system_prompt: Arc<std::sync::Mutex<Option<Option<String>>>>,
}
#[async_trait]
impl CodergenBackend for OneShotCapturingBackend {
async fn run(
&self,
_node: &Node,
_prompt: &str,
_context: &Context,
_thread_id: Option<&str>,
_emitter: &Arc<crate::event::EventEmitter>,
_stage_dir: &Path,
_sandbox: &Arc<dyn arc_agent::Sandbox>,
) -> Result<CodergenResult, ArcError> {
panic!("run() should not be called for prompt handler");
}
async fn one_shot(
&self,
_node: &Node,
prompt: &str,
system_prompt: Option<&str>,
_stage_dir: &Path,
) -> Result<CodergenResult, ArcError> {
*self.captured_prompt.lock().unwrap() = Some(prompt.to_string());
*self.captured_system_prompt.lock().unwrap() =
Some(system_prompt.map(String::from));
Ok(CodergenResult::Text {
text: "classified".to_string(),
usage: None,
files_touched: Vec::new(),
})
}
}
#[tokio::test]
async fn prompt_handler_prepends_preamble() {
use std::sync::Mutex;
use arc_agent::Sandbox;
struct OneShotCapturingBackend {
captured_prompt: Arc<Mutex<Option<String>>>,
captured_system_prompt: Arc<Mutex<Option<Option<String>>>>,
}
#[async_trait]
impl CodergenBackend for OneShotCapturingBackend {
async fn run(
&self,
_node: &Node,
_prompt: &str,
_context: &Context,
_thread_id: Option<&str>,
_emitter: &Arc<crate::event::EventEmitter>,
_stage_dir: &Path,
_sandbox: &Arc<dyn Sandbox>,
) -> Result<CodergenResult, ArcError> {
panic!("run() should not be called for prompt handler");
}
async fn one_shot(
&self,
_node: &Node,
prompt: &str,
system_prompt: Option<&str>,
_stage_dir: &Path,
) -> Result<CodergenResult, ArcError> {
*self.captured_prompt.lock().unwrap() = Some(prompt.to_string());
*self.captured_system_prompt.lock().unwrap() =
Some(system_prompt.map(String::from));
Ok(CodergenResult::Text {
text: "classified".to_string(),
usage: None,
files_touched: Vec::new(),
})
}
}
let captured = Arc::new(Mutex::new(None));
let backend = OneShotCapturingBackend {
captured_prompt: captured.clone(),
@ -329,46 +327,9 @@ mod tests {
async fn prompt_handler_passes_system_prompt_when_project_memory_enabled() {
use std::sync::Mutex;
use arc_agent::Sandbox;
struct CapturingBackend {
captured_system_prompt: Arc<Mutex<Option<Option<String>>>>,
}
#[async_trait]
impl CodergenBackend for CapturingBackend {
async fn run(
&self,
_node: &Node,
_prompt: &str,
_context: &Context,
_thread_id: Option<&str>,
_emitter: &Arc<crate::event::EventEmitter>,
_stage_dir: &Path,
_sandbox: &Arc<dyn Sandbox>,
) -> Result<CodergenResult, ArcError> {
panic!("run() should not be called for prompt handler");
}
async fn one_shot(
&self,
_node: &Node,
_prompt: &str,
system_prompt: Option<&str>,
_stage_dir: &Path,
) -> Result<CodergenResult, ArcError> {
*self.captured_system_prompt.lock().unwrap() =
Some(system_prompt.map(String::from));
Ok(CodergenResult::Text {
text: "ok".to_string(),
usage: None,
files_touched: Vec::new(),
})
}
}
let captured_sys = Arc::new(Mutex::new(None));
let backend = CapturingBackend {
let backend = OneShotCapturingBackend {
captured_prompt: Arc::new(Mutex::new(None)),
captured_system_prompt: captured_sys.clone(),
};
let handler = PromptHandler::new(Some(Box::new(backend)));
@ -398,46 +359,9 @@ mod tests {
async fn prompt_handler_passes_none_system_prompt_when_project_memory_false() {
use std::sync::Mutex;
use arc_agent::Sandbox;
struct CapturingBackend {
captured_system_prompt: Arc<Mutex<Option<Option<String>>>>,
}
#[async_trait]
impl CodergenBackend for CapturingBackend {
async fn run(
&self,
_node: &Node,
_prompt: &str,
_context: &Context,
_thread_id: Option<&str>,
_emitter: &Arc<crate::event::EventEmitter>,
_stage_dir: &Path,
_sandbox: &Arc<dyn Sandbox>,
) -> Result<CodergenResult, ArcError> {
panic!("run() should not be called for prompt handler");
}
async fn one_shot(
&self,
_node: &Node,
_prompt: &str,
system_prompt: Option<&str>,
_stage_dir: &Path,
) -> Result<CodergenResult, ArcError> {
*self.captured_system_prompt.lock().unwrap() =
Some(system_prompt.map(String::from));
Ok(CodergenResult::Text {
text: "ok".to_string(),
usage: None,
files_touched: Vec::new(),
})
}
}
let captured_sys = Arc::new(Mutex::new(None));
let backend = CapturingBackend {
let backend = OneShotCapturingBackend {
captured_prompt: Arc::new(Mutex::new(None)),
captured_system_prompt: captured_sys.clone(),
};
let handler = PromptHandler::new(Some(Box::new(backend)));