mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-08 03:10:26 +00:00
parent
a93577acc0
commit
13edf62a10
5 changed files with 102 additions and 12 deletions
|
|
@ -1,29 +1,36 @@
|
|||
{
|
||||
"timestamp": "2026-03-16T05:32:37.329336Z",
|
||||
"current_node": "setup",
|
||||
"timestamp": "2026-03-16T05:36:26.336376Z",
|
||||
"current_node": "solve",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
"setup"
|
||||
"setup",
|
||||
"solve"
|
||||
],
|
||||
"node_retries": {
|
||||
"start": 1,
|
||||
"setup": 1
|
||||
"setup": 1,
|
||||
"solve": 1
|
||||
},
|
||||
"context_values": {
|
||||
"last_stage": "solve",
|
||||
"internal.node_visit_count": 1,
|
||||
"command.output": "fatal: destination path '.' already exists and is not an empty directory.\n",
|
||||
"internal.thread_id": "start",
|
||||
"internal.thread_id": "setup",
|
||||
"command.stderr": "",
|
||||
"current.preamble": "Goal: Add check to ensure max_length fits longest choice.\nDescription\n\t\nThere is currently no check to ensure that Field.max_length is large enough to fit the longest value in Field.choices.\nThis would be very helpful as often this mistake is not noticed until an attempt is made to save a record with those values that are too long.\n\n",
|
||||
"response.solve": "All tests pass. Here's a summary of the changes made:\n\n## Changes\n\n### `django/db/models/fields/__init__.py`\n\n1. **Added `_check_max_length_choices` call to `CharField.check()`** — Includes the new check in the CharField system checks pipeline.\n\n2. **Added `CharField._check_max_length_choices()` method** — A new system check that:\n - Only runs when both `max_length` and `choices` are set\n - Uses `self.flatchoices` to handle both flat choices and grouped choices\n - Filters to only string values (non-string choice values like integers don't have a length constraint)\n - Gracefully handles invalid choices (TypeError/ValueError) since those are already caught by `_check_choices()`\n - Returns `fields.E122` error when the longest choice value exceeds `max_length`\n\n### `tests/invalid_models_tests/test_ordinary_fields.py`\n\nAdded two test cases:\n- **`test_choices_longer_than_max_length`** — Verifies the error is raised for flat choices that exceed max_length\n- **`test_choices_in_groups_longer_than_max_length`** — Verifies the error is raised for grouped choices that exceed max_length",
|
||||
"current.preamble": "Goal: Add check to ensure max_length fits longest choice.\nDescription\n\t\nThere is currently no check to ensure that Field.max_length is large enough to fit the longest value in Field.choices.\nThis would be very helpful as often this mistake is not noticed until an attempt is made to save a record with those values that are too long.\n\n\n## Completed stages\n- **setup**: fail\n - Script: `git clone https://github.com/django/django.git . && git checkout fee75d2aed4e58ada6567c464cfd22e89dc65f4a && python -m pip install -e .`\n - Stdout:\n ```\n fatal: destination path '.' already exists and is not an empty directory.\n ```\n - Stderr: (empty)\n\n## Context\n- failure_class: deterministic\n- failure_signature: setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.\n",
|
||||
"graph.rankdir": "LR",
|
||||
"outcome": "fail",
|
||||
"current_node": "setup",
|
||||
"outcome": "success",
|
||||
"internal.retry_count.solve": 1,
|
||||
"current_node": "solve",
|
||||
"internal.run_id": "01KKTJ3AF4KC3M7YGJ5CRBC17X",
|
||||
"failure_signature": "setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.",
|
||||
"last_response": "All tests pass. Here's a summary of the changes made:\n\n## Changes\n\n### `django/db/models/fields/__init__.py`\n\n1. **Added `_check_max_length_choices` call to `CharField.check()`** — Includes the new ",
|
||||
"failure_signature": "",
|
||||
"internal.retry_count.setup": 1,
|
||||
"internal.retry_count.start": 1,
|
||||
"internal.fidelity": "compact",
|
||||
"failure_class": "deterministic",
|
||||
"thread.setup.current_node": "solve",
|
||||
"failure_class": "",
|
||||
"thread.start.current_node": "setup",
|
||||
"graph.goal": "Add check to ensure max_length fits longest choice.\nDescription\n\t\nThere is currently no check to ensure that Field.max_length is large enough to fit the longest value in Field.choices.\nThis would be very helpful as often this mistake is not noticed until an attempt is made to save a record with those values that are too long.\n"
|
||||
},
|
||||
|
|
@ -41,17 +48,41 @@
|
|||
},
|
||||
"duration_ms": 81
|
||||
},
|
||||
"solve": {
|
||||
"status": "success",
|
||||
"context_updates": {
|
||||
"last_stage": "solve",
|
||||
"response.solve": "All tests pass. Here's a summary of the changes made:\n\n## Changes\n\n### `django/db/models/fields/__init__.py`\n\n1. **Added `_check_max_length_choices` call to `CharField.check()`** — Includes the new check in the CharField system checks pipeline.\n\n2. **Added `CharField._check_max_length_choices()` method** — A new system check that:\n - Only runs when both `max_length` and `choices` are set\n - Uses `self.flatchoices` to handle both flat choices and grouped choices\n - Filters to only string values (non-string choice values like integers don't have a length constraint)\n - Gracefully handles invalid choices (TypeError/ValueError) since those are already caught by `_check_choices()`\n - Returns `fields.E122` error when the longest choice value exceeds `max_length`\n\n### `tests/invalid_models_tests/test_ordinary_fields.py`\n\nAdded two test cases:\n- **`test_choices_longer_than_max_length`** — Verifies the error is raised for flat choices that exceed max_length\n- **`test_choices_in_groups_longer_than_max_length`** — Verifies the error is raised for grouped choices that exceed max_length",
|
||||
"last_response": "All tests pass. Here's a summary of the changes made:\n\n## Changes\n\n### `django/db/models/fields/__init__.py`\n\n1. **Added `_check_max_length_choices` call to `CharField.check()`** — Includes the new "
|
||||
},
|
||||
"notes": "Stage completed: solve",
|
||||
"usage": {
|
||||
"model": "claude-opus-4-6",
|
||||
"input_tokens": 19943,
|
||||
"output_tokens": 7935,
|
||||
"cache_read_tokens": 638015,
|
||||
"cache_write_tokens": 24486,
|
||||
"reasoning_tokens": 60,
|
||||
"cost": 0.89427
|
||||
},
|
||||
"files_touched": [
|
||||
"/tmp/django_repo/django/db/models/fields/__init__.py",
|
||||
"/tmp/django_repo/tests/invalid_models_tests/test_ordinary_fields.py"
|
||||
],
|
||||
"duration_ms": 225842
|
||||
},
|
||||
"start": {
|
||||
"status": "success",
|
||||
"duration_ms": 0
|
||||
}
|
||||
},
|
||||
"next_node_id": "solve",
|
||||
"next_node_id": "extract_patch",
|
||||
"loop_failure_signatures": {
|
||||
"setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.": 1
|
||||
},
|
||||
"node_visits": {
|
||||
"start": 1,
|
||||
"setup": 1
|
||||
"setup": 1,
|
||||
"solve": 1
|
||||
}
|
||||
}
|
||||
28
nodes/solve/prompt.md
Normal file
28
nodes/solve/prompt.md
Normal file
|
|
@ -0,0 +1,28 @@
|
|||
Goal: Add check to ensure max_length fits longest choice.
|
||||
Description
|
||||
|
||||
There is currently no check to ensure that Field.max_length is large enough to fit the longest value in Field.choices.
|
||||
This would be very helpful as often this mistake is not noticed until an attempt is made to save a record with those values that are too long.
|
||||
|
||||
|
||||
## Completed stages
|
||||
- **setup**: fail
|
||||
- Script: `git clone https://github.com/django/django.git . && git checkout fee75d2aed4e58ada6567c464cfd22e89dc65f4a && python -m pip install -e .`
|
||||
- Stdout:
|
||||
```
|
||||
fatal: destination path '.' already exists and is not an empty directory.
|
||||
```
|
||||
- Stderr: (empty)
|
||||
|
||||
## Context
|
||||
- failure_class: deterministic
|
||||
- failure_signature: setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.
|
||||
|
||||
|
||||
Fix this GitHub issue in the repository. Make the minimal code change needed.
|
||||
|
||||
Add check to ensure max_length fits longest choice.
|
||||
Description
|
||||
|
||||
There is currently no check to ensure that Field.max_length is large enough to fit the longest value in Field.choices.
|
||||
This would be very helpful as often this mistake is not noticed until an attempt is made to save a record with those values that are too long.
|
||||
5
nodes/solve/provider_used.json
Normal file
5
nodes/solve/provider_used.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"mode": "agent",
|
||||
"provider": "anthropic",
|
||||
"model": "claude-opus-4-6"
|
||||
}
|
||||
20
nodes/solve/response.md
Normal file
20
nodes/solve/response.md
Normal file
|
|
@ -0,0 +1,20 @@
|
|||
All tests pass. Here's a summary of the changes made:
|
||||
|
||||
## Changes
|
||||
|
||||
### `django/db/models/fields/__init__.py`
|
||||
|
||||
1. **Added `_check_max_length_choices` call to `CharField.check()`** — Includes the new check in the CharField system checks pipeline.
|
||||
|
||||
2. **Added `CharField._check_max_length_choices()` method** — A new system check that:
|
||||
- Only runs when both `max_length` and `choices` are set
|
||||
- Uses `self.flatchoices` to handle both flat choices and grouped choices
|
||||
- Filters to only string values (non-string choice values like integers don't have a length constraint)
|
||||
- Gracefully handles invalid choices (TypeError/ValueError) since those are already caught by `_check_choices()`
|
||||
- Returns `fields.E122` error when the longest choice value exceeds `max_length`
|
||||
|
||||
### `tests/invalid_models_tests/test_ordinary_fields.py`
|
||||
|
||||
Added two test cases:
|
||||
- **`test_choices_longer_than_max_length`** — Verifies the error is raised for flat choices that exceed max_length
|
||||
- **`test_choices_in_groups_longer_than_max_length`** — Verifies the error is raised for grouped choices that exceed max_length
|
||||
6
nodes/solve/status.json
Normal file
6
nodes/solve/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"status": "success",
|
||||
"notes": "Stage completed: solve",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-03-16T05:36:26.336057+00:00"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue