scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-09 03:20:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(agent): shell-quote detached MCP launch commands

Browse source 
Quote each argv element and the wrapped sh -c payload so detached MCP
server startup cannot be broken by embedded quotes or shell metacharacters.
This commit is contained in:
Bryan Helmkamp 2026-04-21 09:12:26 -04:00
parent db01b9634b
commit 1176bf6d60
No known key found for this signature in database
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/crates/fabro-agent/src/session.rs
View file

@ -253,12 +253,19 @@ impl Session {
) -> Result<(String, std::collections::HashMap<String, String>), String> {
let sandbox = self.sandbox.as_ref();
let cmd_str = command.join(" ");
let cmd_str = command
.iter()
.map(|arg| fabro_sandbox::shell_quote(arg))
.collect::<Vec<_>>()
.join(" ");
// Launch the server detached with setsid so Daytona's exec doesn't block
// Launch the server detached with setsid so Daytona's exec doesn't block.
// shell_quote the inner command for the outer `sh -c` so a single quote
// or metacharacter in any argv element can't break out of the wrapper.
let inner = format!("{cmd_str} > /tmp/mcp_server_stdout.log 2>/tmp/mcp_server_stderr.log");
let launch_script = format!(
"setsid sh -c '{cmd_str} > /tmp/mcp_server_stdout.log 2>/tmp/mcp_server_stderr.log' \
</dev/null >/dev/null 2>&1 &\necho $!"
"setsid sh -c {quoted} </dev/null >/dev/null 2>&1 &\necho $!",
quoted = fabro_sandbox::shell_quote(&inner)
);
let env_ref = if env.is_empty() { None } else { Some(env) };
let launch_result = sandbox