From 0fca8a3625a99dd9711d5b125df6c53ed9db53c6 Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Mon, 4 May 2026 09:23:43 -0400 Subject: [PATCH] fix(workflows): refresh and check generated docs in verify gate PR #202 shipped a new CLI subcommand without regenerating docs/public/reference/cli.mdx, so the Generated Docs CI job failed on push. The implement-plan workflow's verify gate had no equivalent of `cargo dev docs check`. Append `cargo dev docs refresh && cargo dev docs check` to verify so the gate auto-fixes drift and surfaces real authoring errors (missing help text, removed generated-region fences) through the fixup loop. Also broaden the fixup prompt to cover docs errors. Co-Authored-By: Claude Opus 4.7 (1M context) --- .fabro/workflows/implement-plan/workflow.fabro | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.fabro/workflows/implement-plan/workflow.fabro b/.fabro/workflows/implement-plan/workflow.fabro index 29fa12bb0..f7dded31b 100644 --- a/.fabro/workflows/implement-plan/workflow.fabro +++ b/.fabro/workflows/implement-plan/workflow.fabro @@ -17,8 +17,8 @@ digraph ImplementPlan { implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD."] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-54)", prompt="@prompts/simplify.md", model="gpt-54"] - verify [label="Verify", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1", goal_gate=true, retry_target="fixup"] - fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all clippy lint warnings and test failures.", max_visits=3] + verify [label="Verify", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1 && cargo dev docs refresh 2>&1 && cargo dev docs check 2>&1", goal_gate=true, retry_target="fixup"] + fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all clippy lint warnings, test failures, and generated docs errors.", max_visits=3] fmt [label="Format", shape=parallelogram, script="cargo +nightly-2026-04-14 fmt --all 2>&1", max_retries=0] start -> toolchain