From 0719e321b16dc48576a4772bf770113812ff8725 Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Wed, 29 Apr 2026 11:48:22 -0400 Subject: [PATCH] chore(lint): satisfy workspace clippy --- lib/crates/fabro-cli/src/user_config.rs | 4 ++++ lib/crates/fabro-github/src/lib.rs | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/crates/fabro-cli/src/user_config.rs b/lib/crates/fabro-cli/src/user_config.rs index b6b373faf..bef197cae 100644 --- a/lib/crates/fabro-cli/src/user_config.rs +++ b/lib/crates/fabro-cli/src/user_config.rs @@ -300,6 +300,10 @@ pub(crate) fn configure_cli_target_if_missing( Ok(true) } +#[expect( + clippy::disallowed_methods, + reason = "CLI auth/login reads the user settings file synchronously before writing it." +)] fn read_settings_document_for_write(config_path: &Path) -> Result { if !config_path.exists() { return Ok(DocumentMut::new()); diff --git a/lib/crates/fabro-github/src/lib.rs b/lib/crates/fabro-github/src/lib.rs index 3f82f1009..e9f5aa196 100644 --- a/lib/crates/fabro-github/src/lib.rs +++ b/lib/crates/fabro-github/src/lib.rs @@ -432,9 +432,10 @@ pub async fn create_installation_access_token_with_permissions_and_install_url( match resp.status { 200 => {} 404 => { - let install_url = install_url.map(str::to_string).unwrap_or_else(|| { - format!("https://github.com/organizations/{owner}/settings/installations") - }); + let install_url = install_url.map_or_else( + || format!("https://github.com/organizations/{owner}/settings/installations"), + str::to_string, + ); return Err(format!( "GitHub App is not installed for {owner}. \ Install it at {install_url}"