From 02dba22b0cc7f0300a6b5346b8dedaad990f7559 Mon Sep 17 00:00:00 2001 From: Scott Werner Date: Mon, 21 Sep 2026 19:53:30 -0400 Subject: [PATCH] Explain expected release smoke-test exceptions --- test/bin/bundle_smoke.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/bin/bundle_smoke.py b/test/bin/bundle_smoke.py index 3ae19b62e..5b5cc4ad6 100644 --- a/test/bin/bundle_smoke.py +++ b/test/bin/bundle_smoke.py @@ -75,6 +75,7 @@ def workflow(fabro, root, expect_tampered=False, after_first_run=None): if response.status == 200: break except OSError: + # Startup connection failures are expected; retry until the deadline. pass if server.poll() is not None or time.monotonic() >= deadline: raise RuntimeError("server did not start:\n" + log_path.read_text()) @@ -100,6 +101,7 @@ def workflow(fabro, root, expect_tampered=False, after_first_run=None): try: os.killpg(server.pid, signal.SIGTERM) except ProcessLookupError: + # The server's process group may already have exited during teardown. pass try: server.wait(timeout=15)