claude-skills

mirror of https://github.com/alirezarezvani/claude-skills.git synced 2026-09-07 08:26:02 +00:00

History

Claude 81176406e3 fix(linkedin): stop a loose ask match from suppressing pitch-without-ask Sixth review round. One finding, reproduced first, plus a help-text nit. The connection branch was fixed earlier this PR to stop scanning a whole note with the loose ASK_RE, which raised a false premature-ask on "your post on on-call rotations". The else branch (dm / inmail / followup) had the same defect running the other way: there a loose match SUPPRESSES a real finding. pitch language, no ask, neutral text -> warning fires pitch language, no ask, "on-call rotations" -> warning silently lost pitch language, no ask, "chat feature" -> warning silently lost pitch language, no ask, "demo video" -> warning silently lost Any note containing one of ASK_RE's words anywhere lost its pitch-without-ask warning even with no ask in it. An ask is now the --ask field or meeting-request framing in the note - the same test the connection branch uses. That left ASK_RE referenced nowhere, so it is removed rather than kept as a dead pattern; its rationale moves into the comment on MEETING_ASK_RE, which now records both directions the defect ran in. Verified: the three suppressed cases now fire, and three controls stay quiet - a real ask in --ask, a meeting-shaped ask in the note, and a note with no pitch at all. Also: cadence_planner's argparse description did not mention NO_POSTS_AFFORDABLE, which shares exit 3 with over-budget. Help text only, no behaviour change. Not changed, deliberately: _read_input's duplication across 11 scripts (the self-contained-package convention's accepted cost), and the two different shapes of bare-list validation between pattern_miner and post_performance_analyzer - both are correct, and churning one to match the other adds diff without changing behaviour. Blocking gates green - compileall, check_paths, check_frontmatter, check_dual_publish, check_model_freshness, check_skill_names, check_plugin_json --all, derive_counters --check, smoke_scripts 696/696. Adversarial battery 18/18. Pinned samples unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BswsZp5zrJWFAGU6KWNA1s	2026-08-26 15:12:57 +00:00
..
landing	fix: resolve the actionable reported issues (#954 , #949 , #933 , #931 , #969 , #968 , #924 , #885 )	2026-08-21 05:47:37 +00:00
linkedin	fix(linkedin): stop a loose ask match from suppressing pitch-without-ask	2026-08-26 15:12:57 +00:00

fix(linkedin): stop a loose ask match from suppressing pitch-without-ask

Sixth review round. One finding, reproduced first, plus a help-text nit.

The connection branch was fixed earlier this PR to stop scanning a whole note with
the loose ASK_RE, which raised a false premature-ask on "your post on on-call
rotations". The else branch (dm / inmail / followup) had the same defect running
the other way: there a loose match SUPPRESSES a real finding.

    pitch language, no ask, neutral text        -> warning fires
    pitch language, no ask, "on-call rotations" -> warning silently lost
    pitch language, no ask, "chat feature"      -> warning silently lost
    pitch language, no ask, "demo video"        -> warning silently lost

Any note containing one of ASK_RE's words anywhere lost its pitch-without-ask
warning even with no ask in it. An ask is now the --ask field or meeting-request
framing in the note - the same test the connection branch uses.

That left ASK_RE referenced nowhere, so it is removed rather than kept as a dead
pattern; its rationale moves into the comment on MEETING_ASK_RE, which now records
both directions the defect ran in.

Verified: the three suppressed cases now fire, and three controls stay quiet - a
real ask in --ask, a meeting-shaped ask in the note, and a note with no pitch at
all.

Also: cadence_planner's argparse description did not mention NO_POSTS_AFFORDABLE,
which shares exit 3 with over-budget. Help text only, no behaviour change.

Not changed, deliberately: _read_input's duplication across 11 scripts (the
self-contained-package convention's accepted cost), and the two different
shapes of bare-list validation between pattern_miner and post_performance_analyzer
- both are correct, and churning one to match the other adds diff without
changing behaviour.

Blocking gates green - compileall, check_paths, check_frontmatter,
check_dual_publish, check_model_freshness, check_skill_names, check_plugin_json
--all, derive_counters --check, smoke_scripts 696/696. Adversarial battery 18/18.
Pinned samples unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BswsZp5zrJWFAGU6KWNA1s

2026-08-26 15:12:57 +00:00

landing

fix: resolve the actionable reported issues (#954 , #949 , #933 , #931 , #969 , #968 , #924 , #885 )

2026-08-21 05:47:37 +00:00

fix(linkedin): stop a loose ask match from suppressing pitch-without-ask

2026-08-26 15:12:57 +00:00