Commit graph

5 commits

Author SHA1 Message Date
Claude
3349509db4
fix(scripts,plugins): exclude tool-sync dirs from convert.sh; rename si plugin's status/review skills
- convert.sh's SKILL.md finder now excludes .claude, .codex, .codex-plugin,
  .gemini, .hermes, .vibe, and docs — these are generated/symlinked mirrors
  for other tools, not source-of-truth skills. On platforms where git
  materializes symlinks as plain text (e.g. Git Bash on Windows), the
  mirrored files were being parsed as SKILL.md candidates and failing
  frontmatter extraction, flooding the run with "Skipping invalid
  frontmatter" warnings (#897).

- Renamed the self-improving-agent (si) plugin's `status` and `review`
  skills to `memory-status` and `memory-review` so their bare `name:`
  values no longer collide with Claude Code's built-in `/status` and
  `/review` commands (#885). Updated all in-plugin references
  (CLAUDE.md, README, agents, hooks, references, settings.json,
  plugin.json) to the new `/si:memory-status` / `/si:memory-review`
  invocations.

Fixes #897 (duplicate of #896), #885.
2026-07-08 05:37:03 +00:00
Claude
b69842562a
fix(self-improving-agent): forbid reserved 'claude'/'anthropic' fragments in generated names
The /si:extract command and its skill-extractor agent had no guard
against the Claude Code skill-spec reserved name fragments. Users
reported the agent autogenerating skills like 'claude-code-settings',
'claude-mcp-tools', etc. — all of which violate the spec.

- Add explicit reserved-fragment rule to both the slash-command
  SKILL.md and the agent definition.
- Recommend the 'cc-' prefix for Claude Code-specific skills
  (cc-settings, cc-maintenance, cc-mcp-tools).
- Add the check to both quality-gate checklists so the agent
  surfaces a rename before writing files.

Closes #537
2026-05-11 13:14:39 +00:00
Sobro inc.
571b5921dd fix(agents): add maxTurns + skills + narrow tools per spec completeness
Karpathy-style review of commit 3806b9b (the prior PR commit) caught real
issues that I missed: agents weren't fully equipped per the optional but
recommended fields in the official sub-agents spec.

Changes:
- engineering/agenthub/agents/hub-coordinator.md: narrow Bash(node *) (too
  broad per defense-in-depth) -> moved node into disallowedTools; add
  maxTurns: 100 (orchestrators run long); add skills: agenthub:agenthub
  (preload the plugin's own guidance into agent context)
- engineering-team/self-improving-agent/agents/memory-analyst.md:
  add maxTurns: 30 to bound runaway analysis loops
- engineering-team/self-improving-agent/agents/skill-extractor.md:
  add disallowedTools (rm/curl/wget) — agent has Write+Edit so defense-in-
  depth applies; add maxTurns: 30
- engineering/karpathy-coder/agents/karpathy-reviewer.md: fix skills field
  format from path-style "engineering/karpathy-coder" to spec-correct
  namespaced name "karpathy-coder:karpathy-coder" (the path syntax is the
  cs-* orchestrator template convention; the official sub-agents spec uses
  skill names per code.claude.com/docs/en/sub-agents); add maxTurns: 30

All 6 plugin agents (4 here + 2 in playwright-pro from prior commit) +
the 1 user agent (tech-ingester) now have name + description + tools +
disallowedTools (where write-capable) + model + maxTurns. The skills:
field is set on agents that benefit from preloaded domain skill content.

Functional smoke tests post-fix:
- memory-analyst: PASS (2 turns, 25s, 24K tokens, found 1 real orphan)
- skill-extractor: PASS (0 tool uses, 34s, 17K tokens, generated correct
  plan staying read-only with new disallowedTools in effect)
- karpathy-reviewer: PASS (verified in prior session, 28 tool uses)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-04 23:05:34 -04:00
Sobro inc.
3806b9b723 fix(agents): add missing YAML frontmatter and modernize tool fields
Per https://code.claude.com/docs/en/sub-agents, agents require YAML
frontmatter with name + description, and the field is `tools:` not
`allowed-tools:` (deprecated). Bare `Bash` allows any command including
curl/wget/rm, which violates defense-in-depth.

Changes:
- engineering/agenthub/agents/hub-coordinator.md: add full frontmatter
  (name, description, tools allowlist for git/python/node/Agent,
  disallowedTools for rm -rf / curl / wget / git push --force, model)
- engineering-team/self-improving-agent/agents/memory-analyst.md:
  add frontmatter, read-only tools (Read, Glob, Grep)
- engineering-team/self-improving-agent/agents/skill-extractor.md:
  add frontmatter, write tools (Read, Write, Edit, Glob, Grep)
- engineering-team/playwright-pro/agents/test-architect.md:
  rename allowed-tools to tools, add model: inherit
- engineering-team/playwright-pro/agents/migration-planner.md:
  same rename
- engineering-team/playwright-pro/agents/test-debugger.md:
  rename + narrow bare Bash to npx playwright / node / npm patterns,
  add disallowedTools for rm / curl / wget / destructive git
- engineering/karpathy-coder/agents/karpathy-reviewer.md:
  narrow bare Bash to git read-ops + python, add disallowedTools

All registered agents now load cleanly under the sub-agents spec rather
than falling through to permissive registration.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-04 22:01:42 -04:00
Alireza Rezvani
50d37a5a5b
release: merge dev into main — self-improving-agent + playwright-pro (#263) 2026-03-05 18:23:26 +01:00