mirror of
https://github.com/RooVetGit/Roo-Code.git
synced 2026-09-22 00:31:46 +00:00
This change addresses issue #10991 where users can configure incorrect embedding dimensions, causing Qdrant to reject vector upserts with dimension mismatches. Changes: - Updated IEmbedder interface to include optional detectedDimension in validation result - All 8 embedders now return the detected dimension from their test embedding during validation - Updated CodeIndexServiceFactory.createVectorStore() to accept and prioritize auto-detected dimension over profile-based and manual configuration - Updated CodeIndexManager._recreateServices() to pass detected dimension from validation to vector store creation - Added comprehensive tests for the new functionality Priority order for dimension selection: 1. Auto-detected from test embedding (most reliable) 2. Profile-based from getModelDimension() 3. Manual configuration from modelDimension setting Fixes #10991
92 lines
3.4 KiB
TypeScript
92 lines
3.4 KiB
TypeScript
import { OpenAICompatibleEmbedder } from "./openai-compatible"
|
|
import { IEmbedder, EmbeddingResponse, EmbedderInfo } from "../interfaces/embedder"
|
|
import { MAX_ITEM_TOKENS } from "../constants"
|
|
import { t } from "../../../i18n"
|
|
import { TelemetryEventName } from "@roo-code/types"
|
|
import { TelemetryService } from "@roo-code/telemetry"
|
|
|
|
/**
|
|
* Mistral embedder implementation that wraps the OpenAI Compatible embedder
|
|
* with configuration for Mistral's embedding API.
|
|
*
|
|
* Supported models:
|
|
* - codestral-embed-2505 (dimension: 1536)
|
|
*/
|
|
export class MistralEmbedder implements IEmbedder {
|
|
private readonly openAICompatibleEmbedder: OpenAICompatibleEmbedder
|
|
private static readonly MISTRAL_BASE_URL = "https://api.mistral.ai/v1"
|
|
private static readonly DEFAULT_MODEL = "codestral-embed-2505"
|
|
private readonly modelId: string
|
|
|
|
/**
|
|
* Creates a new Mistral embedder
|
|
* @param apiKey The Mistral API key for authentication
|
|
* @param modelId The model ID to use (defaults to codestral-embed-2505)
|
|
*/
|
|
constructor(apiKey: string, modelId?: string) {
|
|
if (!apiKey) {
|
|
throw new Error(t("embeddings:validation.apiKeyRequired"))
|
|
}
|
|
|
|
// Use provided model or default
|
|
this.modelId = modelId || MistralEmbedder.DEFAULT_MODEL
|
|
|
|
// Create an OpenAI Compatible embedder with Mistral's configuration
|
|
this.openAICompatibleEmbedder = new OpenAICompatibleEmbedder(
|
|
MistralEmbedder.MISTRAL_BASE_URL,
|
|
apiKey,
|
|
this.modelId,
|
|
MAX_ITEM_TOKENS, // This is the max token limit (8191), not the embedding dimension
|
|
)
|
|
}
|
|
|
|
/**
|
|
* Creates embeddings for the given texts using Mistral's embedding API
|
|
* @param texts Array of text strings to embed
|
|
* @param model Optional model identifier (uses constructor model if not provided)
|
|
* @returns Promise resolving to embedding response
|
|
*/
|
|
async createEmbeddings(texts: string[], model?: string): Promise<EmbeddingResponse> {
|
|
try {
|
|
// Use the provided model or fall back to the instance's model
|
|
const modelToUse = model || this.modelId
|
|
return await this.openAICompatibleEmbedder.createEmbeddings(texts, modelToUse)
|
|
} catch (error) {
|
|
TelemetryService.instance.captureEvent(TelemetryEventName.CODE_INDEX_ERROR, {
|
|
error: error instanceof Error ? error.message : String(error),
|
|
stack: error instanceof Error ? error.stack : undefined,
|
|
location: "MistralEmbedder:createEmbeddings",
|
|
})
|
|
throw error
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Validates the Mistral embedder configuration by delegating to the underlying OpenAI-compatible embedder.
|
|
* Also detects the actual embedding dimension from a test embedding.
|
|
* @returns Promise resolving to validation result with success status, optional error message, and detected dimension
|
|
*/
|
|
async validateConfiguration(): Promise<{ valid: boolean; error?: string; detectedDimension?: number }> {
|
|
try {
|
|
// Delegate validation to the OpenAI-compatible embedder
|
|
// The error messages will be specific to Mistral since we're using Mistral's base URL
|
|
return await this.openAICompatibleEmbedder.validateConfiguration()
|
|
} catch (error) {
|
|
TelemetryService.instance.captureEvent(TelemetryEventName.CODE_INDEX_ERROR, {
|
|
error: error instanceof Error ? error.message : String(error),
|
|
stack: error instanceof Error ? error.stack : undefined,
|
|
location: "MistralEmbedder:validateConfiguration",
|
|
})
|
|
throw error
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Returns information about this embedder
|
|
*/
|
|
get embedderInfo(): EmbedderInfo {
|
|
return {
|
|
name: "mistral",
|
|
}
|
|
}
|
|
}
|