mirror of
https://github.com/RooVetGit/Roo-Code.git
synced 2026-09-22 00:31:46 +00:00
b598efb422
* feat: add per-task file-based history store for cross-instance safety
Implement TaskHistoryStore service that stores each task's HistoryItem
as an individual JSON file in its existing task directory. This prevents
silent data loss when multiple VS Code windows write to the shared
globalState taskHistory array concurrently.
Key changes:
- New TaskHistoryStore class with per-task file writes via safeWriteJson
- Index file (_index.json) for fast startup reads
- Reconciliation logic to detect and fix drift between instances
- fs.watch for cross-instance reactivity
- Debounced index writes (2s window) for streaming performance
- Migration from globalState on first startup
- Write-through to globalState during transition period
- Fallback lookups from globalState for backward compatibility
Files created:
- src/core/task-persistence/TaskHistoryStore.ts
- src/core/task-persistence/__tests__/TaskHistoryStore.spec.ts
- src/core/task-persistence/__tests__/TaskHistoryStore.crossInstance.spec.ts
Files modified:
- src/shared/globalFileNames.ts (added historyItem, historyIndex)
- src/core/task-persistence/index.ts (export TaskHistoryStore)
- src/core/webview/ClineProvider.ts (integrate store, remove write lock)
- Test files updated for new store-based approach
* fix: address review feedback - reconcile lock, init promise, write-through serialization
- reconcile() now runs through withLock() to prevent interleaving with
upsert/delete at async boundaries
- Added initialized promise so callers can await store readiness before
reading (getStateToPostToWebview now awaits it)
- Write-through to globalState now happens inside the store lock via
onWrite callback, preventing concurrent call races on the transition
period fallback
- Removed separate updateGlobalState("taskHistory") calls from
ClineProvider since the onWrite callback handles it serialized
* fix: add TaskHistoryStore to task-persistence mock in Task.persistence.spec.ts
The test mocks task-persistence with an explicit factory that was
missing the new TaskHistoryStore export, causing all 9 tests to fail
with "No TaskHistoryStore export is defined on the mock".
* perf: debounce globalState write-through to avoid full-array writes on every mutation
Instead of writing the entire HistoryItem[] array to globalState on
every upsert/delete (expensive with 5000+ tasks), the write-through
is now debounced with a 5-second window. Per-task file writes remain
immediate (~200 bytes each). The globalState is flushed on dispose
to ensure no data loss on shutdown.
This makes the hot path during streaming (token count updates) write
only the per-task file, not the full array.
---------
Co-authored-by: Roo Code <roomote@roocode.com>
9 lines
298 B
TypeScript
9 lines
298 B
TypeScript
export const GlobalFileNames = {
|
|
apiConversationHistory: "api_conversation_history.json",
|
|
uiMessages: "ui_messages.json",
|
|
mcpSettings: "mcp_settings.json",
|
|
customModes: "custom_modes.yaml",
|
|
taskMetadata: "task_metadata.json",
|
|
historyItem: "history_item.json",
|
|
historyIndex: "_index.json",
|
|
}
|