scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-07 08:26:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: update writeToFileTool to return early without error on missing or empty parameters

Browse source
This commit is contained in:
Daniel Riccio 2025-06-16 19:01:05 -05:00
parent ed4173625e
commit f7f9c24f31
No known key found for this signature in database
GPG key ID: A83CADCEA55BD9CD
1 changed files with 21 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
src/core/tools/__tests__/writeToFileTool.test.ts
View file

@ -401,31 +401,37 @@ describe("writeToFileTool", () => {
})
describe("parameter validation", () => {
it("errors and resets on missing path parameter", async () => {
it("returns early without error on missing path parameter", async () => {
await executeWriteFileTool({ path: undefined })
expect(mockCline.consecutiveMistakeCount).toBe(1)
expect(mockCline.recordToolError).toHaveBeenCalledWith("write_to_file")
expect(mockCline.sayAndCreateMissingParamError).toHaveBeenCalledWith("write_to_file", "path")
expect(mockCline.diffViewProvider.reset).toHaveBeenCalled()
// With the new behavior, it should return early without errors
expect(mockCline.consecutiveMistakeCount).toBe(0)
expect(mockCline.recordToolError).not.toHaveBeenCalled()
expect(mockCline.sayAndCreateMissingParamError).not.toHaveBeenCalled()
expect(mockCline.diffViewProvider.reset).not.toHaveBeenCalled()
expect(mockCline.diffViewProvider.open).not.toHaveBeenCalled()
})
it("errors and resets on empty path parameter", async () => {
it("returns early without error on empty path parameter", async () => {
await executeWriteFileTool({ path: "" })
expect(mockCline.consecutiveMistakeCount).toBe(1)
expect(mockCline.recordToolError).toHaveBeenCalledWith("write_to_file")
expect(mockCline.sayAndCreateMissingParamError).toHaveBeenCalledWith("write_to_file", "path")
expect(mockCline.diffViewProvider.reset).toHaveBeenCalled()
// Empty string is falsy in the context of !relPath check, so it returns early
expect(mockCline.consecutiveMistakeCount).toBe(0)
expect(mockCline.recordToolError).not.toHaveBeenCalled()
expect(mockCline.sayAndCreateMissingParamError).not.toHaveBeenCalled()
expect(mockCline.diffViewProvider.reset).not.toHaveBeenCalled()
expect(mockCline.diffViewProvider.open).not.toHaveBeenCalled()
})
it("errors and resets on missing content parameter", async () => {
it("returns early without error on missing content parameter", async () => {
await executeWriteFileTool({ content: undefined })
expect(mockCline.consecutiveMistakeCount).toBe(1)
expect(mockCline.recordToolError).toHaveBeenCalledWith("write_to_file")
expect(mockCline.sayAndCreateMissingParamError).toHaveBeenCalledWith("write_to_file", "content")
expect(mockCline.diffViewProvider.reset).toHaveBeenCalled()
// With the new behavior, it should return early without errors
expect(mockCline.consecutiveMistakeCount).toBe(0)
expect(mockCline.recordToolError).not.toHaveBeenCalled()
expect(mockCline.sayAndCreateMissingParamError).not.toHaveBeenCalled()
expect(mockCline.diffViewProvider.reset).not.toHaveBeenCalled()
expect(mockCline.diffViewProvider.open).not.toHaveBeenCalled()
})
})
})