scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-08-28 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert fix: resolve LM Studio context length detection (#5075) (#5083)

Browse source
This commit is contained in:
Daniel 2025-06-24 14:56:22 -05:00 • committed by GitHub
parent e7ca038cb5
commit f666cb334f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 103 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

85
src/api/providers/__tests__/lmstudio.spec.ts
View file

@ -58,38 +58,15 @@ vi.mock("openai", () => {
}
})
// Mock LM Studio fetcher
vi.mock("../fetchers/lmstudio", () => ({
getLMStudioModels: vi.fn(),
}))
import type { Anthropic } from "@anthropic-ai/sdk"
import type { ModelInfo } from "@roo-code/types"
import { LmStudioHandler } from "../lm-studio"
import type { ApiHandlerOptions } from "../../../shared/api"
import { getLMStudioModels } from "../fetchers/lmstudio"
// Get the mocked function
const mockGetLMStudioModels = vi.mocked(getLMStudioModels)
describe("LmStudioHandler", () => {
let handler: LmStudioHandler
let mockOptions: ApiHandlerOptions
const mockModelInfo: ModelInfo = {
maxTokens: 8192,
contextWindow: 32768,
supportsImages: false,
supportsComputerUse: false,
supportsPromptCache: true,
inputPrice: 0,
outputPrice: 0,
cacheWritesPrice: 0,
cacheReadsPrice: 0,
description: "Test Model - local-model",
}
beforeEach(() => {
mockOptions = {
apiModelId: "local-model",
@ -98,7 +75,6 @@ describe("LmStudioHandler", () => {
}
handler = new LmStudioHandler(mockOptions)
mockCreate.mockClear()
mockGetLMStudioModels.mockClear()
})
describe("constructor", () => {
@ -180,71 +156,12 @@ describe("LmStudioHandler", () => {
})
describe("getModel", () => {
it("should return default model info when no models fetched", () => {
it("should return model info", () => {
const modelInfo = handler.getModel()
expect(modelInfo.id).toBe(mockOptions.lmStudioModelId)
expect(modelInfo.info).toBeDefined()
expect(modelInfo.info.maxTokens).toBe(-1)
expect(modelInfo.info.contextWindow).toBe(128_000)
})
it("should return fetched model info when available", async () => {
// Mock the fetched models
mockGetLMStudioModels.mockResolvedValueOnce({
"local-model": mockModelInfo,
})
await handler.fetchModel()
const modelInfo = handler.getModel()
expect(modelInfo.id).toBe(mockOptions.lmStudioModelId)
expect(modelInfo.info).toEqual(mockModelInfo)
expect(modelInfo.info.contextWindow).toBe(32768)
})
it("should fallback to default when model not found in fetched models", async () => {
// Mock fetched models without our target model
mockGetLMStudioModels.mockResolvedValueOnce({
"other-model": mockModelInfo,
})
await handler.fetchModel()
const modelInfo = handler.getModel()
expect(modelInfo.id).toBe(mockOptions.lmStudioModelId)
expect(modelInfo.info.maxTokens).toBe(-1)
expect(modelInfo.info.contextWindow).toBe(128_000)
})
})
describe("fetchModel", () => {
it("should fetch models successfully", async () => {
mockGetLMStudioModels.mockResolvedValueOnce({
"local-model": mockModelInfo,
})
const result = await handler.fetchModel()
expect(mockGetLMStudioModels).toHaveBeenCalledWith(mockOptions.lmStudioBaseUrl)
expect(result.id).toBe(mockOptions.lmStudioModelId)
expect(result.info).toEqual(mockModelInfo)
})
it("should handle fetch errors gracefully", async () => {
const consoleSpy = vi.spyOn(console, "warn").mockImplementation(() => {})
mockGetLMStudioModels.mockRejectedValueOnce(new Error("Connection failed"))
const result = await handler.fetchModel()
expect(consoleSpy).toHaveBeenCalledWith(
"Failed to fetch LM Studio models, using defaults:",
expect.any(Error),
)
expect(result.id).toBe(mockOptions.lmStudioModelId)
expect(result.info.maxTokens).toBe(-1)
expect(result.info.contextWindow).toBe(128_000)
consoleSpy.mockRestore()
})
})
})

21
src/api/providers/lm-studio.ts
View file

@ -13,12 +13,10 @@ import { ApiStream } from "../transform/stream"
import { BaseProvider } from "./base-provider"
import type { SingleCompletionHandler, ApiHandlerCreateMessageMetadata } from "../index"
import { getLMStudioModels } from "./fetchers/lmstudio"
export class LmStudioHandler extends BaseProvider implements SingleCompletionHandler {
protected options: ApiHandlerOptions
private client: OpenAI
private models: Record<string, ModelInfo> = {}
constructor(options: ApiHandlerOptions) {
super()
@ -132,25 +130,10 @@ export class LmStudioHandler extends BaseProvider implements SingleCompletionHan
}
}
public async fetchModel() {
try {
this.models = await getLMStudioModels(this.options.lmStudioBaseUrl)
} catch (error) {
console.warn("Failed to fetch LM Studio models, using defaults:", error)
this.models = {}
}
return this.getModel()
}
override getModel(): { id: string; info: ModelInfo } {
const id = this.options.lmStudioModelId || ""
// Try to get the actual model info from fetched models
const info = this.models[id] || openAiModelInfoSaneDefaults
return {
id,
info,
id: this.options.lmStudioModelId || "",
info: openAiModelInfoSaneDefaults,
}
}