scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-10-09 03:17:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: prevent TypeError in TTS useEffect by capturing text in local variable

Browse source 
Fixes #10468

The error "Q.text.startsWith is not a function" occurred because
lastMessage.text could potentially change between the type check
(typeof lastMessage.text === "string") and the startsWith call.

This fix captures lastMessage.text in a local variable before
performing any operations on it, preventing the TOCTOU
(time-of-check-time-of-use) vulnerability.
This commit is contained in:
Roo Code 2026-01-08 01:54:39 +00:00
parent ca0c9010d5
commit f4eb1e1ed3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
webview-ui/src/components/chat/ChatView.tsx
View file

@ -1015,13 +1015,16 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
// This ensures the first message is not read, future user messages are
// labeled as `user_feedback`.
if (lastMessage && messages.length > 1) {
// Capture text in a local variable to prevent TOCTOU (time-of-check-time-of-use) issues
// where lastMessage.text could change between the type check and startsWith call
const messageText = lastMessage.text
if (
typeof lastMessage.text === "string" && // has text (must be string for startsWith)
typeof messageText === "string" && // has text (must be string for startsWith)
(lastMessage.say === "text" || lastMessage.say === "completion_result") && // is a text message
!lastMessage.partial && // not a partial message
!lastMessage.text.startsWith("{") // not a json object
!messageText.startsWith("{") // not a json object
) {
let text = lastMessage?.text || ""
let text = messageText || ""
const mermaidRegex = /```mermaid[\s\S]*?```/g
// remove mermaid diagrams from text
text = text.replace(mermaidRegex, "")