scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-09 22:31:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix bug with clearing custom instructions

Browse source
This commit is contained in:
Matt Rubens 2025-01-14 16:01:59 -05:00
parent 4493b55276
commit f2d25dd5a5
3 changed files with 35 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/kind-nails-jog.md Normal file
View file

@ -0,0 +1,5 @@
---
"roo-cline": patch
---
Fix bug with clearing custom instructions

4
webview-ui/src/components/prompts/PromptsView.tsx
View file

@ -21,7 +21,8 @@ const PromptsView = ({ onDone }: PromptsViewProps) => {
enhancementApiConfigId,
setEnhancementApiConfigId,
mode,
customInstructions
customInstructions,
setCustomInstructions
} = useExtensionState()
const [testPrompt, setTestPrompt] = useState('')
const [isEnhancing, setIsEnhancing] = useState(false)
@ -152,6 +153,7 @@ const PromptsView = ({ onDone }: PromptsViewProps) => {
value={customInstructions ?? ''}
onChange={(e) => {
const value = (e as CustomEvent)?.detail?.target?.value || ((e as any).target as HTMLTextAreaElement).value
setCustomInstructions(value || undefined)
vscode.postMessage({
type: "customInstructions",
text: value.trim() || undefined

28
webview-ui/src/components/prompts/__tests__/PromptsView.test.tsx
View file

@ -19,7 +19,9 @@ const mockExtensionState = {
],
enhancementApiConfigId: '',
setEnhancementApiConfigId: jest.fn(),
mode: 'code'
mode: 'code',
customInstructions: 'Initial instructions',
setCustomInstructions: jest.fn()
}
const renderPromptsView = (props = {}) => {
@ -131,4 +133,28 @@ describe('PromptsView', () => {
text: 'config1'
})
})
it('handles clearing custom instructions correctly', async () => {
const setCustomInstructions = jest.fn()
renderPromptsView({
...mockExtensionState,
customInstructions: 'Initial instructions',
setCustomInstructions
})
const textarea = screen.getByTestId('global-custom-instructions-textarea')
const changeEvent = new CustomEvent('change', {
detail: { target: { value: '' } }
})
Object.defineProperty(changeEvent, 'target', {
value: { value: '' }
})
await fireEvent(textarea, changeEvent)
expect(setCustomInstructions).toHaveBeenCalledWith(undefined)
expect(vscode.postMessage).toHaveBeenCalledWith({
type: 'customInstructions',
text: undefined
})
})
})