From f10bbef3333bc173720c3ef4ea6a4b2d2455d333 Mon Sep 17 00:00:00 2001 From: Roo Code Date: Mon, 15 Sep 2025 12:51:24 +0000 Subject: [PATCH] fix: address PR review feedback - Change isLoading default to false in DismissedUpsellsContext to prevent flash of upsells - Fix import path inconsistency in ChatView.tsx (use @src/ instead of @/) --- webview-ui/src/components/chat/ChatView.tsx | 2 +- webview-ui/src/context/DismissedUpsellsContext.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/webview-ui/src/components/chat/ChatView.tsx b/webview-ui/src/components/chat/ChatView.tsx index c647750516..d6d22f3b53 100644 --- a/webview-ui/src/components/chat/ChatView.tsx +++ b/webview-ui/src/components/chat/ChatView.tsx @@ -59,7 +59,7 @@ import { Cloud } from "lucide-react" import { CloudUpsellDialog } from "@src/components/cloud/CloudUpsellDialog" import DismissibleUpsell from "../common/DismissibleUpsell" import { useCloudUpsell } from "@src/hooks/useCloudUpsell" -import { useUpsellVisibility, UPSELL_IDS } from "@/hooks/useUpsellVisibility" +import { useUpsellVisibility, UPSELL_IDS } from "@src/hooks/useUpsellVisibility" export interface ChatViewProps { isHidden: boolean diff --git a/webview-ui/src/context/DismissedUpsellsContext.tsx b/webview-ui/src/context/DismissedUpsellsContext.tsx index 51802bc6a8..4924bc31a7 100644 --- a/webview-ui/src/context/DismissedUpsellsContext.tsx +++ b/webview-ui/src/context/DismissedUpsellsContext.tsx @@ -23,7 +23,7 @@ interface DismissedUpsellsProviderProps { export const DismissedUpsellsProvider: React.FC = ({ children }) => { const [dismissedUpsells, setDismissedUpsells] = useState([]) - const [isLoading, setIsLoading] = useState(true) + const [isLoading, setIsLoading] = useState(false) // Request dismissed upsells from extension const refreshDismissedUpsells = useCallback(() => {