From e4b051bb71f602a3b869d21048c12b44c00acd20 Mon Sep 17 00:00:00 2001
From: SannidhyaSah <sah_sannidhya@outlook.com>
Date: Thu, 3 Jul 2025 09:29:51 +0530
Subject: [PATCH] fix: prevent completion sound from replaying when reopening
 completed tasks (#4885) (#5249)

---
 webview-ui/src/components/chat/ChatView.tsx   |  6 ----
 .../chat/__tests__/ChatView.spec.tsx          | 32 +++++++++++++++++++
 2 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/webview-ui/src/components/chat/ChatView.tsx b/webview-ui/src/components/chat/ChatView.tsx
index 874f0de3c2..a3533a5917 100644
--- a/webview-ui/src/components/chat/ChatView.tsx
+++ b/webview-ui/src/components/chat/ChatView.tsx
@@ -348,9 +348,6 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 							setSecondaryButtonText(undefined)
 							break
 						case "resume_task":
-							if (!isAutoApproved(lastMessage) && !isPartial) {
-								playSound("notification")
-							}
 							setSendingDisabled(false)
 							setClineAsk("resume_task")
 							setEnableButtons(true)
@@ -359,9 +356,6 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
 							setDidClickCancel(false) // special case where we reset the cancel button state
 							break
 						case "resume_completed_task":
-							if (!isPartial) {
-								playSound("celebration")
-							}
 							setSendingDisabled(false)
 							setClineAsk("resume_completed_task")
 							setEnableButtons(true)
diff --git a/webview-ui/src/components/chat/__tests__/ChatView.spec.tsx b/webview-ui/src/components/chat/__tests__/ChatView.spec.tsx
index 0343cb6c96..ba758fbe3b 100644
--- a/webview-ui/src/components/chat/__tests__/ChatView.spec.tsx
+++ b/webview-ui/src/components/chat/__tests__/ChatView.spec.tsx
@@ -1020,6 +1020,38 @@ describe("ChatView - Sound Playing Tests", () => {
 			expect(mockPlayFunction).toHaveBeenCalled()
 		})
 	})
+
+	it("does not play sound when resuming a task from history", async () => {
+		renderChatView()
+		mockPlayFunction.mockClear()
+
+		// Send resume_task message
+		mockPostMessage({
+			clineMessages: [
+				{ type: "say", say: "task", ts: Date.now() - 2000, text: "Initial task" },
+				{ type: "ask", ask: "resume_task", ts: Date.now(), text: "Resume task", partial: false },
+			],
+		})
+
+		await new Promise((resolve) => setTimeout(resolve, 100))
+		expect(mockPlayFunction).not.toHaveBeenCalled()
+	})
+
+	it("does not play sound when resuming a completed task from history", async () => {
+		renderChatView()
+		mockPlayFunction.mockClear()
+
+		// Send resume_completed_task message
+		mockPostMessage({
+			clineMessages: [
+				{ type: "say", say: "task", ts: Date.now() - 2000, text: "Initial task" },
+				{ type: "ask", ask: "resume_completed_task", ts: Date.now(), text: "Resume completed", partial: false },
+			],
+		})
+
+		await new Promise((resolve) => setTimeout(resolve, 100))
+		expect(mockPlayFunction).not.toHaveBeenCalled()
+	})
 })
 
 describe("ChatView - Focus Grabbing Tests", () => {