fix: Small type and code styling issues

This commit is contained in:
Toray Altas 2025-12-28 20:37:46 -05:00
parent 5084d35cce
commit e06c5fadcf
2 changed files with 19 additions and 10 deletions

View file

@ -1543,6 +1543,13 @@ describe("CodeIndexConfigManager", () => {
})
describe("loadConfiguration", () => {
beforeEach(() => {
// Set default mock behaviors
mockedGetDefaultModelId.mockReturnValue("text-embedding-3-small")
mockedGetModelDimension.mockReturnValue(undefined)
mockedGetModelScoreThreshold.mockReturnValue(undefined)
})
it("should persist and load OpenRouter embedder base URL correctly", async () => {
const mockGlobalState = {
codebaseIndexEnabled: true,
@ -1654,12 +1661,6 @@ describe("CodeIndexConfigManager", () => {
const result = await configManager.loadConfiguration()
expect(result.requiresRestart).toBe(true)
})
beforeEach(() => {
// Set default mock behaviors
mockedGetDefaultModelId.mockReturnValue("text-embedding-3-small")
mockedGetModelDimension.mockReturnValue(undefined)
mockedGetModelScoreThreshold.mockReturnValue(undefined)
})
it("should load configuration and return proper structure", async () => {
const mockConfigValues = {

View file

@ -155,6 +155,7 @@ describe("CodeIndexOrchestrator - error path cleanup gating", () => {
openRouterBaseUrl: testBaseUrl,
},
}),
// Use a valid EmbedderProvider value
}
const { CodeIndexServiceFactory } = await import("../service-factory")
@ -196,12 +197,13 @@ describe("CodeIndexOrchestrator - error path cleanup gating", () => {
const prev = {
enabled: true,
configured: true,
embedderProvider: "openrouter",
embedderProvider: "openrouter" as import("../interfaces/manager").EmbedderProvider,
openRouterApiKey: "test-api-key",
openRouterBaseUrl: "https://old.openrouter.ai/api/v1",
}
const configManagerModule = await import("../config-manager")
const mgr = new configManagerModule.CodeIndexConfigManager({
// Provide a full ContextProxy mock with required properties/methods
const mockContextProxy = {
getGlobalState: vi.fn().mockReturnValue({
codebaseIndexEnabled: true,
codebaseIndexEmbedderProvider: "openrouter",
@ -209,8 +211,14 @@ describe("CodeIndexOrchestrator - error path cleanup gating", () => {
}),
getSecret: vi.fn().mockReturnValue("test-api-key"),
refreshSecrets: vi.fn(),
})
mgr._loadAndSetConfiguration()
setValue: vi.fn(),
setValues: vi.fn(),
getValue: vi.fn(),
getProviderSettings: vi.fn().mockReturnValue({}),
setProviderSettings: vi.fn(),
}
const mgr = new configManagerModule.CodeIndexConfigManager(mockContextProxy)
await mgr.loadConfiguration()
const requiresRestart = mgr.doesConfigChangeRequireRestart(prev)
expect(requiresRestart).toBe(true)
})