From e062feba73050cad0d82e11cf90b8f06a1f68f98 Mon Sep 17 00:00:00 2001
From: John Richmond <5629+jr@users.noreply.github.com>
Date: Tue, 13 May 2025 14:46:33 -0700
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
---
 src/app/(authenticated)/extension/sign-in/route.ts | 2 +-
 src/lib/server/clerk.ts                            | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/app/(authenticated)/extension/sign-in/route.ts b/src/app/(authenticated)/extension/sign-in/route.ts
index bf5a2565f1..99f59233d9 100644
--- a/src/app/(authenticated)/extension/sign-in/route.ts
+++ b/src/app/(authenticated)/extension/sign-in/route.ts
@@ -10,7 +10,7 @@ export async function GET(request: NextRequest) {
   const state = request.nextUrl.searchParams.get('state') || '';
 
   if (!userId) {
-    throw new Error('not logged in?');
+    return new Response('Unauthorized', { status: 401 });
   }
 
   const signInToken = await getSignInToken(authObj.userId);
diff --git a/src/lib/server/clerk.ts b/src/lib/server/clerk.ts
index fe2b3049a7..57ef19797f 100644
--- a/src/lib/server/clerk.ts
+++ b/src/lib/server/clerk.ts
@@ -24,7 +24,7 @@ export async function getSignInToken(
       userId,
     });
 
-    return undefined; // probably just throw
+    throw new Error("Failed to create sign-in token");
   }
 
   const data = await response.json();
@@ -32,7 +32,6 @@ export async function getSignInToken(
   logger.info({
     event: 'sign_in_token_created',
     userId,
-    data, // TODO: none of this, probably
   });
 
   return data.token;