diff --git a/command_whitelist_ui_location_summary.md b/command_whitelist_ui_location_summary.md deleted file mode 100644 index ade4fdabb4..0000000000 --- a/command_whitelist_ui_location_summary.md +++ /dev/null @@ -1,67 +0,0 @@ -# Command Whitelisting UI Location Summary - -## Overview - -The command whitelisting feature has been successfully moved from VS Code's native settings to the Roo Code plugin's settings interface. This consolidates all auto-approval settings in one convenient location. - -## Previous Location (REMOVED) - -- **VS Code Settings**: `Preferences > Settings > Extensions > Roo Code` -- **Setting Name**: `roo-code.commandWhitelist` -- **Access**: Required navigating through VS Code's settings UI or editing `settings.json` - -## New Location (CURRENT) - -The command whitelisting feature is now located in: - -### Access Path - -1. Open the Roo Code extension panel in VS Code -2. Click on the **Settings** icon (gear icon) in the top toolbar -3. Navigate to the **Auto Approve** section -4. Find the **Execute** subsection - -### UI Components - -Within the Auto Approve > Execute section, you'll find: - -1. **Enable/Disable Toggle** - - - Label: "Auto-approve command execution" - - Controls whether commands can be auto-approved - -2. **Command Patterns List** - - Label: "Command patterns" - - Description: "Add command patterns that can be auto-approved (e.g., 'npm test', 'git status')" - - Features: - - Add new patterns using the input field - - Remove patterns with the × button - - Patterns support wildcards (\*) - - Empty list means no commands are auto-approved - -### Example Patterns - -- `npm test` - Auto-approves exact command -- `npm *` - Auto-approves any npm command -- `git status` - Auto-approves git status command -- `*` - Auto-approves all commands (use with caution) - -## Migration - -- Existing command whitelist settings from VS Code settings are automatically migrated to the new location on first launch -- The old VS Code setting (`roo-code.commandWhitelist`) is removed from `package.json` -- Users don't need to manually transfer their settings - -## Benefits - -1. **Centralized Settings**: All auto-approval settings (read, write, execute) are now in one place -2. **Better UX**: No need to navigate VS Code's complex settings structure -3. **Visual Consistency**: Matches the UI pattern of other auto-approve settings -4. **Easier Discovery**: Users can find all related settings together - -## Technical Details - -- Setting is stored in the global state using key: `commandWhitelist` -- Synchronized across VS Code instances -- Supports the same pattern matching as before -- Maintains backward compatibility through automatic migration diff --git a/pr_fix_implementation_summary.md b/pr_fix_implementation_summary.md deleted file mode 100644 index 78f4b0ec77..0000000000 --- a/pr_fix_implementation_summary.md +++ /dev/null @@ -1,77 +0,0 @@ -# PR #5491 Fix Implementation Summary - -## Overview - -Implemented a feature flag to disable LLM-based command suggestions in response to reviewer feedback about avoiding reliance on LLMs for command whitelist suggestions. - -## Changes Made - -### 1. Configuration Setting Added - -- **File**: `src/package.json` -- Added new setting: `roo-cline.disableLlmCommandSuggestions` -- Type: boolean, default: false -- Description: "Disable LLM-generated command suggestions and use only programmatic pattern generation" - -### 2. Localization - -- **File**: `src/package.nls.json` -- Added description for the new setting - -### 3. Tool Prompt Conditional Logic - -- **File**: `src/core/prompts/tools/execute-command.ts` -- Modified `getExecuteCommandDescription` to conditionally include suggestions section -- When `disableLlmCommandSuggestions` is true, the suggestions parameter is omitted from the tool description - -### 4. Tool Implementation Update - -- **File**: `src/core/tools/executeCommandTool.ts` -- Added check for `disableLlmCommandSuggestions` setting -- When enabled, suggestions from LLM are ignored even if provided - -### 5. Settings Propagation - -- **File**: `src/core/task/Task.ts` -- Updated to pass the `disableLlmCommandSuggestions` setting through the system prompt generation - -### 6. Test Coverage - -- **File**: `src/core/tools/__tests__/executeCommandTool.spec.ts` -- Added comprehensive test suite for the new setting -- Tests verify suggestions are ignored when setting is enabled -- Tests verify suggestions work normally when setting is disabled or not set - -- **File**: `src/core/prompts/tools/__tests__/execute-command.spec.ts` -- Added tests for conditional prompt generation -- Verifies suggestions section is excluded when setting is enabled - -## How It Works - -1. **When `disableLlmCommandSuggestions` is false (default)**: - - - LLM receives instructions to provide command suggestions - - Tool processes suggestions and shows them to the user - - Existing behavior is preserved - -2. **When `disableLlmCommandSuggestions` is true**: - - LLM does not receive instructions about suggestions - - Even if LLM provides suggestions, they are ignored - - Falls back to programmatic pattern generation only - -## Benefits - -1. **Addresses Reviewer Concern**: Removes reliance on LLM for command suggestions when desired -2. **Backward Compatible**: Default behavior unchanged, existing users unaffected -3. **User Control**: Users can choose between LLM suggestions or deterministic patterns -4. **Token Savings**: When enabled, reduces token usage by not including suggestion instructions -5. **Deterministic Behavior**: Provides predictable command pattern generation when needed - -## Testing - -All tests pass: - -- Execute command tool tests: 23 passed -- Execute command prompt tests: 4 passed - -The implementation is complete and ready for review.