scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-08-28 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: address code review feedback

Browse source 
- Remove code duplication in icon rendering logic
- Use existing icon variable for non-expandable states
- Fix CodeAccordion onToggleExpand handler
This commit is contained in:
Roo Code 2025-10-21 19:13:06 +00:00
parent 809167d7a5
commit daaedc6596
1 changed files with 4 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
webview-ui/src/components/chat/ChatRow.tsx
View file

@ -1053,41 +1053,8 @@ export const ChatRowContent = ({
}}
onClick={canExpand ? handleToggleExpand : undefined}>
<div style={{ display: "flex", alignItems: "center", gap: "10px", flexGrow: 1 }}>
{apiReqCancelReason !== null && apiReqCancelReason !== undefined ? (
apiReqCancelReason === "user_cancelled" ? (
<div
style={{
width: 16,
height: 16,
display: "flex",
alignItems: "center",
justifyContent: "center",
}}>
<span
className="codicon codicon-error"
style={{
color: cancelledColor,
fontSize: 16,
marginBottom: "-1.5px",
}}
/>
</div>
) : (
<div
style={{
width: 16,
height: 16,
display: "flex",
alignItems: "center",
justifyContent: "center",
}}>
<span
className="codicon codicon-error"
style={{ color: errorColor, fontSize: 16, marginBottom: "-1.5px" }}
/>
</div>
)
) : canExpand ? (
{/* Use chevron icon for expandable completed requests, otherwise use the computed icon */}
{canExpand ? (
<div
style={{
width: 16,
@ -1101,22 +1068,8 @@ export const ChatRowContent = ({
style={{ color: normalColor, fontSize: 16, marginBottom: "-1.5px" }}
/>
</div>
) : apiRequestFailedMessage ? (
<div
style={{
width: 16,
height: 16,
display: "flex",
alignItems: "center",
justifyContent: "center",
}}>
<span
className="codicon codicon-error"
style={{ color: errorColor, fontSize: 16, marginBottom: "-1.5px" }}
/>
</div>
) : (
<ProgressIndicator />
icon
)}
{title}
</div>
@ -1133,7 +1086,7 @@ export const ChatRowContent = ({
code={message.text}
language="json"
isExpanded={true}
onToggleExpand={() => {}}
onToggleExpand={handleToggleExpand}
/>
</div>
)}