From d774e6a963c249c08cfe8c9bba2784e7ab0b484b Mon Sep 17 00:00:00 2001 From: Roo Code Date: Thu, 21 Aug 2025 14:30:05 +0000 Subject: [PATCH] fix: remove hardcoded dimension fallback to respect UI settings - Removed hardcoded fallback value (1536) from codebaseIndexEmbedderModelDimension in ClineProvider.ts - This allows the proper dimension resolution hierarchy to work: 1. User-configured dimension from UI settings 2. Model-specific defaults from embedding model profiles 3. System defaults handled by service factory - Fixes issue where UI-configured dimensions were being ignored Fixes #5754 --- src/core/webview/ClineProvider.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts index 9c28120f17..3a2066d0be 100644 --- a/src/core/webview/ClineProvider.ts +++ b/src/core/webview/ClineProvider.ts @@ -1867,7 +1867,7 @@ export class ClineProvider codebaseIndexEmbedderProvider: codebaseIndexConfig?.codebaseIndexEmbedderProvider ?? "openai", codebaseIndexEmbedderBaseUrl: codebaseIndexConfig?.codebaseIndexEmbedderBaseUrl ?? "", codebaseIndexEmbedderModelId: codebaseIndexConfig?.codebaseIndexEmbedderModelId ?? "", - codebaseIndexEmbedderModelDimension: codebaseIndexConfig?.codebaseIndexEmbedderModelDimension ?? 1536, + codebaseIndexEmbedderModelDimension: codebaseIndexConfig?.codebaseIndexEmbedderModelDimension, codebaseIndexOpenAiCompatibleBaseUrl: codebaseIndexConfig?.codebaseIndexOpenAiCompatibleBaseUrl, codebaseIndexSearchMaxResults: codebaseIndexConfig?.codebaseIndexSearchMaxResults, codebaseIndexSearchMinScore: codebaseIndexConfig?.codebaseIndexSearchMinScore,