Safer profile path check

This commit is contained in:
Matt Rubens 2025-02-04 23:55:16 -05:00
parent 43f19d9110
commit d145039d72
3 changed files with 12 additions and 1 deletions

View file

@ -0,0 +1,5 @@
---
"roo-cline": patch
---
Safer shell profile path check

View file

@ -97,6 +97,12 @@ describe("Shell Detection Tests", () => {
expect(getShell()).toBe("C:\\Windows\\System32\\cmd.exe")
})
it("handles undefined profile gracefully", () => {
// Mock a case where defaultProfileName exists but the profile doesn't
mockVsCodeConfig("windows", "NonexistentProfile", {})
expect(getShell()).toBe("C:\\Windows\\System32\\cmd.exe")
})
it("respects userInfo() if no VS Code config is available", () => {
vscode.workspace.getConfiguration = () => ({ get: () => undefined }) as any
;(userInfo as any) = () => ({ shell: "C:\\Custom\\PowerShell.exe" })

View file

@ -105,7 +105,7 @@ function getWindowsShellFromVSCode(): string | null {
}
// If there's a specific path, return that immediately
if (profile.path) {
if (profile?.path) {
return profile.path
}