From c7562a6a370bb2bdabba825b055c3a25163a85dc Mon Sep 17 00:00:00 2001 From: Matt Rubens Date: Thu, 20 Mar 2025 11:33:38 -0400 Subject: [PATCH] Try to avoid placeholders in follow-up questions (#1839) * Try to avoid placeholders in follow-up questions * Fix this too --- .../__snapshots__/system.test.ts.snap | 30 +++++++++---------- .../prompts/tools/ask-followup-question.ts | 2 +- webview-ui/src/components/chat/ChatRow.tsx | 4 ++- 3 files changed, 19 insertions(+), 17 deletions(-) diff --git a/src/core/prompts/__tests__/__snapshots__/system.test.ts.snap b/src/core/prompts/__tests__/__snapshots__/system.test.ts.snap index 92029005d4..1bfc98ac0b 100644 --- a/src/core/prompts/__tests__/__snapshots__/system.test.ts.snap +++ b/src/core/prompts/__tests__/__snapshots__/system.test.ts.snap @@ -188,7 +188,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -650,7 +650,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -1081,7 +1081,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -1461,7 +1461,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -1838,7 +1838,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -2215,7 +2215,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -2638,7 +2638,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -3067,7 +3067,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -3895,7 +3895,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -4335,7 +4335,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -4714,7 +4714,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -5267,7 +5267,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -5735,7 +5735,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -6066,7 +6066,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here @@ -6610,7 +6610,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here diff --git a/src/core/prompts/tools/ask-followup-question.ts b/src/core/prompts/tools/ask-followup-question.ts index c87d29b292..7ece1e311d 100644 --- a/src/core/prompts/tools/ask-followup-question.ts +++ b/src/core/prompts/tools/ask-followup-question.ts @@ -6,7 +6,7 @@ Parameters: - follow_up: (required) A list of 2-4 suggested answers that logically follow from the question, ordered by priority or logical sequence. Each suggestion must: 1. Be provided in its own tag 2. Be specific, actionable, and directly related to the completed task - 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details + 3. Be a complete answer to the question - the user should not need to provide additional information or fill in any missing details. DO NOT include placeholders with brackets or parentheses. Usage: Your question here diff --git a/webview-ui/src/components/chat/ChatRow.tsx b/webview-ui/src/components/chat/ChatRow.tsx index 7319586c46..3f7d174b49 100644 --- a/webview-ui/src/components/chat/ChatRow.tsx +++ b/webview-ui/src/components/chat/ChatRow.tsx @@ -1006,7 +1006,9 @@ export const ChatRowContent = ({ )}
- +