scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-08-28 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Be safer about large file reads (#9843)

Browse source 
validateFileTokenBudget wasn't being called considering
the output budget.
This commit is contained in:
John Richmond 2025-12-04 13:35:26 -08:00 • committed by GitHub
parent 8433eafb05
commit c719117fb4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/core/tools/ReadFileTool.ts
View file

@ -1,11 +1,12 @@
import path from "path"
import { isBinaryFile } from "isbinaryfile"
import type { FileEntry, LineRange } from "@roo-code/types"
import { isNativeProtocol } from "@roo-code/types"
import { isNativeProtocol, ANTHROPIC_DEFAULT_MAX_TOKENS } from "@roo-code/types"
import { Task } from "../task/Task"
import { ClineSayTool } from "../../shared/ExtensionMessage"
import { formatResponse } from "../prompts/responses"
import { getModelMaxOutputTokens } from "../../shared/api"
import { t } from "../../i18n"
import { RecordSource } from "../context-tracking/FileContextTrackerTypes"
import { isPathOutsideWorkspace } from "../../utils/pathUtils"
@ -480,11 +481,22 @@ export class ReadFileTool extends BaseTool<"read_file"> {
continue
}
const modelInfo = task.api.getModel().info
const { id: modelId, info: modelInfo } = task.api.getModel()
const { contextTokens } = task.getTokenUsage()
const contextWindow = modelInfo.contextWindow
const budgetResult = await validateFileTokenBudget(fullPath, contextWindow, contextTokens || 0)
const maxOutputTokens =
getModelMaxOutputTokens({
modelId,
model: modelInfo,
settings: task.apiConfiguration,
}) ?? ANTHROPIC_DEFAULT_MAX_TOKENS
const budgetResult = await validateFileTokenBudget(
fullPath,
contextWindow - maxOutputTokens,
contextTokens || 0,
)
let content = await extractTextFromFile(fullPath)
let xmlInfo = ""

2
src/core/tools/__tests__/readFileTool.spec.ts
View file

@ -210,6 +210,7 @@ function createMockCline(): any {
// CRITICAL: Always ensure image support is enabled
api: {
getModel: vi.fn().mockReturnValue({
id: "test-model",
info: {
supportsImages: true,
contextWindow: 200000,
@ -228,6 +229,7 @@ function createMockCline(): any {
function setImageSupport(mockCline: any, supportsImages: boolean | undefined): void {
mockCline.api = {
getModel: vi.fn().mockReturnValue({
id: "test-model",
info: { supportsImages },
}),
}