From c50668ac0f5c766cecfeb3d703f158434d82b59f Mon Sep 17 00:00:00 2001 From: Roo Code Date: Sun, 3 Aug 2025 01:21:23 +0000 Subject: [PATCH] fix: resolve CI failures for PR #6609 - Add missing translations for "comingSoon", "optional", and "autoApprove.enabled" in all locales - Remove unused src/services/code-index/rerankers/index.ts file to fix knip error - Fix Windows path separator issues in tests by using path.normalize() --- .../code-index/__tests__/search-service.spec.ts | 3 ++- src/services/code-index/rerankers/index.ts | 11 ----------- .../code-index/search-service-reranking.test.ts | 8 +++++++- webview-ui/src/i18n/locales/ca/common.json | 4 +++- webview-ui/src/i18n/locales/de/common.json | 4 +++- webview-ui/src/i18n/locales/es/common.json | 4 +++- webview-ui/src/i18n/locales/fr/common.json | 4 +++- webview-ui/src/i18n/locales/fr/settings.json | 3 ++- webview-ui/src/i18n/locales/hi/common.json | 4 +++- webview-ui/src/i18n/locales/hi/settings.json | 3 ++- webview-ui/src/i18n/locales/id/common.json | 4 +++- webview-ui/src/i18n/locales/id/settings.json | 3 ++- webview-ui/src/i18n/locales/it/common.json | 4 +++- webview-ui/src/i18n/locales/it/settings.json | 3 ++- webview-ui/src/i18n/locales/ja/common.json | 4 +++- webview-ui/src/i18n/locales/ja/settings.json | 3 ++- webview-ui/src/i18n/locales/ko/common.json | 4 +++- webview-ui/src/i18n/locales/ko/settings.json | 3 ++- webview-ui/src/i18n/locales/nl/common.json | 4 +++- webview-ui/src/i18n/locales/nl/settings.json | 3 ++- webview-ui/src/i18n/locales/pl/common.json | 4 +++- webview-ui/src/i18n/locales/pl/settings.json | 3 ++- webview-ui/src/i18n/locales/pt-BR/common.json | 4 +++- webview-ui/src/i18n/locales/pt-BR/settings.json | 3 ++- webview-ui/src/i18n/locales/ru/common.json | 4 +++- webview-ui/src/i18n/locales/ru/settings.json | 3 ++- webview-ui/src/i18n/locales/tr/common.json | 4 +++- webview-ui/src/i18n/locales/tr/settings.json | 3 ++- webview-ui/src/i18n/locales/vi/common.json | 4 +++- webview-ui/src/i18n/locales/vi/settings.json | 3 ++- webview-ui/src/i18n/locales/zh-CN/common.json | 4 +++- webview-ui/src/i18n/locales/zh-CN/settings.json | 3 ++- webview-ui/src/i18n/locales/zh-TW/common.json | 4 +++- webview-ui/src/i18n/locales/zh-TW/settings.json | 3 ++- 34 files changed, 88 insertions(+), 44 deletions(-) delete mode 100644 src/services/code-index/rerankers/index.ts diff --git a/src/services/code-index/__tests__/search-service.spec.ts b/src/services/code-index/__tests__/search-service.spec.ts index ae371e18ed..308d665d34 100644 --- a/src/services/code-index/__tests__/search-service.spec.ts +++ b/src/services/code-index/__tests__/search-service.spec.ts @@ -1,6 +1,7 @@ // npx vitest services/code-index/__tests__/search-service.spec.ts import { describe, it, expect, beforeEach, vi, Mock } from "vitest" +import * as path from "path" import { CodeIndexSearchService } from "../search-service" import { CodeIndexConfigManager } from "../config-manager" import { CodeIndexStateManager } from "../state-manager" @@ -235,7 +236,7 @@ describe("CodeIndexSearchService", () => { // Verify vector store search was called with normalized prefix expect(mockVectorStore.search).toHaveBeenCalledWith( testEmbedding, - "src/auth", // normalized + path.normalize("src/auth"), // normalized to OS-specific format 0.5, 20, ) diff --git a/src/services/code-index/rerankers/index.ts b/src/services/code-index/rerankers/index.ts deleted file mode 100644 index c081301c7d..0000000000 --- a/src/services/code-index/rerankers/index.ts +++ /dev/null @@ -1,11 +0,0 @@ -// Export base class -export { BaseReranker } from "./base" - -// Export implementations -export { LocalReranker } from "./local" - -// Export factory -export { RerankerFactory } from "./factory" - -// Re-export interfaces and types from the interfaces module for convenience -export type { IReranker, RerankCandidate, RerankResult, RerankerConfig, RerankerProvider } from "../interfaces/reranker" diff --git a/src/tests/services/code-index/search-service-reranking.test.ts b/src/tests/services/code-index/search-service-reranking.test.ts index 8af6525f75..3b9ceb6dcf 100644 --- a/src/tests/services/code-index/search-service-reranking.test.ts +++ b/src/tests/services/code-index/search-service-reranking.test.ts @@ -1,4 +1,5 @@ import { describe, it, expect, vi, beforeEach, afterEach } from "vitest" +import * as path from "path" import { CodeIndexSearchService } from "../../../services/code-index/search-service" import { CodeIndexConfigManager } from "../../../services/code-index/config-manager" import { CodeIndexStateManager } from "../../../services/code-index/state-manager" @@ -298,7 +299,12 @@ describe("CodeIndexSearchService - Reranking Integration", () => { await searchService.searchIndex("test query", directoryPrefix) - expect(mockVectorStore.search).toHaveBeenCalledWith(expect.any(Array), directoryPrefix, 0.3, 100) + expect(mockVectorStore.search).toHaveBeenCalledWith( + expect.any(Array), + path.normalize(directoryPrefix), // normalized to OS-specific format + 0.3, + 100, + ) }) }) diff --git a/webview-ui/src/i18n/locales/ca/common.json b/webview-ui/src/i18n/locales/ca/common.json index 13ad7a2ca7..39edd549e3 100644 --- a/webview-ui/src/i18n/locales/ca/common.json +++ b/webview-ui/src/i18n/locales/ca/common.json @@ -67,5 +67,7 @@ "editMessage": "Editar missatge", "editWarning": "Editar aquest missatge eliminarà tots els missatges posteriors de la conversa. Vols continuar?", "proceed": "Continuar" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/de/common.json b/webview-ui/src/i18n/locales/de/common.json index c873e25d12..d71a993c5e 100644 --- a/webview-ui/src/i18n/locales/de/common.json +++ b/webview-ui/src/i18n/locales/de/common.json @@ -67,5 +67,7 @@ "editMessage": "Nachricht bearbeiten", "editWarning": "Das Bearbeiten dieser Nachricht wird alle nachfolgenden Nachrichten in der Unterhaltung löschen. Möchtest du fortfahren?", "proceed": "Fortfahren" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/es/common.json b/webview-ui/src/i18n/locales/es/common.json index ee0a924d43..97145767c8 100644 --- a/webview-ui/src/i18n/locales/es/common.json +++ b/webview-ui/src/i18n/locales/es/common.json @@ -67,5 +67,7 @@ "editMessage": "Editar mensaje", "editWarning": "Editar este mensaje eliminará todos los mensajes posteriores en la conversación. ¿Deseas continuar?", "proceed": "Continuar" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/fr/common.json b/webview-ui/src/i18n/locales/fr/common.json index 40c12e2afb..3e199174a0 100644 --- a/webview-ui/src/i18n/locales/fr/common.json +++ b/webview-ui/src/i18n/locales/fr/common.json @@ -67,5 +67,7 @@ "editMessage": "Modifier le message", "editWarning": "Modifier ce message supprimera tous les messages suivants dans la conversation. Voulez-vous continuer ?", "proceed": "Continuer" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/fr/settings.json b/webview-ui/src/i18n/locales/fr/settings.json index a07feff683..0955a0d4cb 100644 --- a/webview-ui/src/i18n/locales/fr/settings.json +++ b/webview-ui/src/i18n/locales/fr/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Effectuer automatiquement des requêtes jusqu'à ces limites avant de demander une autorisation pour continuer." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Documentation {{provider}}", diff --git a/webview-ui/src/i18n/locales/hi/common.json b/webview-ui/src/i18n/locales/hi/common.json index 227e25637e..217e05ca62 100644 --- a/webview-ui/src/i18n/locales/hi/common.json +++ b/webview-ui/src/i18n/locales/hi/common.json @@ -67,5 +67,7 @@ "editMessage": "संदेश संपादित करें", "editWarning": "इस संदेश को संपादित करने से बातचीत के सभी बाद के संदेश हट जाएंगे। क्या आप जारी रखना चाहते हैं?", "proceed": "जारी रखें" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/hi/settings.json b/webview-ui/src/i18n/locales/hi/settings.json index 1c03ac8cbf..15a663f691 100644 --- a/webview-ui/src/i18n/locales/hi/settings.json +++ b/webview-ui/src/i18n/locales/hi/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "स्वचालित रूप से जारी रखने के लिए अनुमोदन माँगने से पहले इन सीमाओं तक अनुरोध करें।" - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}} दस्तावेज़ीकरण", diff --git a/webview-ui/src/i18n/locales/id/common.json b/webview-ui/src/i18n/locales/id/common.json index 3a3a3f5a78..5ad4d1b8c3 100644 --- a/webview-ui/src/i18n/locales/id/common.json +++ b/webview-ui/src/i18n/locales/id/common.json @@ -67,5 +67,7 @@ "editMessage": "Edit Pesan", "editWarning": "Mengedit pesan ini akan menghapus semua pesan selanjutnya dalam percakapan. Apakah kamu ingin melanjutkan?", "proceed": "Lanjutkan" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/id/settings.json b/webview-ui/src/i18n/locales/id/settings.json index 66735bbd28..c56494981c 100644 --- a/webview-ui/src/i18n/locales/id/settings.json +++ b/webview-ui/src/i18n/locales/id/settings.json @@ -240,7 +240,8 @@ }, "maxLimits": { "description": "Secara otomatis membuat permintaan hingga batas ini sebelum meminta persetujuan untuk melanjutkan." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Dokumentasi {{provider}}", diff --git a/webview-ui/src/i18n/locales/it/common.json b/webview-ui/src/i18n/locales/it/common.json index 20886d126b..f828834605 100644 --- a/webview-ui/src/i18n/locales/it/common.json +++ b/webview-ui/src/i18n/locales/it/common.json @@ -67,5 +67,7 @@ "editMessage": "Modifica Messaggio", "editWarning": "Modificando questo messaggio verranno eliminati tutti i messaggi successivi nella conversazione. Vuoi procedere?", "proceed": "Procedi" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/it/settings.json b/webview-ui/src/i18n/locales/it/settings.json index 67e8beceae..8652431260 100644 --- a/webview-ui/src/i18n/locales/it/settings.json +++ b/webview-ui/src/i18n/locales/it/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Esegui automaticamente richieste fino a questi limiti prima di chiedere l'approvazione per continuare." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Documentazione {{provider}}", diff --git a/webview-ui/src/i18n/locales/ja/common.json b/webview-ui/src/i18n/locales/ja/common.json index a7390de32a..5195279121 100644 --- a/webview-ui/src/i18n/locales/ja/common.json +++ b/webview-ui/src/i18n/locales/ja/common.json @@ -67,5 +67,7 @@ "editMessage": "メッセージを編集", "editWarning": "このメッセージを編集すると、会話内の後続のメッセージもすべて削除されます。続行しますか？", "proceed": "続行" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/ja/settings.json b/webview-ui/src/i18n/locales/ja/settings.json index a38ef74d51..91d58a0a7a 100644 --- a/webview-ui/src/i18n/locales/ja/settings.json +++ b/webview-ui/src/i18n/locales/ja/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "これらの上限まで自動的にリクエストを行い、その後継続の承認を求めます。" - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}}のドキュメント", diff --git a/webview-ui/src/i18n/locales/ko/common.json b/webview-ui/src/i18n/locales/ko/common.json index 2164c65624..6a8d7d8856 100644 --- a/webview-ui/src/i18n/locales/ko/common.json +++ b/webview-ui/src/i18n/locales/ko/common.json @@ -67,5 +67,7 @@ "editMessage": "메시지 편집", "editWarning": "이 메시지를 편집하면 대화의 모든 후속 메시지가 삭제됩니다. 계속하시겠습니까?", "proceed": "계속" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/ko/settings.json b/webview-ui/src/i18n/locales/ko/settings.json index e8eefaebf7..1b8add92dd 100644 --- a/webview-ui/src/i18n/locales/ko/settings.json +++ b/webview-ui/src/i18n/locales/ko/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "이러한 한도까지 자동으로 요청을 수행한 후, 계속 진행하기 위한 승인을 요청합니다." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}} 문서", diff --git a/webview-ui/src/i18n/locales/nl/common.json b/webview-ui/src/i18n/locales/nl/common.json index 4b72bccb9c..8b3f1a7797 100644 --- a/webview-ui/src/i18n/locales/nl/common.json +++ b/webview-ui/src/i18n/locales/nl/common.json @@ -67,5 +67,7 @@ "editMessage": "Bericht Bewerken", "editWarning": "Het bewerken van dit bericht zal alle volgende berichten in het gesprek verwijderen. Wil je doorgaan?", "proceed": "Doorgaan" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/nl/settings.json b/webview-ui/src/i18n/locales/nl/settings.json index 25bbb5867d..1273aec3ae 100644 --- a/webview-ui/src/i18n/locales/nl/settings.json +++ b/webview-ui/src/i18n/locales/nl/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Automatisch verzoeken indienen tot aan deze limieten voordat om goedkeuring wordt gevraagd om door te gaan." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}} documentatie", diff --git a/webview-ui/src/i18n/locales/pl/common.json b/webview-ui/src/i18n/locales/pl/common.json index 6ec9e6661a..8bc77e5d85 100644 --- a/webview-ui/src/i18n/locales/pl/common.json +++ b/webview-ui/src/i18n/locales/pl/common.json @@ -67,5 +67,7 @@ "editMessage": "Edytuj Wiadomość", "editWarning": "Edycja tej wiadomości spowoduje usunięcie wszystkich kolejnych wiadomości w rozmowie. Czy chcesz kontynuować?", "proceed": "Kontynuuj" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/pl/settings.json b/webview-ui/src/i18n/locales/pl/settings.json index a2e840d1d4..698c60c65b 100644 --- a/webview-ui/src/i18n/locales/pl/settings.json +++ b/webview-ui/src/i18n/locales/pl/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Automatycznie składaj zapytania do tych limitów przed poproszeniem o zgodę na kontynuowanie." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Dokumentacja {{provider}}", diff --git a/webview-ui/src/i18n/locales/pt-BR/common.json b/webview-ui/src/i18n/locales/pt-BR/common.json index 964ba893f2..d5ba8b8aa8 100644 --- a/webview-ui/src/i18n/locales/pt-BR/common.json +++ b/webview-ui/src/i18n/locales/pt-BR/common.json @@ -67,5 +67,7 @@ "editMessage": "Editar Mensagem", "editWarning": "Editar esta mensagem irá excluir todas as mensagens subsequentes na conversa. Deseja prosseguir?", "proceed": "Prosseguir" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/pt-BR/settings.json b/webview-ui/src/i18n/locales/pt-BR/settings.json index a9ea96060b..1bac3a0641 100644 --- a/webview-ui/src/i18n/locales/pt-BR/settings.json +++ b/webview-ui/src/i18n/locales/pt-BR/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Fazer solicitações automaticamente até estes limites antes de pedir aprovação para continuar." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Documentação do {{provider}}", diff --git a/webview-ui/src/i18n/locales/ru/common.json b/webview-ui/src/i18n/locales/ru/common.json index 772b797bba..db16846d05 100644 --- a/webview-ui/src/i18n/locales/ru/common.json +++ b/webview-ui/src/i18n/locales/ru/common.json @@ -67,5 +67,7 @@ "editMessage": "Редактировать Сообщение", "editWarning": "Редактирование этого сообщения приведет к удалению всех последующих сообщений в разговоре. Хотите продолжить?", "proceed": "Продолжить" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/ru/settings.json b/webview-ui/src/i18n/locales/ru/settings.json index cb62308408..343a1ed1b9 100644 --- a/webview-ui/src/i18n/locales/ru/settings.json +++ b/webview-ui/src/i18n/locales/ru/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Автоматически выполнять запросы до указанных лимитов, прежде чем запрашивать разрешение на продолжение." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Документация {{provider}}", diff --git a/webview-ui/src/i18n/locales/tr/common.json b/webview-ui/src/i18n/locales/tr/common.json index 7bbb6f3d84..3838eeb772 100644 --- a/webview-ui/src/i18n/locales/tr/common.json +++ b/webview-ui/src/i18n/locales/tr/common.json @@ -67,5 +67,7 @@ "editMessage": "Mesajı Düzenle", "editWarning": "Bu mesajı düzenlemek, konuşmadaki sonraki tüm mesajları da silecektir. Devam etmek istiyor musun?", "proceed": "Devam Et" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/tr/settings.json b/webview-ui/src/i18n/locales/tr/settings.json index 8837c1a562..3831879bcc 100644 --- a/webview-ui/src/i18n/locales/tr/settings.json +++ b/webview-ui/src/i18n/locales/tr/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Bu sınırlara ulaşana kadar otomatik olarak istekleri yap, sonrasında devam etmek için onay iste." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}} Dokümantasyonu", diff --git a/webview-ui/src/i18n/locales/vi/common.json b/webview-ui/src/i18n/locales/vi/common.json index 2d36482495..c728fc2ed3 100644 --- a/webview-ui/src/i18n/locales/vi/common.json +++ b/webview-ui/src/i18n/locales/vi/common.json @@ -67,5 +67,7 @@ "editMessage": "Chỉnh Sửa Tin Nhắn", "editWarning": "Chỉnh sửa tin nhắn này sẽ xóa tất cả các tin nhắn tiếp theo trong cuộc trò chuyện. Bạn có muốn tiếp tục không?", "proceed": "Tiếp Tục" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/vi/settings.json b/webview-ui/src/i18n/locales/vi/settings.json index 39f60d87e2..20534b79c9 100644 --- a/webview-ui/src/i18n/locales/vi/settings.json +++ b/webview-ui/src/i18n/locales/vi/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "Tự động thực hiện các yêu cầu lên đến các giới hạn này trước khi xin phê duyệt để tiếp tục." - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "Tài liệu {{provider}}", diff --git a/webview-ui/src/i18n/locales/zh-CN/common.json b/webview-ui/src/i18n/locales/zh-CN/common.json index de6d1cd7fe..02f9ff6348 100644 --- a/webview-ui/src/i18n/locales/zh-CN/common.json +++ b/webview-ui/src/i18n/locales/zh-CN/common.json @@ -67,5 +67,7 @@ "editMessage": "编辑消息", "editWarning": "编辑此消息将删除对话中的所有后续消息。是否继续？", "proceed": "继续" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/zh-CN/settings.json b/webview-ui/src/i18n/locales/zh-CN/settings.json index 48973be588..e8cb9c891a 100644 --- a/webview-ui/src/i18n/locales/zh-CN/settings.json +++ b/webview-ui/src/i18n/locales/zh-CN/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "在请求批准继续之前，自动发出请求，最多不超过这些限制。" - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}} 文档", diff --git a/webview-ui/src/i18n/locales/zh-TW/common.json b/webview-ui/src/i18n/locales/zh-TW/common.json index a3949a2a9d..fccdb43540 100644 --- a/webview-ui/src/i18n/locales/zh-TW/common.json +++ b/webview-ui/src/i18n/locales/zh-TW/common.json @@ -67,5 +67,7 @@ "editMessage": "編輯訊息", "editWarning": "編輯此訊息將刪除對話中的所有後續訊息。是否繼續？", "proceed": "繼續" - } + }, + "comingSoon": "Coming Soon", + "optional": "optional" } diff --git a/webview-ui/src/i18n/locales/zh-TW/settings.json b/webview-ui/src/i18n/locales/zh-TW/settings.json index 1710255482..e117ec3e3f 100644 --- a/webview-ui/src/i18n/locales/zh-TW/settings.json +++ b/webview-ui/src/i18n/locales/zh-TW/settings.json @@ -236,7 +236,8 @@ }, "maxLimits": { "description": "在请求获得继续操作的批准前，自动发送请求直至达到这些限制。" - } + }, + "enabled": "Auto-Approve Enabled" }, "providers": { "providerDocumentation": "{{provider}} 文件",