scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-05 08:10:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove misleading 'Retrying...' from MCP invalid JSON error message

Browse source 
The error message for invalid JSON arguments in MCP tool calls incorrectly stated 'Retrying...' when no automatic retry was actually happening. This was misleading users into thinking the system would automatically retry with corrected JSON.

Changed the message to clearly indicate the error and instruct users to manually retry with properly formatted JSON.

Fixes #9378
This commit is contained in:
Roo Code 2025-11-19 01:53:18 +00:00
parent 7c079453dc
commit ba02b5bee3
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/tools/__tests__/useMcpToolTool.spec.ts
View file

@ -24,7 +24,7 @@ vi.mock("../../prompts/responses", () => ({
vi.mock("../../../i18n", () => ({
t: vi.fn((key: string, params?: any) => {
if (key === "mcp:errors.invalidJsonArgument" && params?.toolName) {
return `Roo tried to use ${params.toolName} with an invalid JSON argument. Retrying...`
return `Failed to use ${params.toolName}: Invalid JSON argument provided. Please ensure the arguments are properly formatted JSON and try again.`
}
if (key === "mcp:errors.toolNotFound" && params) {
return `Tool '${params.toolName}' does not exist on server '${params.serverName}'. Available tools: ${params.availableTools}`
@ -164,7 +164,7 @@ describe("useMcpToolTool", () => {
expect(mockTask.consecutiveMistakeCount).toBe(1)
expect(mockTask.recordToolError).toHaveBeenCalledWith("use_mcp_tool")
expect(mockTask.say).toHaveBeenCalledWith("error", expect.stringContaining("invalid JSON argument"))
expect(mockTask.say).toHaveBeenCalledWith("error", expect.stringContaining("Invalid JSON argument"))
expect(mockPushToolResult).toHaveBeenCalledWith("Tool error: Invalid args for test_server:test_tool")
})
})

2
src/i18n/locales/en/mcp.json
View file

@ -5,7 +5,7 @@
"invalid_settings_validation": "Invalid MCP settings format: {{errorMessages}}",
"create_json": "Failed to create or open .roo/mcp.json: {{error}}",
"failed_update_project": "Failed to update project MCP servers",
"invalidJsonArgument": "Roo tried to use {{toolName}} with an invalid JSON argument. Retrying...",
"invalidJsonArgument": "Failed to use {{toolName}}: Invalid JSON argument provided. Please ensure the arguments are properly formatted JSON and try again.",
"refresh_after_disable": "Failed to refresh MCP connections after disabling",
"refresh_after_enable": "Failed to refresh MCP connections after enabling",
"disconnect_servers_partial": "Failed to disconnect {{count}} MCP server(s). Check the output for details.",