From b760452ee3ee02eac52e11de38daf43bb9dec1d3 Mon Sep 17 00:00:00 2001 From: Hannes Rudolph Date: Wed, 7 Jan 2026 14:55:05 -0700 Subject: [PATCH] fix: address review comments - use substring instead of deprecated substr, use Number() for type conversion --- packages/types/src/code-snippet.ts | 2 +- src/core/webview/ClineProvider.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/types/src/code-snippet.ts b/packages/types/src/code-snippet.ts index 810b887faa..5b2ddc1c0e 100644 --- a/packages/types/src/code-snippet.ts +++ b/packages/types/src/code-snippet.ts @@ -22,7 +22,7 @@ export interface CodeSnippet { * Creates a unique ID for a code snippet */ export function createCodeSnippetId(): string { - return `snippet-${Date.now()}-${Math.random().toString(36).substr(2, 9)}` + return `snippet-${Date.now()}-${Math.random().toString(36).substring(2, 11)}` } /** diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts index 793fd85858..8e70060ce2 100644 --- a/src/core/webview/ClineProvider.ts +++ b/src/core/webview/ClineProvider.ts @@ -688,8 +688,8 @@ export class ClineProvider const codeSnippet: CodeSnippet = { id: createCodeSnippetId(), filePath: params.filePath as string, - startLine: params.startLine as unknown as number, - endLine: params.endLine as unknown as number, + startLine: Number(params.startLine), + endLine: Number(params.endLine), content: params.selectedText as string, timestamp: Date.now(), }