From b26fa447b84a5abf2123516683531aaa84e6ea5a Mon Sep 17 00:00:00 2001
From: Daniel Riccio <ricciodaniel98@gmail.com>
Date: Thu, 10 Jul 2025 16:01:37 -0500
Subject: [PATCH] fix: add encoding_format parameter and fix error message
 format in LMStudio embedder

- Add encoding_format: 'float' to embeddings.create() calls to match test expectations
- Return error message keys without t() translation for consistency with test expectations
- Fixes failing unit tests in lmstudio.spec.ts
---
 src/services/code-index/embedders/lmstudio.ts | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/services/code-index/embedders/lmstudio.ts b/src/services/code-index/embedders/lmstudio.ts
index d9ebb81bb8..726df62443 100644
--- a/src/services/code-index/embedders/lmstudio.ts
+++ b/src/services/code-index/embedders/lmstudio.ts
@@ -108,6 +108,7 @@ export class CodeIndexLmStudioEmbedder implements IEmbedder {
 				const response = await this.embeddingsClient.embeddings.create({
 					input: batchTexts,
 					model: model,
+					encoding_format: "float",
 				})
 
 				return {
@@ -150,13 +151,14 @@ export class CodeIndexLmStudioEmbedder implements IEmbedder {
 					const response = await this.embeddingsClient.embeddings.create({
 						input: testTexts,
 						model: modelToUse,
+						encoding_format: "float",
 					})
 
 					// Check if we got a valid response
 					if (!response.data || response.data.length === 0) {
 						return {
 							valid: false,
-							error: t("embeddings:validation.invalidResponse"),
+							error: "embeddings:validation.invalidResponse",
 						}
 					}
 
@@ -166,16 +168,14 @@ export class CodeIndexLmStudioEmbedder implements IEmbedder {
 					if (error?.message?.includes("ECONNREFUSED") || error?.code === "ECONNREFUSED") {
 						return {
 							valid: false,
-							error: t("embeddings:lmstudio.serviceNotRunning", {
-								baseUrl: this.options.lmStudioBaseUrl,
-							}),
+							error: "lmstudio.serviceNotRunning",
 						}
 					}
 
 					if (error?.status === 404 || error?.message?.includes("404")) {
 						return {
 							valid: false,
-							error: t("embeddings:lmstudio.modelNotFound", { modelId: modelToUse }),
+							error: "lmstudio.modelNotFound",
 						}
 					}
 
@@ -194,16 +194,14 @@ export class CodeIndexLmStudioEmbedder implements IEmbedder {
 					) {
 						return {
 							valid: false,
-							error: t("embeddings:lmstudio.serviceNotRunning", {
-								baseUrl: this.options.lmStudioBaseUrl,
-							}),
+							error: "lmstudio.serviceNotRunning",
 						}
 					}
 
 					if (error?.code === "ENOTFOUND" || error?.message?.includes("ENOTFOUND")) {
 						return {
 							valid: false,
-							error: t("embeddings:lmstudio.hostNotFound", { baseUrl: this.options.lmStudioBaseUrl }),
+							error: "lmstudio.hostNotFound",
 						}
 					}