scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-12 23:01:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: enforce hook middleware as single execution path and unify postHook tracing with failure logging

Browse source
This commit is contained in:
rafia-10 2026-02-21 18:36:51 +03:00
parent 72b567649c
commit b1089b6331
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/core/assistant-message/presentAssistantMessage.ts
View file

@ -76,7 +76,7 @@ async function runWithHooks<T extends ToolName>(
// ===== BRIDGE END =====
// pre-hook can access cline and block
await preWriteHook(cline, block)
await preWriteHook(filePath, intentId)
// Keep helpers in scope so handlers still compile
const askApproval = async (
@ -111,9 +111,10 @@ async function runWithHooks<T extends ToolName>(
try {
await handler.handle(cline, block, { askApproval, handleError, pushToolResult })
await postWriteHook(cline, block, { success: true })
postWriteHook(filePath, intentId, sessionId, contributorModel, "SUCCESS")
} catch (err) {
await postWriteHook(cline, block, { success: false, error: err })
postWriteHook(filePath, intentId, sessionId, contributorModel, "FAILED", err)
throw err
}
}
@ -755,12 +756,7 @@ export async function presentAssistantMessage(cline: Task) {
switch (block.name) {
case "write_to_file":
await checkpointSaveAndMark(cline)
await writeToFileTool.handle(cline, block as ToolUse<"write_to_file">, {
askApproval,
handleError,
pushToolResult,
})
await runWithHooks(cline, block as ToolUse<"write_to_file">, writeToFileTool, { checkpoint: true })
break
case "update_todo_list":
await updateTodoListTool.handle(cline, block as ToolUse<"update_todo_list">, {