source change results in reload

webview-ui/src/components/package-manager/PackageManagerViewStateManager.ts

@@ -308,7 +308,9 @@ export class PackageManagerViewStateManager {
 				const updatedSources = sources.length === 0 ? [DEFAULT_PACKAGE_MANAGER_SOURCE] : sources
 				this.state.sources = updatedSources
 				this.sourcesModified = true // Set the flag when sources are modified
-				this.state.isFetching = false // Reset fetching state when sources change
+
+				// Reset fetching state first
+				this.state.isFetching = false
 				this.notifyStateChange()
 
 				// Send sources update to extension
@@ -317,11 +319,17 @@ export class PackageManagerViewStateManager {
 					sources: updatedSources,
 				} as WebviewMessage)
 
-				// Schedule fetch for next tick to ensure sources message is sent first
-				if (this.state.activeTab === "browse") {
-					setTimeout(() => {
-						void this.transition({ type: "FETCH_ITEMS" })
-					}, 0)
+				// Only start fetching if we have sources
+				if (updatedSources.length > 0) {
+					// Set fetching state and notify
+					this.state.isFetching = true
+					this.notifyStateChange()
+
+					// Send fetch request
+					vscode.postMessage({
+						type: "fetchPackageManagerItems",
+						bool: true,
+					} as WebviewMessage)
 				}
 				break
 			}

webview-ui/src/components/package-manager/__tests__/PackageManagerViewStateManager.test.ts

@@ -307,6 +307,38 @@ describe("PackageManagerViewStateManager", () => {
 			expect(state.allItems).toHaveLength(1)
 			expect(state.isFetching).toBe(false)
 		})
+
+		it("should trigger fetch after adding a new source and switching to browse", async () => {
+			// Reset mock before test
+			;(vscode.postMessage as jest.Mock).mockClear()
+
+			// Add a new source
+			const newSource = { url: "https://github.com/test/repo1", enabled: true }
+			await manager.transition({
+				type: "UPDATE_SOURCES",
+				payload: { sources: [DEFAULT_PACKAGE_MANAGER_SOURCE, newSource] },
+			})
+
+			// Switch to browse tab
+			await manager.transition({
+				type: "SET_ACTIVE_TAB",
+				payload: { tab: "browse" },
+			})
+
+			// Run any pending timers
+			jest.runAllTimers()
+
+			// Verify that a fetch was triggered
+			expect(vscode.postMessage).toHaveBeenCalledWith({
+				type: "fetchPackageManagerItems",
+				bool: true,
+			})
+
+			// Verify state
+			const state = manager.getState()
+			expect(state.isFetching).toBe(true)
+			expect(state.activeTab).toBe("browse")
+		})
 	})
 
 	describe("Error Handling", () => {
@@ -599,7 +631,7 @@ describe("PackageManagerViewStateManager", () => {
 			jest.useRealTimers()
 		})
 
-		it("should reset isFetching after source deletion", async () => {
+		it("should trigger fetch for remaining source after source deletion", async () => {
 			// Start with two sources
 			const sources = [
 				{ url: "https://github.com/test/repo1", enabled: true },
@@ -611,8 +643,8 @@ describe("PackageManagerViewStateManager", () => {
 				payload: { sources },
 			})
 
-			// Set isFetching to true
-			await manager.transition({ type: "FETCH_ITEMS" })
+			// Clear mock to ignore initial fetch
+			;(vscode.postMessage as jest.Mock).mockClear()
 
 			// Delete one source
 			await manager.transition({
@@ -620,12 +652,15 @@ describe("PackageManagerViewStateManager", () => {
 				payload: { sources: [sources[0]] },
 			})
 
-			// Run any pending timers
-			jest.runAllTimers()
+			// Verify that a fetch was triggered for the remaining source
+			expect(vscode.postMessage).toHaveBeenCalledWith({
+				type: "fetchPackageManagerItems",
+				bool: true,
+			})
 
-			// Verify isFetching was reset
+			// Verify state has the remaining source
 			const state = manager.getState()
-			expect(state.isFetching).toBe(false)
+			expect(state.sources).toEqual([sources[0]])
 		})
 
 		it("should re-add default source when all sources are removed", async () => {