From a46cf106b9572734503c335e4179ea6d327e01ce Mon Sep 17 00:00:00 2001 From: Daniel Riccio Date: Thu, 10 Jul 2025 16:25:03 -0500 Subject: [PATCH] fix: handle validation errors differently for LMStudio vs other embedders - LMStudio tests expect translation keys for generic errors - Ollama tests expect the actual error message to be preserved - Updated validation-helpers to check embedder type and handle accordingly --- src/services/code-index/shared/validation-helpers.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/services/code-index/shared/validation-helpers.ts b/src/services/code-index/shared/validation-helpers.ts index ee7ef11677..ed26d82030 100644 --- a/src/services/code-index/shared/validation-helpers.ts +++ b/src/services/code-index/shared/validation-helpers.ts @@ -146,7 +146,17 @@ export function handleValidationError( } } - // For generic errors, always return the translation key for consistency with tests + // For generic errors, check if it's a meaningful error message + if (errorMessage && errorMessage !== "Unknown error") { + // For LMStudio, we need to return the translation key + if (embedderType === "lmstudio") { + return { valid: false, error: "embeddings:validation.configurationError" } + } + // For other embedders, preserve the original error message + return { valid: false, error: errorMessage } + } + + // Fallback to generic error return { valid: false, error: "embeddings:validation.configurationError" } }