From 8a9240000c485a274cb33326b8c102d5f36f0c92 Mon Sep 17 00:00:00 2001 From: Smartsheet-JB-Brown Date: Thu, 17 Apr 2025 17:20:14 -0700 Subject: [PATCH] round 3 of locale CI fixes --- .../__tests__/PackageManagerView.test.tsx | 4 ++-- .../__tests__/PackageManagerItemCard.test.tsx | 13 ++++++++----- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/webview-ui/src/components/package-manager/__tests__/PackageManagerView.test.tsx b/webview-ui/src/components/package-manager/__tests__/PackageManagerView.test.tsx index 74d54799e4..053d949229 100644 --- a/webview-ui/src/components/package-manager/__tests__/PackageManagerView.test.tsx +++ b/webview-ui/src/components/package-manager/__tests__/PackageManagerView.test.tsx @@ -127,7 +127,7 @@ describe("PackageManagerView", () => { }) // Should show items - expect(screen.getByText("2 items total")).toBeInTheDocument() + expect(screen.getByText("2 items found")).toBeInTheDocument() expect(screen.getByText("Test Package")).toBeInTheDocument() expect(screen.getByText("Another Package")).toBeInTheDocument() }) @@ -175,7 +175,7 @@ describe("PackageManagerView", () => { }) // Verify initial items are shown - expect(screen.getByText("3 items total")).toBeInTheDocument() + expect(screen.getByText("3 items found")).toBeInTheDocument() expect(screen.getByText("MCP Server 1")).toBeInTheDocument() expect(screen.getByText("Mode 1")).toBeInTheDocument() expect(screen.getByText("MCP Server 2")).toBeInTheDocument() diff --git a/webview-ui/src/components/package-manager/components/__tests__/PackageManagerItemCard.test.tsx b/webview-ui/src/components/package-manager/components/__tests__/PackageManagerItemCard.test.tsx index c2c5bfe68f..375db3980c 100644 --- a/webview-ui/src/components/package-manager/components/__tests__/PackageManagerItemCard.test.tsx +++ b/webview-ui/src/components/package-manager/components/__tests__/PackageManagerItemCard.test.tsx @@ -70,7 +70,12 @@ describe("PackageManagerItemCard", () => { return element?.textContent === "by Test Author" }), ).toBeInTheDocument() - expect(screen.getByText(/Package/i)).toBeInTheDocument() // Using case-insensitive regex since translations might vary in case + // Check for the type label specifically + expect( + screen.getByText((content, element) => { + return Boolean(element?.className.includes("rounded-full") && content === "Package") + }), + ).toBeInTheDocument() }) it("should render tags", () => { @@ -126,8 +131,7 @@ describe("PackageManagerItemCard", () => { path: "some/path", } renderWithProviders() - - const button = screen.getByRole("button", { name: /Source/i }) + const button = screen.getByRole("button", { name: /View/i }) fireEvent.click(button) expect(mockPostMessage).toHaveBeenCalledWith({ @@ -156,7 +160,7 @@ describe("PackageManagerItemCard", () => { // Find the source button by its aria-label const button = screen.getByRole("button", { - name: "Source", + name: "View", }) expect(button.querySelector(".codicon-link-external")).toBeInTheDocument() expect(button).toHaveTextContent(/Source/i) @@ -185,7 +189,6 @@ describe("PackageManagerItemCard", () => { // These use the type-group translations expect(screen.getByText((content, element) => element?.textContent === "MCP Servers")).toBeInTheDocument() expect(screen.getByText((content, element) => element?.textContent === "Modes")).toBeInTheDocument() - expect(screen.getByText("Modes")).toBeInTheDocument() // Check for items using getByRole and textContent const items = screen.getAllByRole("listitem")