fix: remove gpt-5.4-codex (does not exist), update default to gpt-5.4, fix minimal->none

This commit is contained in:
Hannes Rudolph 2026-03-07 18:58:48 -07:00
parent a42d8d7be2
commit 8357f330a0
2 changed files with 3 additions and 30 deletions

View file

@ -16,7 +16,7 @@ import type { ModelInfo } from "../model.js"
export type OpenAiCodexModelId = keyof typeof openAiCodexModels
export const openAiCodexDefaultModelId: OpenAiCodexModelId = "gpt-5.4-codex"
export const openAiCodexDefaultModelId: OpenAiCodexModelId = "gpt-5.4"
/**
* Models available through the Codex OAuth flow.
@ -24,21 +24,6 @@ export const openAiCodexDefaultModelId: OpenAiCodexModelId = "gpt-5.4-codex"
* Costs are 0 as they are covered by the subscription.
*/
export const openAiCodexModels = {
"gpt-5.4-codex": {
maxTokens: 128000,
contextWindow: 1_050_000,
includedTools: ["apply_patch"],
excludedTools: ["apply_diff", "write_to_file"],
supportsImages: true,
supportsPromptCache: true,
supportsReasoningEffort: ["low", "medium", "high", "xhigh"],
reasoningEffort: "medium",
inputPrice: 0,
outputPrice: 0,
supportsTemperature: false,
description:
"GPT-5.4 Codex: OpenAI's latest flagship coding model with 1M token context via ChatGPT subscription",
},
"gpt-5.4": {
maxTokens: 128000,
contextWindow: 1_050_000,
@ -149,7 +134,7 @@ export const openAiCodexModels = {
excludedTools: ["apply_diff", "write_to_file"],
supportsImages: true,
supportsPromptCache: true,
supportsReasoningEffort: ["minimal", "low", "medium", "high"],
supportsReasoningEffort: ["none", "low", "medium", "high"],
reasoningEffort: "medium",
// Subscription-based: no per-token costs
inputPrice: 0,

View file

@ -10,7 +10,6 @@ describe("OpenAiCodexHandler.getModel", () => {
"gpt-5-codex",
"gpt-5-codex-mini",
"gpt-5.3-codex-spark",
"gpt-5.4-codex",
])("should return specified model when a valid model id is provided: %s", (apiModelId) => {
const handler = new OpenAiCodexHandler({ apiModelId })
const model = handler.getModel()
@ -25,7 +24,7 @@ describe("OpenAiCodexHandler.getModel", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "not-a-real-model" })
const model = handler.getModel()
expect(model.id).toBe("gpt-5.4-codex")
expect(model.id).toBe("gpt-5.4")
expect(model.info).toBeDefined()
})
@ -40,17 +39,6 @@ describe("OpenAiCodexHandler.getModel", () => {
expect(model.info.reasoningEffort).toBe("none")
})
it("should use GPT-5.4 Codex with 1M token context window", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "gpt-5.4-codex" })
const model = handler.getModel()
expect(model.id).toBe("gpt-5.4-codex")
expect(model.info.contextWindow).toBe(1_050_000)
expect(model.info.reasoningEffort).toBe("medium")
expect(model.info.inputPrice).toBe(0)
expect(model.info.outputPrice).toBe(0)
})
it("should use Spark-specific limits and capabilities", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "gpt-5.3-codex-spark" })
const model = handler.getModel()