From 7e2cd4b7b0c880c583acd564ec56e8ce8b009e4d Mon Sep 17 00:00:00 2001 From: Matt Rubens Date: Fri, 4 Jul 2025 11:30:52 -0400 Subject: [PATCH] Small tool usage cleanup (#203) --- .../src/lib/__tests__/toolUsageParser.test.ts | 5 ++--- apps/web/src/lib/toolUsageParser.ts | 18 +++++++++--------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/apps/web/src/lib/__tests__/toolUsageParser.test.ts b/apps/web/src/lib/__tests__/toolUsageParser.test.ts index 87de0e78f3..00d4939dfe 100644 --- a/apps/web/src/lib/__tests__/toolUsageParser.test.ts +++ b/apps/web/src/lib/__tests__/toolUsageParser.test.ts @@ -188,17 +188,16 @@ describe('toolUsageParser', () => { }); }); - it('should handle searchFiles tool with query fallback', () => { + it('should handle searchFiles tool without regex', () => { const message = { ask: 'tool', - text: '{"tool":"searchFiles","query":"test pattern"}', + text: '{"tool":"searchFiles"}', }; const result = extractToolUsageFromAsk(message); expect(result).toEqual({ action: 'Grepped', - details: 'test pattern', }); }); diff --git a/apps/web/src/lib/toolUsageParser.ts b/apps/web/src/lib/toolUsageParser.ts index 9811851955..56a305393f 100644 --- a/apps/web/src/lib/toolUsageParser.ts +++ b/apps/web/src/lib/toolUsageParser.ts @@ -32,12 +32,12 @@ export function extractToolUsageFromAsk(message: { case 'editedExistingFile': return { action: 'Edited', - details: path || undefined, + details: path, }; case 'createdNewFile': return { action: 'Created', - details: path || undefined, + details: path, }; case 'readFile': // Handle batch files (multiple reads) @@ -59,32 +59,32 @@ export function extractToolUsageFromAsk(message: { // Handle single file read return { action: 'Read', - details: path || undefined, + details: path, }; case 'searchFiles': return { action: 'Grepped', - details: regex || query || 'pattern', + details: regex, }; case 'listFiles': return { action: 'Listed', - details: path || undefined, + details: path, }; case 'listFilesTopLevel': return { action: 'Listed', - details: path || undefined, + details: path, }; case 'listFilesRecursive': return { action: 'Listed', - details: path || undefined, + details: path, }; case 'newFileCreated': return { action: 'Created', - details: path || undefined, + details: path, }; case 'appliedDiff': // Handle batch diffs (multiple file edits) @@ -106,7 +106,7 @@ export function extractToolUsageFromAsk(message: { // Handle single file diff return { action: 'Edited', - details: path || undefined, + details: path, }; default: return null;