refactor: remove redundant terminal ID from event handling

As pointed out by @cte, passing and checking terminal IDs in events is
unnecessary since a TerminalProcess instance can never be associated with a
different Terminal instance. The event handling is already properly scoped
to the specific TerminalProcess instance.

- Remove terminal ID parameter from shell_execution_complete event
- Remove terminal ID parameter from stream_available event
- Update all event handlers to remove ID checks
- Update all test cases to match new event signatures

Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

src/core/Cline.ts

@@ -982,10 +982,8 @@ export class Cline {
 			completed = true
 		})
 
-		process.once("shell_execution_complete", (id: number, details: ExitCodeDetails) => {
-			if (id === terminalInfo.id) {
-				exitDetails = details
-			}
+		process.once("shell_execution_complete", (details: ExitCodeDetails) => {
+			exitDetails = details
 		})
 
 		process.once("no_shell_integration", async () => {

src/integrations/terminal/Terminal.ts

@@ -60,7 +60,7 @@ export class Terminal {
 
 			this.streamClosed = false
 			this.running = true
-			this.process.emit("stream_available", this.id, stream)
+			this.process.emit("stream_available", stream)
 		} else {
 			// Stream is being closed
 			this.streamClosed = true
@@ -81,7 +81,7 @@ export class Terminal {
 				this.completedProcesses.unshift(this.process)
 			}
 
-			this.process.emit("shell_execution_complete", this.id, exitDetails)
+			this.process.emit("shell_execution_complete", exitDetails)
 			this.process = undefined
 		}
 	}

src/integrations/terminal/TerminalProcess.ts

@@ -108,8 +108,8 @@ export interface TerminalProcessEvents {
 	 * @param id The terminal ID
 	 * @param exitDetails Contains exit code and signal information if process was terminated by signal
 	 */
-	shell_execution_complete: [id: number, exitDetails: ExitCodeDetails]
-	stream_available: [id: number, stream: AsyncIterable<string>]
+	shell_execution_complete: [exitDetails: ExitCodeDetails]
+	stream_available: [stream: AsyncIterable<string>]
 }
 
 // how long to wait after a process outputs anything before we consider it "cool" again
@@ -247,19 +247,15 @@ export class TerminalProcess extends EventEmitter<TerminalProcessEvents> {
 		if (terminal.shellIntegration && terminal.shellIntegration.executeCommand) {
 			// Create a promise that resolves when the stream becomes available
 			const streamAvailable = new Promise<AsyncIterable<string>>((resolve) => {
-				this.once("stream_available", (id: number, stream: AsyncIterable<string>) => {
-					if (id === this.terminalInfo.id) {
-						resolve(stream)
-					}
+				this.once("stream_available", (stream: AsyncIterable<string>) => {
+					resolve(stream)
 				})
 			})
 
 			// Create promise that resolves when shell execution completes for this terminal
 			const shellExecutionComplete = new Promise<ExitCodeDetails>((resolve) => {
-				this.once("shell_execution_complete", (id: number, exitDetails: ExitCodeDetails) => {
-					if (id === this.terminalInfo.id) {
-						resolve(exitDetails)
-					}
+				this.once("shell_execution_complete", (exitDetails: ExitCodeDetails) => {
+					resolve(exitDetails)
 				})
 			})
 

src/integrations/terminal/__tests__/TerminalProcess.test.ts

@@ -85,7 +85,7 @@ describe("TerminalProcess", () => {
 				yield "More output\n"
 				yield "Final output"
 				yield "\x1b]633;D\x07" // The last chunk contains the command end sequence with bell character.
-				terminalProcess.emit("shell_execution_complete", mockTerminalInfo.id, { exitCode: 0 })
+				terminalProcess.emit("shell_execution_complete", { exitCode: 0 })
 			})()
 
 			mockExecution = {
@@ -95,7 +95,7 @@ describe("TerminalProcess", () => {
 			mockTerminal.shellIntegration.executeCommand.mockReturnValue(mockExecution)
 
 			const runPromise = terminalProcess.run("test command")
-			terminalProcess.emit("stream_available", mockTerminalInfo.id, mockStream)
+			terminalProcess.emit("stream_available", mockStream)
 			await runPromise
 
 			expect(lines).toEqual(["Initial output", "More output", "Final output"])
@@ -157,7 +157,7 @@ describe("TerminalProcess", () => {
 				yield "still compiling...\n"
 				yield "done"
 				yield "\x1b]633;D\x07" // The last chunk contains the command end sequence with bell character.
-				terminalProcess.emit("shell_execution_complete", mockTerminalInfo.id, { exitCode: 0 })
+				terminalProcess.emit("shell_execution_complete", { exitCode: 0 })
 			})()
 
 			mockTerminal.shellIntegration.executeCommand.mockReturnValue({
@@ -165,7 +165,7 @@ describe("TerminalProcess", () => {
 			})
 
 			const runPromise = terminalProcess.run("npm run build")
-			terminalProcess.emit("stream_available", mockTerminalInfo.id, mockStream)
+			terminalProcess.emit("stream_available", mockStream)
 
 			expect(terminalProcess.isHot).toBe(true)
 			await runPromise