From 7d880f172e62f9cee15a1989783f6e22bdd72b7c Mon Sep 17 00:00:00 2001
From: "Steven T. Cramer" <Steven.Cramer@TimeWarp.Enterprises>
Date: Tue, 17 Jun 2025 00:38:08 +0700
Subject: [PATCH] Remove any type assertions in DirectiveStreamingParser.ts by
 introducing ParameterCodeBlockHandler interface

---
 src/core/message-parsing/DirectiveStreamingParser.ts | 12 +++++++-----
 .../message-parsing/ParameterCodeBlockHandler.ts     | 12 ++++++++++++
 2 files changed, 19 insertions(+), 5 deletions(-)
 create mode 100644 src/core/message-parsing/ParameterCodeBlockHandler.ts

diff --git a/src/core/message-parsing/DirectiveStreamingParser.ts b/src/core/message-parsing/DirectiveStreamingParser.ts
index 12cc471e98..fe8c6a8258 100644
--- a/src/core/message-parsing/DirectiveStreamingParser.ts
+++ b/src/core/message-parsing/DirectiveStreamingParser.ts
@@ -5,6 +5,7 @@ import { DirectiveRegistryFactory } from "./DirectiveRegistryFactory"
 import { FallbackParser } from "./FallbackParser"
 import { XmlUtils } from "./XmlUtils"
 import { DirectiveHandler } from "./DirectiveHandler"
+import { ParameterCodeBlockHandler } from "./ParameterCodeBlockHandler"
 import { ToolDirectiveHandler } from "./handlers"
 
 export class DirectiveStreamingParser {
@@ -124,8 +125,8 @@ export class DirectiveStreamingParser {
 		return (
 			context.codeBlockState === CodeBlockState.INSIDE ||
 			(activeHandler &&
-				"isInsideParameterCodeBlock" in activeHandler &&
-				(activeHandler as any).isInsideParameterCodeBlock())
+				activeHandler instanceof ToolDirectiveHandler &&
+				(activeHandler as ParameterCodeBlockHandler).isInsideParameterCodeBlock())
 		)
 	}
 
@@ -133,15 +134,16 @@ export class DirectiveStreamingParser {
 	 * Check if we're inside a tool parameter (but not at the parameter level itself)
 	 */
 	private static isInsideToolParameter(activeHandler: DirectiveHandler | null, tagName?: string): boolean {
-		if (!activeHandler || activeHandler.constructor.name !== "ToolDirectiveHandler") {
+		if (!activeHandler || !(activeHandler instanceof ToolDirectiveHandler)) {
 			return false
 		}
 
-		const isInParamContext = (activeHandler as any).currentContext === "param"
+		const typedHandler = activeHandler as ParameterCodeBlockHandler
+		const isInParamContext = typedHandler.currentContext === "param"
 
 		// For close tags, also check if this is not the parameter tag itself
 		if (tagName !== undefined) {
-			return isInParamContext && tagName !== (activeHandler as any).currentParamName
+			return isInParamContext && tagName !== typedHandler.currentParamName
 		}
 
 		// For open tags, just check if we're in param context
diff --git a/src/core/message-parsing/ParameterCodeBlockHandler.ts b/src/core/message-parsing/ParameterCodeBlockHandler.ts
new file mode 100644
index 0000000000..2cece6abab
--- /dev/null
+++ b/src/core/message-parsing/ParameterCodeBlockHandler.ts
@@ -0,0 +1,12 @@
+import { DirectiveHandler } from "./DirectiveHandler"
+
+/**
+ * Interface for directive handlers that support parameter code block detection.
+ * Extends the base DirectiveHandler to include methods and properties specific to
+ * tool directive handling.
+ */
+export interface ParameterCodeBlockHandler extends DirectiveHandler {
+	isInsideParameterCodeBlock(): boolean
+	currentContext: "param" | "none"
+	currentParamName?: string
+}