scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-07 08:26:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix terminal isHot logic to take into account commands that finished running and could have affected diagnostics

Browse source
This commit is contained in:
Saoud Rizwan 2024-09-14 16:32:27 -04:00
parent 3f783aaae5
commit 7a9088a2d3
2 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/ClaudeDev.ts
View file

@ -1848,14 +1848,17 @@ ${this.customInstructions.trim()}
}
const busyTerminals = this.terminalManager.getTerminals(true)
const inactiveTerminals = this.terminalManager.getTerminals(false)
const allTerminals = [...busyTerminals, ...inactiveTerminals]
if (busyTerminals.length > 0 || this.didEditFile) {
await delay(300) // delay after saving file to let terminals/diagnostics catch up
}
if (busyTerminals.length > 0) {
if (allTerminals.length > 0) {
// wait for terminals to cool down
await pWaitFor(() => busyTerminals.every((t) => !this.terminalManager.isProcessHot(t.id)), {
// note this does not mean they're actively running just that they recently output something
await pWaitFor(() => allTerminals.every((t) => !this.terminalManager.isProcessHot(t.id)), {
interval: 100,
timeout: 15_000,
}).catch(() => {})
@ -1896,7 +1899,6 @@ ${this.customInstructions.trim()}
}
}
// only show inactive terminals if there's output to show
const inactiveTerminals = this.terminalManager.getTerminals(false)
if (inactiveTerminals.length > 0) {
const inactiveTerminalOutputs = new Map<number, string>()
for (const inactiveTerminal of inactiveTerminals) {

9
src/integrations/TerminalManager.ts
View file

@ -377,10 +377,11 @@ export class TerminalProcess extends EventEmitter<TerminalProcessEvents> {
this.emitRemainingBufferIfListening()
if (this.hotTimer) {
clearTimeout(this.hotTimer)
}
this.isHot = false
// even though the command is finished, we still want to consider it 'hot' in case so that api request stalls to let diagnostics catch up
// if (this.hotTimer) {
// clearTimeout(this.hotTimer)
// }
// this.isHot = false
this.emit("completed")
this.emit("continue")