scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-08-28 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove provider from useEffect dependencies to prevent re-renders

Browse source 
The provider state was being updated inside the effect while also being
included in the dependency array, which could cause unnecessary re-renders
or potential infinite loops. Fixed by using a local newProvider variable
to calculate the correct selected model before updating state.
This commit is contained in:
daniel-lxs 2025-09-12 17:35:40 -05:00 • committed by Hannes Rudolph
parent 70c769535c
commit 71c2bcf1df
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
webview-ui/src/components/settings/ImageGenerationSettings.tsx
View file

@ -60,10 +60,11 @@ export const ImageGenerationSettings = ({
useEffect(() => {
setOpenRouterApiKeyLocal(openRouterImageApiKey || "")
setGeminiApiKeyLocal(geminiApiKey || "")
setProvider(imageGenerationProvider || "openrouter")
// Calculate selected model directly in the effect
const newProvider = imageGenerationProvider || "openrouter"
setProvider(newProvider)
// Calculate selected model based on the new provider value
const newSelectedModel =
provider === "openrouter"
newProvider === "openrouter"
? openRouterImageGenerationSelectedModel || getDefaultModel("openrouter")
: geminiImageGenerationSelectedModel || getDefaultModel("gemini")
setSelectedModel(newSelectedModel)
@ -73,7 +74,6 @@ export const ImageGenerationSettings = ({
openRouterImageGenerationSelectedModel,
geminiImageGenerationSelectedModel,
imageGenerationProvider,
provider,
])
// Handle provider change