scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-10-07 02:58:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

security: fix polynomial regex and improve URL sanitization in imageDataUrl.ts

Browse source 
- Replace potentially polynomial regex /(?:Users|C:)([^?#]+\.(?:png|jpg|jpeg|gif|webp))/i
- Split into separate bounded patterns for Unix and Windows paths
- Add length limit {0,500} to prevent ReDoS attacks
- Improve URL substring sanitization for vscode-userdata and vscode-cdn.net URIs
- Addresses GitHub CodeQL security warnings for polynomial regex vulnerability
This commit is contained in:
daniel-lxs 2025-10-27 14:24:06 -05:00
parent 32b708592d
commit 7029f1d6f8
No known key found for this signature in database
GPG key ID: 21C74479048B3AA6
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/integrations/misc/imageDataUrl.ts
View file

@ -57,11 +57,18 @@ function webviewUriToFilePath(webviewUri: string): string {
if (webviewUri.includes("vscode-userdata") || webviewUri.includes("vscode-cdn.net")) {
// Try to decode the URI and extract the file path
const decoded = decodeURIComponent(webviewUri)
// Look for a file path pattern in the decoded URI
const pathMatch = decoded.match(/(?:Users|C:)([^?#]+\.(?:png|jpg|jpeg|gif|webp))/i)
// Use safer, non-polynomial regex patterns
// Look for Unix-style paths first
let pathMatch = decoded.match(/\/Users\/[^?#]*\.(?:png|jpg|jpeg|gif|webp)/i)
if (pathMatch) {
const extractedPath = pathMatch[0]
return extractedPath
return pathMatch[0]
}
// Look for Windows-style paths with bounded length to prevent polynomial behavior
pathMatch = decoded.match(/C:\\[^?#]{0,500}\.(?:png|jpg|jpeg|gif|webp)/i)
if (pathMatch) {
return pathMatch[0]
}
}