From 5d8e66788e5a6093bb835d7f5cb40709717c22bd Mon Sep 17 00:00:00 2001 From: Roo Code Date: Thu, 14 Aug 2025 14:56:53 +0000 Subject: [PATCH] fix: exclude enableReasoningEffort from initial sync to enable Save button When the user clicks the "Enable reasoning" checkbox, the Save button should become enabled. Previously, the transition from undefined to true was treated as an initial sync, preventing the button from enabling. This fix explicitly excludes enableReasoningEffort from the initial sync logic since it is a user-controlled checkbox that should always trigger changes. Fixes #7099 --- webview-ui/src/components/settings/SettingsView.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webview-ui/src/components/settings/SettingsView.tsx b/webview-ui/src/components/settings/SettingsView.tsx index 987d245105..742362caaf 100644 --- a/webview-ui/src/components/settings/SettingsView.tsx +++ b/webview-ui/src/components/settings/SettingsView.tsx @@ -229,7 +229,9 @@ const SettingsView = forwardRef(({ onDone, t // Don't treat initial sync from undefined to a defined value as a user change // This prevents the dirty state when the component initializes and auto-syncs the model ID - const isInitialSync = previousValue === undefined && value !== undefined + // Exception: enableReasoningEffort is a user-controlled checkbox that should always trigger changes + const isInitialSync = + previousValue === undefined && value !== undefined && field !== "enableReasoningEffort" if (!isInitialSync) { setChangeDetected(true)