bugfix: Update PAGER env for Windows compatibility in Terminal (#3986)

Update PAGER environment variable for Windows compatibility in Terminal class
This commit is contained in:
மனோஜ்குமார் பழனிச்சாமி 2025-05-29 00:35:00 +05:30 • committed by GitHub
parent 2c58caeb59
commit 5c4280c103
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 6 deletions

View file

@ -152,7 +152,7 @@ export class Terminal extends BaseTerminal {
public static getEnv(): Record<string, string> {
const env: Record<string, string> = {
PAGER: "cat",
PAGER: process.platform === "win32" ? "" : "cat",
// VTE must be disabled because it prevents the prompt command from executing
// See https://wiki.gnome.org/Apps/Terminal/VTE

View file

@ -3,6 +3,8 @@
import { Terminal } from "../Terminal"
import { TerminalRegistry } from "../TerminalRegistry"
const PAGER = process.platform === "win32" ? "" : "cat"
// Mock vscode.window.createTerminal
const mockCreateTerminal = jest.fn()
@ -29,7 +31,7 @@ describe("TerminalRegistry", () => {
})
describe("createTerminal", () => {
it("creates terminal with PAGER set to cat", () => {
it("creates terminal with PAGER set appropriately for platform", () => {
TerminalRegistry.createTerminal("/test/path", "vscode")
expect(mockCreateTerminal).toHaveBeenCalledWith({
@ -37,7 +39,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
},
@ -57,7 +59,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
PROMPT_COMMAND: "sleep 0.05",
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
@ -79,7 +81,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
ITERM_SHELL_INTEGRATION_INSTALLED: "Yes",
@ -100,7 +102,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
POWERLEVEL9K_TERM_SHELL_INTEGRATION: "true",