From 5a2f2eadc63df7aa77056abf7c674eab5a5cc9ba Mon Sep 17 00:00:00 2001 From: System233 Date: Fri, 21 Feb 2025 05:07:02 +0800 Subject: [PATCH] Revert "Fix settings done button with unsaved changes" This reverts commit e69f27d3193e816c62dc58f0e811932b4d733f9c. --- .changeset/twenty-rice-own.md | 5 ----- webview-ui/src/components/settings/SettingsView.tsx | 7 ++----- 2 files changed, 2 insertions(+), 10 deletions(-) delete mode 100644 .changeset/twenty-rice-own.md diff --git a/.changeset/twenty-rice-own.md b/.changeset/twenty-rice-own.md deleted file mode 100644 index 0c3ccb141a..0000000000 --- a/.changeset/twenty-rice-own.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"roo-cline": patch ---- - -Fix settings done button with unsaved changes diff --git a/webview-ui/src/components/settings/SettingsView.tsx b/webview-ui/src/components/settings/SettingsView.tsx index f4c49b398d..495bf49bd7 100644 --- a/webview-ui/src/components/settings/SettingsView.tsx +++ b/webview-ui/src/components/settings/SettingsView.tsx @@ -173,6 +173,7 @@ const SettingsView = forwardRef(({ onDone }, text: currentApiConfigName, apiConfiguration, }) + // onDone() setChangeDetected(false) } } @@ -216,11 +217,7 @@ const SettingsView = forwardRef(({ onDone }, const onConfirmDialogResult = useCallback((confirm: boolean) => { if (confirm) { - setChangeDetected(false) - // Wait for the change detection to be updated - setTimeout(() => { - confirmDialogHandler.current?.() - }, 100) + confirmDialogHandler.current?.() } }, [])