scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-08-28 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(web-evals): remember last Roo model selection + add evals skill (#10470)

Browse source 
* feat(web-evals): remember last Roo model selection

* fix(web-evals): reset model selections on provider switch and fix lint warning

- Add useEffect to reset model selections when switching between providers
  This prevents OpenRouter model IDs from persisting when switching to Roo,
  which was causing Roo's stored selection to be overwritten with wrong IDs

- Remove unused 'executionMethod' from onSubmit dependency array to fix
  react-hooks/exhaustive-deps warning

* fix(web-evals): add missing executionMethod to test cases

* fix(web-evals): harden localStorage + keep provider selections
This commit is contained in:
Hannes Rudolph 2026-01-07 08:00:34 -07:00 • committed by GitHub
parent 2d22804d4a
commit 41c5ff6076
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 514 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

188
.roo/skills/evals-context/SKILL.md Normal file
View file

@ -0,0 +1,188 @@
---
name: evals-context
description: Provides context about the Roo Code evals system structure in this monorepo. Use when tasks mention "evals", "evaluation", "eval runs", "eval exercises", or working with the evals infrastructure. Helps distinguish between the evals execution system (packages/evals, apps/web-evals) and the public website evals display page (apps/web-roo-code/src/app/evals).
---
# Evals Codebase Context
## When to Use This Skill
Use this skill when the task involves:
- Modifying or debugging the evals execution infrastructure
- Adding new eval exercises or languages
- Working with the evals web interface (apps/web-evals)
- Modifying the public evals display page on roocode.com
- Understanding where evals code lives in this monorepo
## When NOT to Use This Skill
Do NOT use this skill when:
- Working on unrelated parts of the codebase (extension, webview-ui, etc.)
- The task is purely about the VS Code extension's core functionality
- Working on the main website pages that don't involve evals
## Key Disambiguation: Two "Evals" Locations
This monorepo has **two distinct evals-related locations** that can cause confusion:
| Component | Path | Purpose |
| --------------------------- | -------------------------------------------------------------- | -------------------------------------------------------------- |
| **Evals Execution System** | `packages/evals/` | Core eval infrastructure: CLI, DB schema, Docker configs |
| **Evals Management UI** | `apps/web-evals/` | Next.js app for creating/monitoring eval runs (localhost:3446) |
| **Website Evals Page** | `apps/web-roo-code/src/app/evals/` | Public roocode.com page displaying eval results |
| **External Exercises Repo** | [Roo-Code-Evals](https://github.com/RooCodeInc/Roo-Code-Evals) | Actual coding exercises (NOT in this monorepo) |
## Directory Structure Reference
### `packages/evals/` - Core Evals Package
```
packages/evals/
├── ARCHITECTURE.md # Detailed architecture documentation
├── ADDING-EVALS.md # Guide for adding new exercises/languages
├── README.md # Setup and running instructions
├── docker-compose.yml # Container orchestration
├── Dockerfile.runner # Runner container definition
├── Dockerfile.web # Web app container
├── drizzle.config.ts # Database ORM config
├── src/
│ ├── index.ts # Package exports
│ ├── cli/ # CLI commands for running evals
│ │ ├── runEvals.ts # Orchestrates complete eval runs
│ │ ├── runTask.ts # Executes individual tasks in containers
│ │ ├── runUnitTest.ts # Validates task completion via tests
│ │ └── redis.ts # Redis pub/sub integration
│ ├── db/
│ │ ├── schema.ts # Database schema (runs, tasks)
│ │ ├── queries/ # Database query functions
│ │ └── migrations/ # SQL migrations
│ └── exercises/
│ └── index.ts # Exercise loading utilities
└── scripts/
└── setup.sh # Local macOS setup script
```
### `apps/web-evals/` - Evals Management Web App
```
apps/web-evals/
├── src/
│ ├── app/
│ │ ├── page.tsx # Home page (runs list)
│ │ ├── runs/
│ │ │ ├── new/ # Create new eval run
│ │ │ └── [id]/ # View specific run status
│ │ └── api/runs/ # SSE streaming endpoint
│ ├── actions/ # Server actions
│ │ ├── runs.ts # Run CRUD operations
│ │ ├── tasks.ts # Task queries
│ │ ├── exercises.ts # Exercise listing
│ │ └── heartbeat.ts # Controller health checks
│ ├── hooks/ # React hooks (SSE, models, etc.)
│ └── lib/ # Utilities and schemas
```
### `apps/web-roo-code/src/app/evals/` - Public Website Evals Page
```
apps/web-roo-code/src/app/evals/
├── page.tsx # Fetches and displays public eval results
├── evals.tsx # Main evals display component
├── plot.tsx # Visualization component
└── types.ts # EvalRun type (extends packages/evals types)
```
This page **displays** eval results on the public roocode.com website. It imports types from `@roo-code/evals` but does NOT run evals.
## Architecture Overview
The evals system is a distributed evaluation platform that runs AI coding tasks in isolated VS Code environments:
```
┌─────────────────────────────────────────────────────────────┐
│ Web App (apps/web-evals) ──────────────────────────────── │
│ │ │
│ ▼ │
│ PostgreSQL ◄────► Controller Container │
│ │ │ │
│ ▼ ▼ │
│ Redis ◄───► Runner Containers (1-25 parallel) │
└─────────────────────────────────────────────────────────────┘
```
**Key components:**
- **Controller**: Orchestrates eval runs, spawns runners, manages task queue (p-queue)
- **Runner**: Isolated Docker container with VS Code + Roo Code extension + language runtimes
- **Redis**: Pub/sub for real-time events (NOT task queuing)
- **PostgreSQL**: Stores runs, tasks, metrics
## Common Tasks Quick Reference
### Adding a New Eval Exercise
1. Add exercise to [Roo-Code-Evals](https://github.com/RooCodeInc/Roo-Code-Evals) repo (external)
2. See [`packages/evals/ADDING-EVALS.md`](packages/evals/ADDING-EVALS.md) for structure
### Modifying Eval CLI Behavior
Edit files in [`packages/evals/src/cli/`](packages/evals/src/cli/):
- [`runEvals.ts`](packages/evals/src/cli/runEvals.ts) - Run orchestration
- [`runTask.ts`](packages/evals/src/cli/runTask.ts) - Task execution
- [`runUnitTest.ts`](packages/evals/src/cli/runUnitTest.ts) - Test validation
### Modifying the Evals Web Interface
Edit files in [`apps/web-evals/src/`](apps/web-evals/src/):
- [`app/runs/new/new-run.tsx`](apps/web-evals/src/app/runs/new/new-run.tsx) - New run form
- [`actions/runs.ts`](apps/web-evals/src/actions/runs.ts) - Run server actions
### Modifying the Public Evals Display Page
Edit files in [`apps/web-roo-code/src/app/evals/`](apps/web-roo-code/src/app/evals/):
- [`evals.tsx`](apps/web-roo-code/src/app/evals/evals.tsx) - Display component
- [`plot.tsx`](apps/web-roo-code/src/app/evals/plot.tsx) - Charts
### Database Schema Changes
1. Edit [`packages/evals/src/db/schema.ts`](packages/evals/src/db/schema.ts)
2. Generate migration: `cd packages/evals && pnpm drizzle-kit generate`
3. Apply migration: `pnpm drizzle-kit migrate`
## Running Evals Locally
```bash
# From repo root
pnpm evals
# Opens web UI at http://localhost:3446
```
**Ports (defaults):**
- PostgreSQL: 5433
- Redis: 6380
- Web: 3446
## Testing
```bash
# packages/evals tests
cd packages/evals && npx vitest run
# apps/web-evals tests
cd apps/web-evals && npx vitest run
```
## Key Types/Exports from `@roo-code/evals`
The package exports are defined in [`packages/evals/src/index.ts`](packages/evals/src/index.ts):
- Database queries: `getRuns`, `getTasks`, `getTaskMetrics`, etc.
- Schema types: `Run`, `Task`, `TaskMetrics`
- Used by both `apps/web-evals` and `apps/web-roo-code`

92
apps/web-evals/src/app/runs/new/new-run.tsx
View file

@ -1,6 +1,6 @@
"use client"
import { useCallback, useEffect, useMemo, useState } from "react"
import { useCallback, useEffect, useMemo, useRef, useState } from "react"
import { useRouter } from "next/navigation"
import { z } from "zod"
import { useQuery } from "@tanstack/react-query"
@ -48,6 +48,9 @@ import {
} from "@/lib/schemas"
import { cn } from "@/lib/utils"
import { loadRooLastModelSelection, saveRooLastModelSelection } from "@/lib/roo-last-model-selection"
import { normalizeCreateRunForSubmit } from "@/lib/normalize-create-run"
import { useOpenRouterModels } from "@/hooks/use-open-router-models"
import { useRooCodeCloudModels } from "@/hooks/use-roo-code-cloud-models"
@ -103,6 +106,8 @@ type ConfigSelection = {
export function NewRun() {
const router = useRouter()
const modelSelectionsByProviderRef = useRef<Record<string, ModelSelection[]>>({})
const modelValueByProviderRef = useRef<Record<string, string>>({})
const [provider, setModelSource] = useState<"roo" | "openrouter" | "other">("other")
const [executionMethod, setExecutionMethod] = useState<ExecutionMethod>("vscode")
@ -147,14 +152,43 @@ export function NewRun() {
})
const {
register,
setValue,
clearErrors,
watch,
getValues,
formState: { isSubmitting },
} = form
const [suite, settings] = watch(["suite", "settings", "concurrency"])
const selectedModelIds = useMemo(
() => modelSelections.map((s) => s.model).filter((m) => m.length > 0),
[modelSelections],
)
const applyModelIds = useCallback(
(modelIds: string[]) => {
const unique = Array.from(new Set(modelIds.map((m) => m.trim()).filter((m) => m.length > 0)))
if (unique.length === 0) {
setModelSelections([{ id: crypto.randomUUID(), model: "", popoverOpen: false }])
setValue("model", "")
return
}
setModelSelections(unique.map((model) => ({ id: crypto.randomUUID(), model, popoverOpen: false })))
setValue("model", unique[0] ?? "")
},
[setValue],
)
// Ensure the `exercises` field is registered so RHF always includes it in submit values.
useEffect(() => {
register("exercises")
}, [register])
// Load settings from localStorage on mount
useEffect(() => {
const savedConcurrency = localStorage.getItem("evals-concurrency")
@ -215,6 +249,51 @@ export function NewRun() {
}
}, [setValue])
// Track previous provider to detect switches
const [prevProvider, setPrevProvider] = useState(provider)
// Preserve selections per provider; avoids cross-contamination while keeping UX stable.
useEffect(() => {
if (provider === prevProvider) return
modelSelectionsByProviderRef.current[prevProvider] = modelSelections
modelValueByProviderRef.current[prevProvider] = getValues("model")
const nextModelSelections =
modelSelectionsByProviderRef.current[provider] ??
([{ id: crypto.randomUUID(), model: "", popoverOpen: false }] satisfies ModelSelection[])
setModelSelections(nextModelSelections)
const nextModelValue =
modelValueByProviderRef.current[provider] ??
nextModelSelections.find((s) => s.model.trim().length > 0)?.model ??
(provider === "other" && importedSettings && configSelections[0]?.configName
? (getModelId(importedSettings.apiConfigs[configSelections[0].configName] ?? {}) ?? "")
: "")
setValue("model", nextModelValue)
setPrevProvider(provider)
}, [provider, prevProvider, modelSelections, setValue, getValues, importedSettings, configSelections])
// When switching to Roo provider, restore last-used selection if current selection is empty
useEffect(() => {
if (provider !== "roo") return
if (selectedModelIds.length > 0) return
const last = loadRooLastModelSelection()
if (last.length > 0) {
applyModelIds(last)
}
}, [applyModelIds, provider, selectedModelIds.length])
// Persist last-used Roo provider model selection
useEffect(() => {
if (provider !== "roo") return
saveRooLastModelSelection(selectedModelIds)
}, [provider, selectedModelIds])
// Extract unique languages from exercises
const languages = useMemo(() => {
if (!exercises.data) {
return []
@ -337,7 +416,10 @@ export function NewRun() {
const onSubmit = useCallback(
async (values: CreateRun) => {
try {
if (provider === "roo" && !values.jobToken?.trim()) {
const baseValues = normalizeCreateRunForSubmit(values, selectedExercises, suite)
// Validate jobToken for Roo Code Cloud provider
if (provider === "roo" && !baseValues.jobToken?.trim()) {
toast.error("Roo Code Cloud Token is required")
return
}
@ -374,8 +456,7 @@ export function NewRun() {
await new Promise((resolve) => setTimeout(resolve, 20_000))
}
const runValues = { ...values }
runValues.executionMethod = executionMethod
const runValues = { ...baseValues }
if (provider === "openrouter") {
runValues.model = selection.model
@ -424,8 +505,9 @@ export function NewRun() {
}
},
[
suite,
selectedExercises,
provider,
executionMethod,
modelSelections,
configSelections,
importedSettings,

65
apps/web-evals/src/lib/__tests__/normalize-create-run.spec.ts Normal file
View file

@ -0,0 +1,65 @@
import { normalizeCreateRunForSubmit } from "../normalize-create-run"
describe("normalizeCreateRunForSubmit", () => {
it("uses selectedExercises for partial suite", () => {
const result = normalizeCreateRunForSubmit(
{
model: "roo/model-a",
description: "",
suite: "partial",
exercises: [],
settings: undefined,
concurrency: 1,
timeout: 5,
iterations: 1,
jobToken: "",
executionMethod: "vscode",
},
["js/foo", "py/bar"],
)
expect(result.suite).toBe("partial")
expect(result.exercises).toEqual(["js/foo", "py/bar"])
})
it("dedupes selectedExercises for partial suite", () => {
const result = normalizeCreateRunForSubmit(
{
model: "roo/model-a",
description: "",
suite: "partial",
exercises: [],
settings: undefined,
concurrency: 1,
timeout: 5,
iterations: 1,
jobToken: "",
executionMethod: "vscode",
},
["js/foo", "js/foo", "py/bar"],
)
expect(result.exercises).toEqual(["js/foo", "py/bar"])
})
it("clears exercises for full suite", () => {
const result = normalizeCreateRunForSubmit(
{
model: "roo/model-a",
description: "",
suite: "full",
exercises: ["js/foo"],
settings: undefined,
concurrency: 1,
timeout: 5,
iterations: 1,
jobToken: "",
executionMethod: "vscode",
},
["js/foo"],
)
expect(result.suite).toBe("full")
expect(result.exercises).toEqual([])
})
})

78
apps/web-evals/src/lib/__tests__/roo-last-model-selection.spec.ts Normal file
View file

@ -0,0 +1,78 @@
import {
loadRooLastModelSelection,
ROO_LAST_MODEL_SELECTION_KEY,
saveRooLastModelSelection,
} from "../roo-last-model-selection"
class LocalStorageMock implements Storage {
private store = new Map<string, string>()
get length(): number {
return this.store.size
}
clear(): void {
this.store.clear()
}
getItem(key: string): string | null {
return this.store.get(key) ?? null
}
key(index: number): string | null {
return Array.from(this.store.keys())[index] ?? null
}
removeItem(key: string): void {
this.store.delete(key)
}
setItem(key: string, value: string): void {
this.store.set(key, value)
}
}
beforeEach(() => {
Object.defineProperty(globalThis, "localStorage", {
value: new LocalStorageMock(),
configurable: true,
})
})
describe("roo-last-model-selection", () => {
it("saves and loads (deduped + trimmed)", () => {
saveRooLastModelSelection([" roo/model-a ", "roo/model-a", "roo/model-b"])
expect(loadRooLastModelSelection()).toEqual(["roo/model-a", "roo/model-b"])
})
it("ignores invalid JSON", () => {
localStorage.setItem(ROO_LAST_MODEL_SELECTION_KEY, "{this is not json")
expect(loadRooLastModelSelection()).toEqual([])
})
it("clears when empty", () => {
localStorage.setItem(ROO_LAST_MODEL_SELECTION_KEY, JSON.stringify(["roo/model-a"]))
saveRooLastModelSelection([])
expect(localStorage.getItem(ROO_LAST_MODEL_SELECTION_KEY)).toBeNull()
})
it("does not throw if localStorage access fails", () => {
Object.defineProperty(globalThis, "localStorage", {
value: {
getItem: () => {
throw new Error("blocked")
},
setItem: () => {
throw new Error("blocked")
},
removeItem: () => {
throw new Error("blocked")
},
},
configurable: true,
})
expect(() => loadRooLastModelSelection()).not.toThrow()
expect(() => saveRooLastModelSelection(["roo/model-a"])).not.toThrow()
})
})

20
apps/web-evals/src/lib/normalize-create-run.ts Normal file
View file

@ -0,0 +1,20 @@
import type { CreateRun } from "./schemas"
/**
* The New Run UI keeps exercise selection in component state.
* This normalizer ensures we submit the *visible/selected* exercises when suite is partial.
*/
export function normalizeCreateRunForSubmit(
values: CreateRun,
selectedExercises: string[],
suiteOverride?: CreateRun["suite"],
): CreateRun {
const suite = suiteOverride ?? values.suite
const normalizedSelectedExercises = Array.from(new Set(selectedExercises))
return {
...values,
suite,
exercises: suite === "partial" ? normalizedSelectedExercises : [],
}
}

76
apps/web-evals/src/lib/roo-last-model-selection.ts Normal file
View file

@ -0,0 +1,76 @@
import { z } from "zod"
export const ROO_LAST_MODEL_SELECTION_KEY = "evals-roo-last-model-selection"
const modelIdListSchema = z.array(z.string())
function hasLocalStorage(): boolean {
try {
return typeof localStorage !== "undefined"
} catch {
return false
}
}
function safeGetItem(key: string): string | null {
try {
return localStorage.getItem(key)
} catch {
return null
}
}
function safeSetItem(key: string, value: string): void {
try {
localStorage.setItem(key, value)
} catch {
// ignore
}
}
function safeRemoveItem(key: string): void {
try {
localStorage.removeItem(key)
} catch {
// ignore
}
}
function tryParseJson(raw: string | null): unknown {
if (raw === null) return undefined
try {
return JSON.parse(raw)
} catch {
return undefined
}
}
function normalizeModelIds(modelIds: string[]): string[] {
const unique = new Set<string>()
for (const id of modelIds) {
const trimmed = id.trim()
if (trimmed) unique.add(trimmed)
}
return Array.from(unique)
}
export function loadRooLastModelSelection(): string[] {
if (!hasLocalStorage()) return []
const parsed = modelIdListSchema.safeParse(tryParseJson(safeGetItem(ROO_LAST_MODEL_SELECTION_KEY)))
if (!parsed.success) return []
return normalizeModelIds(parsed.data)
}
export function saveRooLastModelSelection(modelIds: string[]): void {
if (!hasLocalStorage()) return
const normalized = normalizeModelIds(modelIds)
if (normalized.length === 0) {
safeRemoveItem(ROO_LAST_MODEL_SELECTION_KEY)
return
}
safeSetItem(ROO_LAST_MODEL_SELECTION_KEY, JSON.stringify(normalized))
}